From 032aaac5081adf85a7fbfb7d867b24bc7e66c34c Mon Sep 17 00:00:00 2001 From: DheerajSShetty Date: Thu, 28 Feb 2019 11:51:10 -0800 Subject: [PATCH] defer closing the ReadCloser in ObjectStoreGRPCServer.GetObject Signed-off-by: DheerajSShetty Fixes #1093 --- changelogs/unreleased/1236-DheerajSShetty | 1 + pkg/plugin/object_store.go | 1 + 2 files changed, 2 insertions(+) create mode 100644 changelogs/unreleased/1236-DheerajSShetty diff --git a/changelogs/unreleased/1236-DheerajSShetty b/changelogs/unreleased/1236-DheerajSShetty new file mode 100644 index 000000000..87a4984a1 --- /dev/null +++ b/changelogs/unreleased/1236-DheerajSShetty @@ -0,0 +1 @@ +Need to defer closing the the ReadCloser in ObjectStoreGRPCServer.GetObject diff --git a/pkg/plugin/object_store.go b/pkg/plugin/object_store.go index 3d9214cb6..5c00c4ada 100644 --- a/pkg/plugin/object_store.go +++ b/pkg/plugin/object_store.go @@ -284,6 +284,7 @@ func (s *ObjectStoreGRPCServer) GetObject(req *proto.GetObjectRequest, stream pr if err != nil { return err } + defer rdr.Close() chunk := make([]byte, byteChunkSize) for {