From 0dbf01606335843449758f62a3856cd82b61f525 Mon Sep 17 00:00:00 2001 From: Carlisia Date: Tue, 17 Mar 2020 07:55:14 -0700 Subject: [PATCH] Change "provider" to "plugin" Signed-off-by: Carlisia --- design/cli-install-changes.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/design/cli-install-changes.md b/design/cli-install-changes.md index 635c5521a..c00b90bc8 100644 --- a/design/cli-install-changes.md +++ b/design/cli-install-changes.md @@ -339,7 +339,9 @@ Azure #### Renaming "provider" to "plugin" -WIP +As part of this change, we should change to use the term `plugin` instead of `provider`. The reasoning: in practice, we usually have 1 plugin per provider, and if there is an implementation for both object store and volume snapshotter for that provider, it will all be contained in the same plugin. When we handle plugins, we follow this logic. In other words, there's a plugin name (ex: `velero.io/aws`) and it can contain implementations of kind `ObjectStore` and/or `VolumeSnapshotter`. + +But when we handle BSL ir VSL (and the CLI commands/flags that configure them), we use the term `provider`, which can cause ambiguity as if that is a kind of thing different from a plugin. If the plugin is the "thing" that contains the implementation for the desired provider, we should make it easier for the user to guess that and change BackupStorageLocation/VolumeSnapshotLocation `Spec.Provider` field to be called `Spec.Plugin` and all related CLI command flags to `plugin`, and update the docs accordingly. #### GitOps Compatibility