Fix schedule reconciler aliasing server-wide skipImmediately default (#10242)

When a Schedule has no explicit spec.skipImmediately, the reconciler
assigned &c.skipImmediately directly into the Schedule's spec pointer.
The subsequent write-through-pointer (*ptr = false) mutated the
reconciler's own shared field, silently disabling
--schedule-skip-immediately for every schedule reconciled afterward
for the life of the process.

Fix: copy the value into a fresh bool before taking its address.

Adds TestReconcileDoesNotCorruptReconcilerSkipImmediately, which
reconciles two schedules against one reconciler instance and asserts
the shared default is preserved.

Signed-off-by: Prajwal <percy38621@gmail.com>

pkg/controller/schedule_controller.go

@@ -111,7 +111,11 @@ func (c *scheduleReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
 	original := schedule.DeepCopy()
 
 	if schedule.Spec.SkipImmediately == nil {
-		schedule.Spec.SkipImmediately = &c.skipImmediately
+		// Copy the value rather than aliasing &c.skipImmediately: c is a long-lived
+		// singleton reconciler, and the block below can write through this pointer,
+		// which would otherwise mutate the reconciler's shared default field.
+		skipImmediately := c.skipImmediately
+		schedule.Spec.SkipImmediately = &skipImmediately
 	}
 	if schedule.Spec.SkipImmediately != nil && *schedule.Spec.SkipImmediately {
 		*schedule.Spec.SkipImmediately = false