From 2132506e8cdc175644baae365c1929bca35dccc0 Mon Sep 17 00:00:00 2001 From: Tiger Kaovilai Date: Fri, 1 Dec 2023 14:21:19 -0500 Subject: [PATCH] Add explicit enableCSI to TestProcessBackupCompletions Signed-off-by: Tiger Kaovilai --- pkg/controller/backup_controller_test.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pkg/controller/backup_controller_test.go b/pkg/controller/backup_controller_test.go index 736209e4a..d4262fc1d 100644 --- a/pkg/controller/backup_controller_test.go +++ b/pkg/controller/backup_controller_test.go @@ -595,6 +595,7 @@ func TestProcessBackupCompletions(t *testing.T) { backupLocation *velerov1api.BackupStorageLocation defaultVolumesToFsBackup bool defaultSnapshotMoveData bool + enableCSI bool expectedResult *velerov1api.Backup backupExists bool existenceCheckError error @@ -1034,6 +1035,7 @@ func TestProcessBackupCompletions(t *testing.T) { backup: defaultBackup().SnapshotMoveData(true).Result(), backupLocation: defaultBackupLocation, defaultVolumesToFsBackup: false, + enableCSI: true, expectedResult: &velerov1api.Backup{ TypeMeta: metav1.TypeMeta{ Kind: "Backup", @@ -1074,6 +1076,7 @@ func TestProcessBackupCompletions(t *testing.T) { backup: defaultBackup().SnapshotMoveData(false).Result(), backupLocation: defaultBackupLocation, defaultVolumesToFsBackup: false, + enableCSI: true, expectedResult: &velerov1api.Backup{ TypeMeta: metav1.TypeMeta{ Kind: "Backup", @@ -1114,6 +1117,7 @@ func TestProcessBackupCompletions(t *testing.T) { backup: defaultBackup().Result(), backupLocation: defaultBackupLocation, defaultVolumesToFsBackup: false, + enableCSI: true, expectedResult: &velerov1api.Backup{ TypeMeta: metav1.TypeMeta{ Kind: "Backup", @@ -1196,6 +1200,7 @@ func TestProcessBackupCompletions(t *testing.T) { backupLocation: defaultBackupLocation, defaultVolumesToFsBackup: false, defaultSnapshotMoveData: true, + enableCSI: true, expectedResult: &velerov1api.Backup{ TypeMeta: metav1.TypeMeta{ Kind: "Backup", @@ -1371,7 +1376,7 @@ func TestProcessBackupCompletions(t *testing.T) { require.NoError(t, fakeClient.Create(context.Background(), defaultBackupLocation)) // Enable CSI feature flag for SnapshotDataMovement test. - if strings.Contains(test.name, "backup with snapshot data movement") { + if test.enableCSI { features.Enable(velerov1api.CSIFeatureFlag) } @@ -1380,7 +1385,7 @@ func TestProcessBackupCompletions(t *testing.T) { assert.Nil(t, err) // Disable CSI feature to not impact other test cases. - if strings.Contains(test.name, "backup with snapshot data movement") { + if test.enableCSI { features.Disable(velerov1api.CSIFeatureFlag) }