From 21ae1cbe820457750717a6d6724e59fdb48bfb99 Mon Sep 17 00:00:00 2001 From: Tiger Kaovilai Date: Tue, 18 Feb 2025 15:45:00 -0600 Subject: [PATCH] Address https://github.com/vmware-tanzu/velero/pull/8581#pullrequestreview-2622445640 Signed-off-by: Tiger Kaovilai --- pkg/repository/udmrepo/kopialib/lib_repo.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/pkg/repository/udmrepo/kopialib/lib_repo.go b/pkg/repository/udmrepo/kopialib/lib_repo.go index 7b5016afc..7552eb6ae 100644 --- a/pkg/repository/udmrepo/kopialib/lib_repo.go +++ b/pkg/repository/udmrepo/kopialib/lib_repo.go @@ -611,18 +611,18 @@ func writeInitParameters(ctx context.Context, repoOption udmrepo.RepoOptions, lo // repoOption.StorageOptions[udmrepo.StoreOptionKeyFullMaintenanceInterval] would for example look like // configMapName.data.kopia: {"fullMaintenanceInterval": "eagerGC"} fullMaintIntervalOption := udmrepo.FullMaintenanceIntervalOptions(repoOption.StorageOptions[udmrepo.StoreOptionKeyFullMaintenanceInterval]) - if fullMaintIntervalOption == udmrepo.FastGC { - logger.Infof("Full maintenance interval change from %v to %v", p.FullCycle.Interval, udmrepo.FastGCInterval) + priorMaintInterval := p.FullCycle.Interval + switch fullMaintIntervalOption { + case udmrepo.FastGC: p.FullCycle.Interval = udmrepo.FastGCInterval - } - if fullMaintIntervalOption == udmrepo.EagerGC { - logger.Infof("Full maintenance interval change from %v to %v", p.FullCycle.Interval, udmrepo.EagerGCInterval) + case udmrepo.EagerGC: p.FullCycle.Interval = udmrepo.EagerGCInterval - } - if fullMaintIntervalOption == udmrepo.NormalGC { - logger.Infof("Full maintenance interval change from %v to %v", p.FullCycle.Interval, udmrepo.NormalGCInterval) + case udmrepo.NormalGC: p.FullCycle.Interval = udmrepo.NormalGCInterval + default: + return errors.Errorf("invalid full maintenance interval option %s", fullMaintIntervalOption) } + logger.Infof("Full maintenance interval change from %v to %v", priorMaintInterval, p.FullCycle.Interval) p.Owner = r.ClientOptions().UsernameAtHost()