From 266ea5d55ae08266ef12d58f9722083275a5af50 Mon Sep 17 00:00:00 2001 From: Daniel Jiang Date: Fri, 1 Dec 2023 13:46:31 +0800 Subject: [PATCH] Make sure the PVs skipped by CSI plugin due to settings in backup spec are tracked Signed-off-by: Daniel Jiang --- pkg/backup/item_backupper.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/backup/item_backupper.go b/pkg/backup/item_backupper.go index ef1ff79d2..4eacd314b 100644 --- a/pkg/backup/item_backupper.go +++ b/pkg/backup/item_backupper.go @@ -384,8 +384,8 @@ func (ib *itemBackupper) executeActions( // snapshot was skipped by CSI plugin ib.trackSkippedPV(obj, groupResource, csiSnapshotApproach, "skipped b/c it's not a CSI volume", log) delete(u.GetAnnotations(), skippedNoCSIPVAnnotation) - } else if actionName == csiBIAPluginName || actionName == vsphereBIAPluginName { - // the snapshot has been taken + } else if (actionName == csiBIAPluginName || actionName == vsphereBIAPluginName) && !boolptr.IsSetToFalse(ib.backupRequest.Backup.Spec.SnapshotVolumes) { + // the snapshot has been taken by the BIA plugin ib.unTrackSkippedPV(obj, groupResource, log) } mustInclude := u.GetAnnotations()[mustIncludeAdditionalItemAnnotation] == "true" || finalize