Convert manifests + BSL api client to kubebuilder (#2561)

* kubebuilder init - minimalist version

Signed-off-by: Carlisia <carlisia@vmware.com>

* Add back main.go, apparently kb needs it

Signed-off-by: Carlisia <carlisia@vmware.com>

* Tweak makefile to accomodate kubebuilder expectations

Signed-off-by: Carlisia <carlisia@vmware.com>

* Port BSL to kubebuilder api client

Signed-off-by: Carlisia <carlisia@vmware.com>

* s/cache/client bc client fetches from cache
And other naming improvements

Signed-off-by: Carlisia <carlisia@vmware.com>

* So, .GetAPIReader is how we bypass the cache
In this case, the cache hasn't started yet

Signed-off-by: Carlisia <carlisia@vmware.com>

* Oh that's what this code was for... adding back

We still need to embed the CRDs as binary data in the Velero binary to
access the generated CRDs at runtime.

Signed-off-by: Carlisia <carlisia@vmware.com>

* Tie in CRD/code generation w/ existing scripts

Signed-off-by: Carlisia <carlisia@vmware.com>

* Mostly result of running update-fmt, updated file formatting

Signed-off-by: Carlisia <carlisia@vmware.com>

* Just a copyright fix

Signed-off-by: Carlisia <carlisia@vmware.com>

* All the test fixes

Signed-off-by: Carlisia <carlisia@vmware.com>

* Add changelog + some cleanup

Signed-off-by: Carlisia <carlisia@vmware.com>

* Update backup manifest

Signed-off-by: Carlisia <carlisia@vmware.com>

* Remove unneeded auto-generated files

Signed-off-by: Carlisia <carlisia@vmware.com>

* Keep everything in the same (existing) package

Signed-off-by: Carlisia <carlisia@vmware.com>

* Fix/clean scripts, generated code, and calls

Deleting the entire `generated` directory and running `make update`
works. Modifying an api and running `make verify` works as expected.

Signed-off-by: Carlisia <carlisia@vmware.com>

* Clean up schema and client calls + code reviews

Signed-off-by: Carlisia <carlisia@vmware.com>

* Move all code gen to inside builder container

Signed-off-by: Carlisia <carlisia@vmware.com>

* Address code review

Signed-off-by: Carlisia <carlisia@vmware.com>

* Fix imports/aliases

Signed-off-by: Carlisia <carlisia@vmware.com>

* More code reviews

Signed-off-by: Carlisia <carlisia@vmware.com>

* Add waitforcachesync

Signed-off-by: Carlisia <carlisia@vmware.com>

* Have manager register ALL controllers

This will allow for proper cache management.

Signed-off-by: Carlisia <carlisia@vmware.com>

* Status subresource is now enabled; cleanup

Signed-off-by: Carlisia <carlisia@vmware.com>

* More code reviews

Signed-off-by: Carlisia <carlisia@vmware.com>

* Clean up

Signed-off-by: Carlisia <carlisia@vmware.com>

* Manager registers ALL controllers for restic too

Signed-off-by: Carlisia <carlisia@vmware.com>

* More code reviews

Signed-off-by: Carlisia <carlisia@vmware.com>

* Add deprecation warning/todo

Signed-off-by: Carlisia <carlisia@vmware.com>

* Add documentation

Signed-off-by: Carlisia <carlisia@vmware.com>

* Add helpful comments

Signed-off-by: Carlisia <carlisia@vmware.com>

* Address code review

Signed-off-by: Carlisia <carlisia@vmware.com>

* More idiomatic Runnable

Signed-off-by: Carlisia <carlisia@vmware.com>

* Clean up imports

Signed-off-by: Carlisia <carlisia@vmware.com>

hack/crd-gen/main.go

@@ -14,8 +14,8 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-// This code embeds the CRD manifests in pkg/generated/crds/manifests in
-// pkg/generated/crds/crds.go.
+// This code embeds the CRD manifests in config/crd/bases in
+// config/crd/crds/crds.go.
 
 package main
 
@@ -30,7 +30,7 @@ import (
 	"text/template"
 )
 
-// This is relative to pkg/generated/crds
+// This is relative to config/crd/crds
 const goHeaderFile = "../../../hack/boilerplate.go.txt"
 
 const tpl = `{{.GoHeader}}
@@ -96,14 +96,14 @@ func main() {
 		GoHeader: string(headerBytes),
 	}
 
-	// This is relative to pkg/generated/crds
-	manifests, err := ioutil.ReadDir("manifests")
+	// This is relative to config/crd/crds
+	manifests, err := ioutil.ReadDir("../bases")
 	if err != nil {
 		log.Fatalln(err)
 	}
 
 	for _, crd := range manifests {
-		file, err := os.Open("manifests/" + crd.Name())
+		file, err := os.Open("../bases/" + crd.Name())
 		if err != nil {
 			log.Fatalln(err)
 		}
@@ -120,7 +120,7 @@ func main() {
 		data.RawCRDs = append(data.RawCRDs, fmt.Sprintf("%q", buf.Bytes()))
 	}
 
-	t, err := template.New("crds").Parse(tpl)
+	t, err := template.New("crd").Parse(tpl)
 	if err != nil {
 		log.Fatalln(err)
 	}

hack/update-generated-crd-code.sh

@@ -44,9 +44,12 @@ ${GOPATH}/src/k8s.io/code-generator/generate-groups.sh \
   --output-base ../../.. \
   $@
 
+# Generate manifests e.g. CRD, RBAC etc.
 controller-gen \
-  crd:crdVersions=v1beta1,preserveUnknownFields=false \
-  output:dir=./pkg/generated/crds/manifests \
-  paths=./pkg/apis/velero/v1/...
+  crd:crdVersions=v1beta1,preserveUnknownFields=false,trivialVersions=true \
+  rbac:roleName=manager-role \
+  paths=./pkg/apis/velero/v1/... \
+  paths=./pkg/controller/... \
+  output:crd:artifacts:config=config/crd/bases
 
-go generate ./pkg/generated/crds
+go generate ./config/crd/crds

hack/verify-generated-crd-code.sh

@@ -19,11 +19,11 @@ HACK_DIR=$(dirname "${BASH_SOURCE}")
 ${HACK_DIR}/update-generated-crd-code.sh --verify-only
 
 # ensure no changes to generated CRDs
-if ! git diff --exit-code pkg/generated/crds/crds.go >/dev/null; then
+if ! git diff --exit-code config/crd/crds/crds.go >/dev/null; then
   # revert changes to state before running CRD generation to stay consistent
   # with code-generator `--verify-only` option which discards generated changes
-  git checkout pkg/generated/crds
+  git checkout config/crd/bases
 
   echo "CRD verification - failed! Generated CRDs are out-of-date, please run 'make update'."
   exit 1
-fi
+fi