mirror of
https://github.com/vmware-tanzu/velero.git
synced 2026-09-25 17:34:17 +00:00
test: use the Kind constant instead of the string literal (#10524)
e2e-test-kind.yaml / extract (push) Failing after 7s
Run the E2E test on kind / get-go-version (push) Failing after 9s
Run the E2E test on kind / build (push) Skipped
Run the E2E test on kind / setup-test-matrix (push) Failing after 3s
Run the E2E test on kind / run-e2e-test (push) Skipped
push.yml / extract (push) Failing after 7s
Scorecard supply-chain security / Scorecard analysis (push) Skipped
Main CI / get-go-version (push) Failing after 8s
Main CI / Build (push) Skipped
e2e-test-kind.yaml / extract (push) Failing after 7s
Run the E2E test on kind / get-go-version (push) Failing after 9s
Run the E2E test on kind / build (push) Skipped
Run the E2E test on kind / setup-test-matrix (push) Failing after 3s
Run the E2E test on kind / run-e2e-test (push) Skipped
push.yml / extract (push) Failing after 7s
Scorecard supply-chain security / Scorecard analysis (push) Skipped
Main CI / get-go-version (push) Failing after 8s
Main CI / Build (push) Skipped
* test: use the Kind constant instead of the string literal test/types.go defines `const Kind = "kind"` and most of the suite compares against it, but three sites still use the bare string. deletion.go is inconsistent with itself: the BeforeEach skip uses Kind while the one in runBackupDeletionTests uses "kind", and its skip message hardcodes the provider name where the other formats it. namespace-mapping.go dot-imports test/e2e/test rather than test, so the constant was not in scope there. Import the test package by name, as test/e2e/migration/migration.go already does alongside its framework import, and reference test.Kind. No behavioural change: the constant's value is the string being replaced. Signed-off-by: krishhna24 <krishhnatupedev@gmail.com> * Add changelog for #10524 Signed-off-by: krishhna24 <krishhnatupedev@gmail.com> --------- Signed-off-by: krishhna24 <krishhnatupedev@gmail.com>
This commit is contained in:
@@ -88,8 +88,8 @@ func runBackupDeletionTests(client TestClient, veleroCfg VeleroConfig, backupLoc
|
||||
nsCount := len(workloadNamespaceList)
|
||||
workloadNamespaces := strings.Join(workloadNamespaceList[:], ",")
|
||||
|
||||
if useVolumeSnapshots && veleroCfg.CloudProvider == "kind" {
|
||||
Skip("Volume snapshots not supported on kind")
|
||||
if useVolumeSnapshots && veleroCfg.CloudProvider == Kind {
|
||||
Skip(fmt.Sprintf("Volume snapshots not supported on %s", Kind))
|
||||
}
|
||||
oneHourTimeout, ctxCancel := context.WithTimeout(context.Background(), time.Minute*60)
|
||||
defer ctxCancel()
|
||||
|
||||
Reference in New Issue
Block a user