Upgrade to robfig/cron/v3 to support time zone specification

mirror of https://github.com/vmware-tanzu/velero.git synced 2026-08-21 06:36:06 +00:00

Breaking change (can be mitigated if needed in the future):  v1 branch accepted an optional seconds field at the beginning of the cron spec. This is non-standard and has led to a lot of confusion. The new default parser conforms to the standard as described by [the Cron wikipedia page.](https://en.wikipedia.org/wiki/Cron). It is unlikely that this affects us per https://github.com/vmware-tanzu/velero/pull/31

Other notes:
> CRON_TZ is now the recommended way to specify the timezone of a single schedule, which is sanctioned by the specification. The legacy "TZ=" prefix will continue to be supported since it is unambiguous and easy to do so.

References: https://pkg.go.dev/github.com/robfig/cron/v3#readme-upgrading-to-v3-june-2019
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

This commit is contained in:

Tiger Kaovilai

2024-07-12 00:08:42 -04:00

parent 27392d3411

commit 6c8d051269

6 changed files with 34 additions and 6 deletions

									
										pkg/controller/schedule_controller.go
									
		+1
		-1
	
												View File
												
				@@ -22,7 +22,7 @@ import (

					"time"

					"github.com/pkg/errors"

					"github.com/robfig/cron"

					cron "github.com/robfig/cron/v3"

					"github.com/sirupsen/logrus"

					apierrors "k8s.io/apimachinery/pkg/api/errors"

					metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"