From 71fadf381e08b125d02a5a5acd79355b47804b66 Mon Sep 17 00:00:00 2001 From: Andy Goldstein Date: Mon, 11 Sep 2017 13:59:04 -0400 Subject: [PATCH] Clarify Backup() param names Signed-off-by: Andy Goldstein --- pkg/backup/backup.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pkg/backup/backup.go b/pkg/backup/backup.go index 63c46d5bf..23b0a96fd 100644 --- a/pkg/backup/backup.go +++ b/pkg/backup/backup.go @@ -39,9 +39,9 @@ import ( // Backupper performs backups. type Backupper interface { - // Backup takes a backup using the specification in the api.Backup and writes backup data to the - // given writers. - Backup(backup *api.Backup, data, log io.Writer) error + // Backup takes a backup using the specification in the api.Backup and writes backup and log data + // to the given writers. + Backup(backup *api.Backup, backupFile, logFile io.Writer) error } // kubernetesBackupper implements Backupper. @@ -184,15 +184,15 @@ func (ctx *backupContext) log(msg string, args ...interface{}) { } // Backup backs up the items specified in the Backup, placing them in a gzip-compressed tar file -// written to data. The finalized api.Backup is written to metadata. -func (kb *kubernetesBackupper) Backup(backup *api.Backup, data, log io.Writer) error { - gzippedData := gzip.NewWriter(data) +// written to backupFile. The finalized api.Backup is written to metadata. +func (kb *kubernetesBackupper) Backup(backup *api.Backup, backupFile, logFile io.Writer) error { + gzippedData := gzip.NewWriter(backupFile) defer gzippedData.Close() tw := tar.NewWriter(gzippedData) defer tw.Close() - gzippedLog := gzip.NewWriter(log) + gzippedLog := gzip.NewWriter(logFile) defer gzippedLog.Close() var errs []error