Move velero server side default backup location setting logic to server startup

Signed-off-by: Ming Qiu <mqiu@vmware.com>

pkg/controller/backup_storage_location_controller.go

@@ -250,26 +250,7 @@ func (r *backupStorageLocationReconciler) ensureSingleDefaultBSL(locationList ve
 			}
 		}
 	} else if len(defaultBSLs) == 0 { // no default BSL
-		// find the BSL that matches the "velero server --default-backup-storage-location"
-		var defaultBSL *velerov1api.BackupStorageLocation
-		for i, location := range locationList.Items {
-			if location.Name == r.defaultBackupLocationInfo.StorageLocation {
-				defaultBSL = &locationList.Items[i]
-				break
-			}
-		}
-
-		// set the default BSL
-		if defaultBSL != nil {
-			defaultBSL.Spec.Default = true
-			defaultFound = true
-			if err := r.client.Update(r.ctx, defaultBSL); err != nil {
-				return defaultFound, errors.Wrapf(err, "failed to set default backup storage location %q", defaultBSL.Name)
-			}
-			r.log.Debugf("update default backup storage location %q to true", defaultBSL.Name)
-		} else {
-			defaultFound = false
-		}
+		defaultFound = false
 	} else { // only 1 default BSL
 		defaultFound = true
 	}

pkg/controller/backup_storage_location_controller_test.go

@@ -51,7 +51,7 @@ var _ = Describe("Backup Storage Location Reconciler", func() {
 			expectedPhase     velerov1api.BackupStorageLocationPhase
 		}{
 			{
-				backupLocation:    builder.ForBackupStorageLocation("ns-1", "location-1").ValidationFrequency(1 * time.Second).Result(),
+				backupLocation:    builder.ForBackupStorageLocation("ns-1", "location-1").ValidationFrequency(1 * time.Second).Default(true).Result(),
 				isValidError:      nil,
 				expectedIsDefault: true,
 				expectedPhase:     velerov1api.BackupStorageLocationPhaseAvailable,
@@ -206,7 +206,7 @@ func TestEnsureSingleDefaultBSL(t *testing.T) {
 			defaultBackupInfo: storage.DefaultBackupLocationInfo{
 				StorageLocation: "location-2",
 			},
-			expectedDefaultSet: true,
+			expectedDefaultSet: false,
 			expectedError:      nil,
 		},
 		{