Update metrics when backup failed with validation error (#6318)

Update metrics when backup failed with validation error

Fixes #6265

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>

changelogs/unreleased/6318-ywk253100

@@ -0,0 +1 @@
+Update metrics when backup failed with validation error

pkg/controller/backup_controller.go

@@ -256,8 +256,13 @@ func (b *backupReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
 	// store ref to just-updated item for creating patch
 	original = request.Backup.DeepCopy()
 
+	backupScheduleName := request.GetLabels()[velerov1api.ScheduleNameLabel]
+
 	if request.Status.Phase == velerov1api.BackupPhaseFailedValidation {
 		log.Debug("failed to validate backup status")
+		b.metrics.RegisterBackupValidationFailure(backupScheduleName)
+		b.metrics.RegisterBackupLastStatus(backupScheduleName, metrics.BackupLastStatusFailure)
+
 		return ctrl.Result{}, nil
 	}
 
@@ -271,7 +276,6 @@ func (b *backupReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
 
 	log.Debug("Running backup")
 
-	backupScheduleName := request.GetLabels()[velerov1api.ScheduleNameLabel]
 	b.metrics.RegisterBackupAttempt(backupScheduleName)
 
 	// execution & upload of backup

pkg/controller/backup_controller_test.go

@@ -214,6 +214,7 @@ func TestProcessBackupValidationFailures(t *testing.T) {
 				defaultBackupLocation: defaultBackupLocation.Name,
 				clock:                 &clock.RealClock{},
 				formatFlag:            formatFlag,
+				metrics:               metrics.NewServerMetrics(),
 			}
 
 			require.NotNil(t, test.backup)