Addressing PR feedback and adding tests

Signed-off-by: Justin Nauman <justin.r.nauman@gmail.com>
This commit is contained in:
Justin Nauman
2017-09-18 17:30:12 -05:00
parent d76ed7b49e
commit 97f8f2426f
6 changed files with 91 additions and 6 deletions

View File

@@ -39,15 +39,16 @@ func Config(kubeconfig, baseName string) (*rest.Config, error) {
clientConfig.UserAgent = buildUserAgent(
baseName,
buildinfo.Version,
buildinfo.FormattedGitSHA(),
runtime.GOOS,
runtime.GOARCH,
buildinfo.GitSHA)
)
return clientConfig, nil
}
// buildUserAgent builds a User-Agent string from given args.
func buildUserAgent(command, version, os, arch, commit string) string {
func buildUserAgent(command, version, formattedSha, os, arch string) string {
return fmt.Sprintf(
"%s/%s (%s/%s) %s", command, version, os, arch, commit)
"%s/%s (%s/%s) %s", command, version, os, arch, formattedSha)
}