From 9c1a2e884b731b1578bbbdd1f295b67cf570eb57 Mon Sep 17 00:00:00 2001 From: Nolan Brubaker Date: Fri, 10 Apr 2020 12:58:58 -0400 Subject: [PATCH] Update comments Signed-off-by: Nolan Brubaker --- pkg/controller/backup_controller.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/controller/backup_controller.go b/pkg/controller/backup_controller.go index 914793838..02d5ff52e 100644 --- a/pkg/controller/backup_controller.go +++ b/pkg/controller/backup_controller.go @@ -559,6 +559,7 @@ func (c *backupController) runBackup(backup *pkgbackup.Request) error { //TODO: Is this right? backupLog.Error(err) } + // Currently, VSCs are not being labelled in the plugin, so none will be returned here. volumeSnapshotContents, err = c.volumeSnapshotContentLister.List(selector) if err != nil { //TODO: Is this right? @@ -638,7 +639,7 @@ func persistBackup(backup *pkgbackup.Request, csiVolumeSnapshots []*snapshotv1beta1api.VolumeSnapshot, volumeSnapshotContents []*snapshotv1beta1api.VolumeSnapshotContent, ) []error { - // TODO(nrb-csi): Reduce duplication in this function + // TODO(nrb-csi): Reduce duplication in this function once uploads actually work errs := []error{} backupJSON := new(bytes.Buffer)