mirror of
https://github.com/vmware-tanzu/velero.git
synced 2026-09-13 03:24:39 +00:00
test: resolve remaining Ginkgo V2 and Gomega anti-patterns (#10440)
- Replaced Expect().Should() and Expect().ShouldNot() with .To() and .ToNot() across 12 files (Task 1). - Replaced synchronously evaluated Eventually() with Expect() in server_status_request_controller_test.go (Task 2B). - Extracted Skip() calls inside lazy callbacks into conditional checks using slices.Contains() in enable_api_group_extentions.go (Task 3). Signed-off-by: opbot_xd <awasthikrishna23052005@gmail.com>
This commit is contained in:
@@ -92,7 +92,7 @@ var _ = Describe("Server Status Request Reconciler", func() {
|
||||
Expect(apierrors.IsNotFound(err)).To(BeTrue())
|
||||
} else {
|
||||
Expect(err).ToNot(HaveOccurred())
|
||||
Eventually(instance.Status.Phase == test.expected.Status.Phase, timeout).Should(BeTrue())
|
||||
Expect(instance.Status.Phase).To(Equal(test.expected.Status.Phase))
|
||||
}
|
||||
},
|
||||
Entry("with phase=empty will be processed and phased successfully patched", request{
|
||||
|
||||
Reference in New Issue
Block a user