mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-09-25 09:24:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Honor kube client flags in install command (#1656)

Browse Source 
Flags specifying the kubeconfig or kubecontext to use weren't actually
being used by the install command.

Fixes #1651

Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
This commit is contained in:
Nolan Brubaker
2019-07-17 14:19:14 -07:00
committed by Adnan Abdulhussein
parent 3124570c7f
commit aa8c0cd471
3 changed files with 21 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/cmd/cli/install/install.go
+3 -9
View File
@@ -26,7 +26,6 @@ import (
"github.com/pkg/errors"
"github.com/spf13/cobra"
"github.com/spf13/pflag"
"k8s.io/client-go/dynamic"
api "github.com/heptio/velero/pkg/apis/velero/v1"
"github.com/heptio/velero/pkg/client"
@@ -147,7 +146,7 @@ This is useful as a starting point for more customized installations.
Run: func(c *cobra.Command, args []string) {
cmd.CheckError(o.Validate(c, args, f))
cmd.CheckError(o.Complete(args, f))
cmd.CheckError(o.Run(c))
cmd.CheckError(o.Run(c, f))
},
}
@@ -159,7 +158,7 @@ This is useful as a starting point for more customized installations.
}
// Run executes a command in the context of the provided arguments.
func (o *InstallOptions) Run(c *cobra.Command) error {
func (o *InstallOptions) Run(c *cobra.Command, f client.Factory) error {
vo, err := o.AsVeleroOptions()
if err != nil {
return err
@@ -177,12 +176,7 @@ func (o *InstallOptions) Run(c *cobra.Command) error {
if o.DryRun {
return nil
}
clientConfig, err := client.Config("", "", fmt.Sprintf("%s-%s", c.Parent().Name(), c.Name()))
if err != nil {
return err
}
dynamicClient, err := dynamic.NewForConfig(clientConfig)
dynamicClient, err := f.DynamicClient()
if err != nil {
return err
}