mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-01-07 13:55:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add features flag to plugin server

Browse Source 
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
This commit is contained in:
Nolan Brubaker
2020-03-30 20:51:46 -04:00
parent 4961040652
commit bc2717fca1
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/plugin/framework/server.go
View File

@@ -25,6 +25,7 @@ import (
"github.com/sirupsen/logrus" "github.com/sirupsen/logrus"
"github.com/spf13/pflag" "github.com/spf13/pflag"
veleroflag "github.com/vmware-tanzu/velero/pkg/cmd/util/flag"
"github.com/vmware-tanzu/velero/pkg/util/logging" "github.com/vmware-tanzu/velero/pkg/util/logging"
) )
@@ -75,6 +76,7 @@ type server struct {
log *logrus.Logger log *logrus.Logger
logLevelFlag *logging.LevelFlag logLevelFlag *logging.LevelFlag
flagSet *pflag.FlagSet flagSet *pflag.FlagSet
featureSet *veleroflag.StringArray
backupItemAction *BackupItemActionPlugin backupItemAction *BackupItemActionPlugin
volumeSnapshotter *VolumeSnapshotterPlugin volumeSnapshotter *VolumeSnapshotterPlugin
objectStore *ObjectStorePlugin objectStore *ObjectStorePlugin
@@ -84,10 +86,12 @@ type server struct {
// NewServer returns a new Server // NewServer returns a new Server
func NewServer() Server { func NewServer() Server {
log := newLogger() log := newLogger()
features := veleroflag.NewStringArray()
return &server{ return &server{
log: log, log: log,
logLevelFlag: logging.LogLevelFlag(log.Level), logLevelFlag: logging.LogLevelFlag(log.Level),
featureSet: &features,
backupItemAction: NewBackupItemActionPlugin(serverLogger(log)), backupItemAction: NewBackupItemActionPlugin(serverLogger(log)),
volumeSnapshotter: NewVolumeSnapshotterPlugin(serverLogger(log)), volumeSnapshotter: NewVolumeSnapshotterPlugin(serverLogger(log)),
objectStore: NewObjectStorePlugin(serverLogger(log)), objectStore: NewObjectStorePlugin(serverLogger(log)),
@@ -97,6 +101,7 @@ func NewServer() Server {
func (s *server) BindFlags(flags *pflag.FlagSet) Server { func (s *server) BindFlags(flags *pflag.FlagSet) Server {
flags.Var(s.logLevelFlag, "log-level", fmt.Sprintf("the level at which to log. Valid values are %s.", strings.Join(s.logLevelFlag.AllowedValues(), ", "))) flags.Var(s.logLevelFlag, "log-level", fmt.Sprintf("the level at which to log. Valid values are %s.", strings.Join(s.logLevelFlag.AllowedValues(), ", ")))
flags.Var(s.featureSet, "features", "list of feature flags for this plugin")
s.flagSet = flags s.flagSet = flags
return s return s