mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-01-07 13:55:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #7254 from learner0810/reduce-backup-deepCopy

Browse Source 
Returns directly when backup status is BackupPhaseFailedValidation No need for DeepCopy
This commit is contained in:
Xun Jiang/Bruce Jiang
2024-01-17 21:41:24 +08:00
committed by GitHub
parent f66aa9f3b3 8e4cefbb0d
commit cbe5a36a3c
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/controller/backup_controller.go
View File

@@ -252,8 +252,6 @@ func (b *backupReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
if err := kubeutil.PatchResource(original, request.Backup, b.kbClient); err != nil {
return ctrl.Result{}, errors.Wrapf(err, "error updating Backup status to %s", request.Status.Phase)
}
// store ref to just-updated item for creating patch
original = request.Backup.DeepCopy()
backupScheduleName := request.GetLabels()[velerov1api.ScheduleNameLabel]
@@ -265,6 +263,9 @@ func (b *backupReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
return ctrl.Result{}, nil
}
// store ref to just-updated item for creating patch
original = request.Backup.DeepCopy()
b.backupTracker.Add(request.Namespace, request.Name)
defer func() {
switch request.Status.Phase {