From e62afa8b6145a8fa2e442689c2f553b519b94b9f Mon Sep 17 00:00:00 2001 From: Shubheksha Jalan Date: Tue, 25 Sep 2018 01:35:05 +0530 Subject: [PATCH] ignore spec.ports not being there for services of type ExternalName Signed-off-by: Shubheksha Jalan --- pkg/restore/service_action.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/pkg/restore/service_action.go b/pkg/restore/service_action.go index 943ff79cc..f92cda978 100644 --- a/pkg/restore/service_action.go +++ b/pkg/restore/service_action.go @@ -59,18 +59,14 @@ func (a *serviceAction) Execute(obj runtime.Unstructured, restore *api.Restore) delete(spec, "clusterIP") } - // Since spec.ports is an optional key, we can ignore 'not found' errors. Also assuming it was a string already. - if val, _ := collections.GetString(spec, "spec.ports"); val != "None" { - delete(spec, "spec.ports") - } - preservedPorts, err := getPreservedPorts(obj) if err != nil { return nil, nil, err } ports, err := collections.GetSlice(obj.UnstructuredContent(), "spec.ports") - if err != nil { + serviceType, _ := collections.GetString(spec, "type") + if err != nil && serviceType != "ExternalName" { return nil, nil, err }