From ea6c8ca127644fcbad831b02bd7df103906af540 Mon Sep 17 00:00:00 2001 From: Shubham Pampattiwar Date: Wed, 13 Dec 2023 08:46:21 -0800 Subject: [PATCH] fix finalizer typo in logs (#7204) Signed-off-by: Shubham Pampattiwar --- pkg/controller/data_download_controller.go | 4 ++-- pkg/controller/data_upload_controller.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/controller/data_download_controller.go b/pkg/controller/data_download_controller.go index 951f994e5..e6e9acf9b 100644 --- a/pkg/controller/data_download_controller.go +++ b/pkg/controller/data_download_controller.go @@ -131,7 +131,7 @@ func (r *DataDownloadReconciler) Reconcile(ctx context.Context, req ctrl.Request log.Errorf("failed to add finalizer with error %s for %s/%s", err.Error(), dd.Namespace, dd.Name) return ctrl.Result{}, err } else if !succeeded { - log.Warnf("failed to add finilizer for %s/%s and will requeue later", dd.Namespace, dd.Name) + log.Warnf("failed to add finalizer for %s/%s and will requeue later", dd.Namespace, dd.Name) return ctrl.Result{Requeue: true}, nil } } @@ -305,7 +305,7 @@ func (r *DataDownloadReconciler) Reconcile(ctx context.Context, req ctrl.Request return ctrl.Result{}, nil } else { - // put the finilizer remove action here for all cr will goes to the final status, we could check finalizer and do remove action in final status + // put the finalizer remove action here for all cr will goes to the final status, we could check finalizer and do remove action in final status // instead of intermediate state // remove finalizer no matter whether the cr is being deleted or not for it is no longer needed when internal resources are all cleaned up // also in final status cr won't block the direct delete of the velero namespace diff --git a/pkg/controller/data_upload_controller.go b/pkg/controller/data_upload_controller.go index 2e971b682..b7c18e51d 100644 --- a/pkg/controller/data_upload_controller.go +++ b/pkg/controller/data_upload_controller.go @@ -141,7 +141,7 @@ func (r *DataUploadReconciler) Reconcile(ctx context.Context, req ctrl.Request) log.Errorf("failed to add finalizer with error %s for %s/%s", err.Error(), du.Namespace, du.Name) return ctrl.Result{}, err } else if !succeeded { - log.Warnf("failed to add finilizer for %s/%s and will requeue later", du.Namespace, du.Name) + log.Warnf("failed to add finalizer for %s/%s and will requeue later", du.Namespace, du.Name) return ctrl.Result{Requeue: true}, nil } } @@ -311,7 +311,7 @@ func (r *DataUploadReconciler) Reconcile(ctx context.Context, req ctrl.Request) } return ctrl.Result{}, nil } else { - // put the finilizer remove action here for all cr will goes to the final status, we could check finalizer and do remove action in final status + // put the finalizer remove action here for all cr will goes to the final status, we could check finalizer and do remove action in final status // instead of intermediate state. // remove finalizer no matter whether the cr is being deleted or not for it is no longer needed when internal resources are all cleaned up // also in final status cr won't block the direct delete of the velero namespace