From ee89d7ff38cb0f17a8583ad5490abc4820f2dce0 Mon Sep 17 00:00:00 2001 From: KrishhnaT Date: Thu, 8 Oct 2026 01:58:12 +0530 Subject: [PATCH] Fix the MinIO image cache key in the kind e2e workflow (#10631) * Fix the MinIO image cache key in the kind e2e workflow The build job restores the MinIO image with minio-bitnami-${{ env.BITNAMI_CONTAINERS_COMMIT }} and the e2e jobs look for the same key, but the save step writes minio-bitnami-${{ steps.minio-version.outputs.dockerfile_sha }}. No step has that id, so the expression is empty and the image is saved under a key nothing ever reads. Upstream only works because an entry under the right key is still in the cache and kept alive by use; caches unused for seven days are evicted, so a quiet week would leave every e2e job unable to load the image. A fork has no such entry, so all of them fail at once: Loading MinIO image... ./minio-image.tar: No such file or directory Save under the key the restores ask for. Signed-off-by: krishhna24 * Add changelog for #10631 Signed-off-by: krishhna24 --------- Signed-off-by: krishhna24 --- .github/workflows/e2e-test-kind.yaml | 2 +- changelogs/unreleased/10631-krishhna24 | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 changelogs/unreleased/10631-krishhna24 diff --git a/.github/workflows/e2e-test-kind.yaml b/.github/workflows/e2e-test-kind.yaml index 889605b08..5665ee620 100644 --- a/.github/workflows/e2e-test-kind.yaml +++ b/.github/workflows/e2e-test-kind.yaml @@ -105,7 +105,7 @@ jobs: uses: actions/cache/save@v6 with: path: ./minio-image.tar - key: minio-bitnami-${{ steps.minio-version.outputs.dockerfile_sha }} + key: minio-bitnami-${{ env.BITNAMI_CONTAINERS_COMMIT }} # Create json of k8s versions to test # from guide: https://stackoverflow.com/a/65094398/4590470 setup-test-matrix: diff --git a/changelogs/unreleased/10631-krishhna24 b/changelogs/unreleased/10631-krishhna24 new file mode 100644 index 000000000..60d9d1597 --- /dev/null +++ b/changelogs/unreleased/10631-krishhna24 @@ -0,0 +1 @@ +Fix the MinIO image cache key in the kind e2e workflow so the cached image is found