mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-09-13 03:24:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Check both daemonsets before returning non-NotFound lookup error in IsReady

Browse Source 
Co-authored-by: kaovilai <11228024+kaovilai@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-08-25 18:19:55 +00:00
committed by GitHub
co-authored by kaovilai
parent 41687279a8
commit ef5375e3e3
2 changed files with 59 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/nodeagent/node_agent_test.go
+46
View File
@@ -275,6 +275,52 @@ func TestIsReady(t *testing.T) {
},
expectErr: "failed to get windows node-agent daemonset: fake-get-error",
},
{
name: "linux daemonset get error but windows ready",
namespace: "fake-ns",
kubeClientObj: []runtime.Object{
dsWindowsReady,
},
interceptor: &interceptor.Funcs{
Get: func(ctx context.Context, c ctrlclient.WithWatch, key ctrlclient.ObjectKey, obj ctrlclient.Object, opts ...ctrlclient.GetOption) error {
if key.Name == "node-agent" {
return errors.New("fake-get-error")
}
return c.Get(ctx, key, obj, opts...)
},
},
},
{
name: "windows daemonset get error but linux ready",
namespace: "fake-ns",
kubeClientObj: []runtime.Object{
dsLinuxReady,
},
interceptor: &interceptor.Funcs{
Get: func(ctx context.Context, c ctrlclient.WithWatch, key ctrlclient.ObjectKey, obj ctrlclient.Object, opts ...ctrlclient.GetOption) error {
if key.Name == "node-agent-windows" {
return errors.New("fake-get-error")
}
return c.Get(ctx, key, obj, opts...)
},
},
},
{
name: "linux daemonset get error and windows not ready",
namespace: "fake-ns",
kubeClientObj: []runtime.Object{
dsWindowsNotReady,
},
interceptor: &interceptor.Funcs{
Get: func(ctx context.Context, c ctrlclient.WithWatch, key ctrlclient.ObjectKey, obj ctrlclient.Object, opts ...ctrlclient.GetOption) error {
if key.Name == "node-agent" {
return errors.New("fake-get-error")
}
return c.Get(ctx, key, obj, opts...)
},
},
expectErr: "failed to get linux node-agent daemonset: fake-get-error",
},
{
name: "linux ds exist but no ready pods",
namespace: "fake-ns",