From efe1279d49b945b437f1ed598a4eaef798c8816d Mon Sep 17 00:00:00 2001
From: samay43 <samayrbhat43@gmail.com>
Date: Fri, 14 Aug 2026 10:37:57 +0530
Subject: [PATCH] validate schedule-derived backup names don't exceed length
 limit

Signed-off-by: samay43 <samayrbhat43@gmail.com>
---
 pkg/cmd/cli/backup/create.go      | 11 +++++++++++
 pkg/cmd/cli/backup/create_test.go | 14 ++++++++++++++
 2 files changed, 25 insertions(+)

diff --git a/pkg/cmd/cli/backup/create.go b/pkg/cmd/cli/backup/create.go
index 7fe6b0e64..a8d988d72 100644
--- a/pkg/cmd/cli/backup/create.go
+++ b/pkg/cmd/cli/backup/create.go
@@ -216,6 +216,17 @@ func (o *CreateOptions) Validate(c *cobra.Command, args []string, f client.Facto
 			return fmt.Errorf("invalid backup name %q: %s", o.Name, strings.Join(errs, "; "))
 		}
 	}
+	// When a backup name will be generated from the schedule (i.e. FromSchedule
+	// is set and no explicit name was given), ensure the schedule name leaves
+	// enough room for the generated timestamp suffix ("-" + 14-digit timestamp,
+	// 15 characters total) within the DNS1123 subdomain length limit.
+	if o.FromSchedule != "" && o.Name == "" {
+		const timestampSuffixLen = 15 // "-" + "20060102150405"
+		maxScheduleNameLen := validation.DNS1123SubdomainMaxLength - timestampSuffixLen
+		if len(o.FromSchedule) > maxScheduleNameLen {
+			return fmt.Errorf("schedule name %q is too long: must be %d characters or fewer to leave room for the generated timestamp suffix", o.FromSchedule, maxScheduleNameLen)
+		}
+	}
 	errs := collections.ValidateNamespaceIncludesExcludes(o.IncludeNamespaces, o.ExcludeNamespaces)
 	if len(errs) > 0 {
 		return kubeerrs.NewAggregate(errs)
diff --git a/pkg/cmd/cli/backup/create_test.go b/pkg/cmd/cli/backup/create_test.go
index 5f9b9aac0..528e76943 100644
--- a/pkg/cmd/cli/backup/create_test.go
+++ b/pkg/cmd/cli/backup/create_test.go
@@ -538,6 +538,20 @@ func TestCreateOptions_Validate(t *testing.T) {
 			args:         []string{},
 			expectError:  false,
 		},
+		{
+			name:         "should pass when schedule name leaves room for timestamp suffix",
+			optName:      "",
+			fromSchedule: strings.Repeat("a", 238), // exactly at the 238-char limit
+			args:         []string{},
+			expectError:  false,
+		},
+		{
+			name:         "should error when schedule name is too long to leave room for timestamp suffix",
+			optName:      "",
+			fromSchedule: strings.Repeat("a", 239), // one over the 238-char limit
+			args:         []string{},
+			expectError:  true,
+		},
 	}
 
 	for _, tc := range testCases {