Fix schedule reconciler to compare SkipImmediately and LastSkipped by value (#10490) · f40112aedf - velero

mirror of https://github.com/vmware-tanzu/velero.git synced 2026-09-25 01:14:18 +00:00

Fix schedule reconciler to compare SkipImmediately and LastSkipped by value (#10490)

Run the E2E test on kind / setup-test-matrix (push) Failing after 3s

Details

e2e-test-kind.yaml / extract (push) Failing after 6s

Details

Run the E2E test on kind / get-go-version (push) Failing after 7s

Details

Run the E2E test on kind / build (push) Skipped

Details

Run the E2E test on kind / run-e2e-test (push) Skipped

Details

push.yml / extract (push) Failing after 6s

Details

Scorecard supply-chain security / Scorecard analysis (push) Skipped

Details

Main CI / get-go-version (push) Failing after 7s

Details

Main CI / Build (push) Skipped

Details

* Fix schedule reconciler to compare SkipImmediately and LastSkipped by value

The reconciler compared spec.skipImmediately (*bool) and
status.lastSkipped (*metav1.Time) between the live object and its
DeepCopy by pointer, so both checks always reported a change once the
fields were set, and every reconcile issued a redundant Patch. Compare
by value instead (ptr.Equal / equality.Semantic.DeepEqual) and add a
regression test pinning that the skip-once flip persists with exactly
one patch, later reconciles of persisted state patch zero times, and
an explicit false is a no-op.

Signed-off-by: HeonJe LEE <lhjnano@gmail.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: lyndon-li <98304688+Lyndon-Li@users.noreply.github.com>

---------

Signed-off-by: HeonJe LEE <lhjnano@gmail.com>
Signed-off-by: lyndon-li <98304688+Lyndon-Li@users.noreply.github.com>
Co-authored-by: lyndon-li <98304688+Lyndon-Li@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

This commit is contained in: