From f5982b4278c7932ccec88598c9e369fac55bb818 Mon Sep 17 00:00:00 2001 From: Xun Jiang Date: Fri, 18 Sep 2026 17:09:28 +0800 Subject: [PATCH] Add test case for skipped volume with empty PV name but with PVC info Co-authored-by: Cursor Signed-off-by: Xun Jiang --- internal/volume/volumes_information_test.go | 26 ++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/internal/volume/volumes_information_test.go b/internal/volume/volumes_information_test.go index fc761a50a..0c5c41bb7 100644 --- a/internal/volume/volumes_information_test.go +++ b/internal/volume/volumes_information_test.go @@ -48,9 +48,27 @@ func TestGenerateVolumeInfoForSkippedVolume(t *testing.T) { tests := []struct { name string skippedVolumeName string + skippedPVCName string + skippedPVCNamespace string pvMap map[string]pvcPvInfo expectedVolumeInfos []*BackupVolumeInfo }{ + { + name: "Skipped volume with empty PV name but with PVC info", + skippedVolumeName: "", + skippedPVCName: "testPVC", + skippedPVCNamespace: "velero", + pvMap: map[string]pvcPvInfo{}, + expectedVolumeInfos: []*BackupVolumeInfo{ + { + PVName: "", + PVCName: "testPVC", + PVCNamespace: "velero", + Skipped: true, + SkippedReason: "CSI: skipped for PodVolumeBackup", + }, + }, + }, { name: "Cannot find info for PV", skippedVolumeName: "testPV", @@ -131,11 +149,13 @@ func TestGenerateVolumeInfoForSkippedVolume(t *testing.T) { volumesInfo := BackupVolumesInformation{} volumesInfo.Init() - if tc.skippedVolumeName != "" { + if tc.skippedVolumeName != "" || tc.skippedPVCName != "" { volumesInfo.SkippedVolumes = []SkippedVolume{ { - PVName: tc.skippedVolumeName, - Reasons: "CSI: skipped for PodVolumeBackup", + PVName: tc.skippedVolumeName, + PVCName: tc.skippedPVCName, + PVCNamespace: tc.skippedPVCNamespace, + Reasons: "CSI: skipped for PodVolumeBackup", }, } }