mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-01-07 13:55:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,691 Commits 40 Branches 174 Tags
copilot/fix-9242
Commit Graph

44 Commits

Author SHA1 Message Date
weeix
80da461458 clarify VolumeSnapshotClass error for mismatched driver/provisioner 
Signed-off-by: weeix <weeix@users.noreply.github.com>
 2025-09-02 18:31:13 -05:00
Xun Jiang
c84aab7f6f Remove the WaitUntilVSCHandleIsReady from vs BIA. 
Becasue the pvc BIA already run WaitUntilVSCHandleIsReady,
no need to do the same work in vs BIA.

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-07-31 15:35:05 +08:00
Xun Jiang
a61a073aea Avoid checking the VS and VSC status in the backup finalizing phase. 
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-07-24 13:28:05 +08:00
Lyndon-Li
34f8b73507 bump up kopia to v0.21.1 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2025-07-22 15:56:04 +08:00
Shubham Pampattiwar
a73a150d98 Accommodate VGS workflows in PVC CSI plugin 
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

Add changelog file

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

make update

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

lint fix

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

add unit tests for getVSForPVC func

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

Use v1beta1 instead of v1 v1alpha1

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

go mod tidy

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

update updateVGSCreatedVS func to use retry on conflict

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

make update minor fix

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

fix ut assert

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

Address PR feedback

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

minor updates

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

remove unsused func and add todo for dep upgrades

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
 2025-07-21 11:36:40 -07:00
Matthieu MOREL
07ea14962c fix require-error rule from testifylint 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-06-23 15:39:54 +00:00
Xun Jiang
1b7175394a Skip VS and VSC not created by backup. 
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-06-07 10:51:05 +08:00
Matthieu MOREL
c6a420bd3a chore: define common aliases for k8s packages (#8672)
Some checks failed
Run the E2E test on kind / build (push) Failing after 6m48s
Details
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Details
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Details
Main CI / Build (push) Failing after 35s
Details
Close stale issues and PRs / stale (push) Successful in 8s
Details
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m11s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 47s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 49s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 43s
Details 
* lchore: define common alias for k8s packages

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-04-22 06:14:47 -04:00
hu-keyu
5160f96c2e issue8294: inherit k8s default volumeSnapshotClass (#8721)
Some checks failed
Run the E2E test on kind / build (push) Failing after 7m33s
Details
Run the E2E test on kind / setup-test-matrix (push) Successful in 2s
Details
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Details
Main CI / Build (push) Failing after 38s
Details 
* inherit k8s default volumeSnapshotClass

Signed-off-by: hu-keyu <hzldd999@gmail.com>

* add doc change for issue8294

Signed-off-by: hu-keyu <hzldd999@gmail.com>

---------

Signed-off-by: hu-keyu <hzldd999@gmail.com>
 2025-04-07 12:21:13 +05:30
Xun Jiang
6b7dd12bf7 Modify VS and VSC restore actions. 
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-02-25 10:44:45 +08:00
Xun Jiang
eb77151f48 Delete VSC after backup completes. 
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-02-19 14:36:59 +08:00
Matthieu MOREL
ae5e94e822 chore: enable increment-decrement from revive 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-02-07 20:58:39 +01:00
Daniel Jiang
1c372893ec Clean up leaked CSI snapshot for incomplete backup 
This commit makes sure when a backup is deleted the controller will
delete the CSI snapshot even when the bakckup tarball is not uploaded.

fixes #8160

Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com>
 2025-01-22 17:17:41 +08:00
Matthieu MOREL
29a77958d5 fix: dupword on tests 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-01-10 11:44:06 +01:00
Wenkai Yin(尹文开)
0224d99889 Merge pull request #8482 from Lyndon-Li/data-mover-exposer-diagnostic
Some checks failed
Run the E2E test on kind / build (push) Failing after 6m17s
Details
Run the E2E test on kind / setup-test-matrix (push) Successful in 5s
Details
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Details
Main CI / Build (push) Failing after 1m3s
Details
Close stale issues and PRs / stale (push) Has started running
Details
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Has started running
Details
Trivy Nightly Scan / Trivy nightly scan (velero-restore-helper, main) (push) Has started running
Details 
Data mover exposer diagnostic
 2024-12-13 14:28:37 +08:00
Lyndon-Li
8b545532e2 issue 8267: add informative logs when expose error 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-12-12 11:19:26 +08:00
Lyndon-Li
b607259563 add diagnostic for data mover exposer 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-12-04 14:49:58 +08:00
Lyndon-Li
e4e9b18b37 add diagnostic for data mover exposer 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-12-04 10:28:50 +08:00
Wenkai Yin(尹文开)
23ca089d40 Use '"' rather than '`' in the log to avoid unexpected new line 
Use '"' rather than '`' in the log to avoid unexpected new line

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
 2024-10-09 14:44:13 +08:00
Matthieu MOREL
35c90f1672 testifylint: enable error-nil rule (#7670) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-07-16 12:23:16 -04:00
Xun Jiang
d3cc42d577 Change the timeout handling code due to third-party package change 
The wait error changed from `timed out waiting for the condition`
to `context deadline exceeded`.

Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
 2024-04-13 23:27:02 +08:00
Xun Jiang
30995bcbd2 Add more UT for the CSI plugins. 
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
 2024-04-13 23:22:43 +08:00
Lyndon-Li
dcf760d5f1 issue 7648:avoid snapshot leak on expose failure 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-04-12 10:41:39 +08:00
Lyndon-Li
61061d5c83 issue 7648: merge main 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-04-12 10:18:02 +08:00
Lyndon-Li
bf03938dd2 issue 7648: don't leak snapshot on failure 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-04-11 19:23:57 +08:00
Xun Jiang/Bruce Jiang
8df4e6aded Merge branch 'main' into merge_csi 
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
 2024-04-10 18:54:16 +08:00
Xun Jiang
31e140919a Merge CSI plugin code. 
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
 2024-04-10 14:53:29 +08:00
Matthieu MOREL
a9085033b2 build(deps): bump json-patch to v5.8.0 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-03-29 14:08:33 +00:00
Matthieu MOREL
ef04ef6361 golangci-lint: use exclude-rules instead of skip-files and skip-dirs 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-03-27 20:17:34 +00:00
Wenkai Yin(尹文开)
8752c3a820 Bump up the versions of severel Kubernetes-related libs 
Bump up the versions of severel Kubernetes-related libs

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
 2024-03-05 13:09:38 +08:00
Lyndon-Li
067984b13c Issue 7068: add a finalizer to protect retained VSC 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-11-15 16:04:07 +08:00
Lyndon-Li
cb651d0436 issue 7068: add a finalizer to protect retained VSC 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-11-14 10:18:07 +08:00
Xun Jiang
908e2c63ba Check whether the action is a CSI action and whether CSI feature is 
enabled, before executing the action.

The DeleteItemAction is not checked, because the DIA doesn't have a
method to get the action's plugin name.
This should be OK, because the CSI will check whether the VS and VSC
have a backup name annotation. If the VS and VSC is not handled by
the CSI plugin, then they don't have the annotation.

Signed-off-by: Xun Jiang <jxun@vmware.com>
 2023-10-24 16:54:38 +08:00
Lyndon-Li
53489b10ad issue 6786:always delete VSC regardless of the deletion policy 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-09-15 12:10:20 +08:00
Lyndon-Li
b90c5bba3d continue wait on csi snapshot error 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-08-10 11:34:26 +08:00
Lyndon-Li
22c88ba330 data mover fail earlier for snapshot creation error 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-08-08 12:05:56 +08:00
Lyndon-Li
217b1dd066 add UT for pkg/util 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-06-08 14:00:58 +08:00
Xun Jiang/Bruce Jiang
4227a824cd Merge pull request #6327 from blackpiglet/6099_fix 
Remove Wait VolumeSnapshot to ReadyToUse logic.
 2023-06-07 14:56:26 +08:00
Xun Jiang
7491ab1ec5 Remove Wait VolumeSnapshot to ReadyToUse logic. 
Due to the logic moving to plugin, and the plugin cannot read the
Velero server's resourceTimeout setting, add the resourceTimeout
in the backup annotation to pass to plugin.
Remove VolumeSnapshotContent reset code from Velero server.

Signed-off-by: Xun Jiang <jxun@vmware.com>
 2023-06-02 14:43:43 +08:00
Lyndon-Li
25624d3030 data mover backup expose 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-06-02 11:51:36 +08:00
Xun Jiang/Bruce Jiang
9cb46deb73 Add CSI VolumeSnapshot client back. (#5449) 
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
 2022-10-18 14:58:03 +08:00
Xun Jiang/Bruce Jiang
ce247a3d90 Remove snapshot related lister, informer and client from backup controller. (#5299) 
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
 2022-09-23 15:44:39 +08:00
Daniel Jiang
89e90d9be4 Delete orphan CSI snapshots in backup sync controller 
This commit makes backup sync controller delete the volumesnapshot and
volumesnapshotcontent created by the backup which is cleaned up as orphan

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2022-05-05 10:54:34 +08:00
Daniel Jiang
4f9e445142 Make the vsc created by backup sync controller deletable 
Fixes #4760

This commit make changes in 2 parts:
1) When a volumesnapshotcontent is persisted during backup, velero will reset its
   `Source` field to remove the VolumeHandle, so that the
   csi-snapshotter will not try to call `CreateSnapshot` when its synced
   to another cluster with a backup.
2) Make sure the referenced volumesnapshotclasses are persisted and
   synced with the backup, so that when the volumesnapshotcontent is
   deleted the storage snapshot is also removed.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2022-04-19 15:06:59 +08:00