Nolan Emirot
76197d7892
fix: lint permission issue ( #9740 )
...
Run the E2E test on kind / get-go-version (push) Failing after 49s
Run the E2E test on kind / build (push) Has been skipped
Run the E2E test on kind / setup-test-matrix (push) Successful in 4s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / get-go-version (push) Successful in 11s
Main CI / Build (push) Failing after 31s
Close stale issues and PRs / stale (push) Successful in 11s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m30s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 1m21s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 1m17s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 1m19s
* fix: lint permission issue
Signed-off-by: emirot <emirot.nolan@gmail.com >
* fix: lint permission issue
Signed-off-by: emirot <emirot.nolan@gmail.com >
* Set permissions to the actions
This commit update the actions "Auto Assign Author", "Auto Label PRs",
and "Auto Request Review"
Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com >
Signed-off-by: emirot <emirot.nolan@gmail.com >
* Fix wildcard expansion when includes is empty and excludes has wildcards (#9684 )
* Fix wildcard expansion when includes is empty and excludes has wildcards
When a Backup CR is applied via kubectl with empty includedNamespaces
and a wildcard in excludedNamespaces, ShouldExpandWildcards triggers
expansion. The empty includes expands to nil, but wildcardExpanded is
set to true, causing ShouldInclude to return false for all namespaces.
Populate expanded includes with all active namespaces when the original
includes was empty (meaning "include all") so that the wildcardExpanded
check does not falsely reject everything.
Signed-off-by: Joseph <jvaikath@redhat.com >
* Changelog
Signed-off-by: Joseph <jvaikath@redhat.com >
* Normalize empty includes to * instead of active namespaces list
This ensures consistent behavior between CLI and kubectl-apply paths
for Namespace CR inclusion when excludes contain wildcards.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
Signed-off-by: Joseph <jvaikath@redhat.com >
* Move empty includes normalization to backup controller
Instead of normalizing empty IncludedNamespaces to ["*"] in the
collections layer's ExpandIncludesExcludes, do it earlier in
prepareBackupRequest. This ensures the spec is correct before any
downstream processing.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
Signed-off-by: Joseph <jvaikath@redhat.com >
* Update TestProcessBackupCompletions for wildcard normalization
Add IncludedNamespaces: []string{"*"} to all expected BackupSpec
structs, reflecting the new prepareBackupRequest normalization.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
Signed-off-by: Joseph <jvaikath@redhat.com >
* Add checks around empty includenamespaces
Signed-off-by: Joseph <jvaikath@redhat.com >
* gofmt
Signed-off-by: Joseph <jvaikath@redhat.com >
---------
Signed-off-by: Joseph <jvaikath@redhat.com >
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
Signed-off-by: emirot <emirot.nolan@gmail.com >
* update hashicorp/go-hclog and go-plugin to current version (#9613 )
Signed-off-by: Peter Woodman <peter@shortbus.org >
Signed-off-by: emirot <emirot.nolan@gmail.com >
* fix: honor -stderrthreshold when -logtostderr is true (default)
klog v2 defaults -logtostderr to true, which silently ignores the
-stderrthreshold flag — all log levels are unconditionally sent to
stderr. This makes it impossible for log-aggregation systems to filter
by severity.
Bump klog to v2.140.0 and opt into the fixed behavior by setting
legacy_stderr_threshold_behavior=false and stderrthreshold=INFO (which
preserves current output while letting users override via CLI flags).
Ref: kubernetes/klog#212 , kubernetes/klog#432
Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com >
Signed-off-by: emirot <emirot.nolan@gmail.com >
* fix: add changelog and nolint explanation for CI
Add missing changelog entry for PR 9654 (fixes Changelog Check).
Add explanation to //nolint:errcheck directives (fixes nolintlint).
Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com >
Signed-off-by: emirot <emirot.nolan@gmail.com >
* Remove Restic code path from PodVolumeRestore.
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
Signed-off-by: emirot <emirot.nolan@gmail.com >
* Bump go.opentelemetry.io/otel from 1.40.0 to 1.41.0
Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go ) from 1.40.0 to 1.41.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases )
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md )
- [Commits](https://github.com/open-telemetry/opentelemetry-go/compare/v1.40.0...v1.41.0 )
---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel
dependency-version: 1.41.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: emirot <emirot.nolan@gmail.com >
* Fix error in auto-request-review action
Per action.yml of the action, the token is required.
e89da1a8cd/action.yml (L8)
Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com >
Signed-off-by: emirot <emirot.nolan@gmail.com >
* fix go-releaser upload error
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
Signed-off-by: emirot <emirot.nolan@gmail.com >
* add concurrency limit to go-releaser
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
Signed-off-by: emirot <emirot.nolan@gmail.com >
* Bump go.opentelemetry.io/otel/sdk from 1.40.0 to 1.43.0 (#9692 )
Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go ) from 1.40.0 to 1.43.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases )
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md )
- [Commits](https://github.com/open-telemetry/opentelemetry-go/compare/v1.40.0...v1.43.0 )
---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel/sdk
dependency-version: 1.43.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: emirot <emirot.nolan@gmail.com >
* fix(lint): fix lint local
Signed-off-by: emirot <emirot.nolan@gmail.com >
* Apply suggestion from @blackpiglet
https://github.com/velero-io/velero/pull/9740/changes#r3151366281
Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com >
---------
Signed-off-by: emirot <emirot.nolan@gmail.com >
Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com >
Signed-off-by: Joseph <jvaikath@redhat.com >
Signed-off-by: Peter Woodman <peter@shortbus.org >
Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com >
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
Signed-off-by: dependabot[bot] <support@github.com >
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com >
Co-authored-by: Daniel Jiang <daniel.jiang@broadcom.com >
Co-authored-by: Joseph Antony Vaikath <jvaikath@redhat.com >
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
Co-authored-by: peter woodman <peter@shortbus.org >
Co-authored-by: Pierluigi Lenoci <pierluigilenoci@gmail.com >
Co-authored-by: Xun Jiang <xun.jiang@broadcom.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lyndon-Li <lyonghui@vmware.com >
Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com >
2026-04-28 03:11:49 -04:00
Xun Jiang
39db9f9c1e
Remove Restic build from Dockerfile, Makefile and Tiltfile.
...
Delete Restic-build-related scripts.
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
2026-04-15 23:46:31 +08:00
Xun Jiang
f2133c7d22
The backup and restore data mover node selection.
...
Update Makefile to let the `make serve-docs` work again.
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
2025-07-01 16:26:12 +08:00
Xun Jiang
d3e8e9a9c2
Remove pushing images to GCR.
...
Remove dependency with GCR.
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
2025-05-08 20:42:21 +08:00
Pandurang Khandeparker
8934b2cb17
Add s390x binary support ( #7505 )
...
Run the E2E test on kind / build (push) Failing after 6m30s
Run the E2E test on kind / setup-test-matrix (push) Successful in 2s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 1m40s
Signed-off-by: Pandurang Alias Aradhya Khandeparker <PANDURANG.KHANDEPARKER@ibm.com >
Signed-off-by: Rishi Misra <rishi@ca.ibm.com >
Co-authored-by: Rishi Misra <rishi@ca.ibm.com >
2025-04-04 09:39:01 -04:00
Wenkai Yin(尹文开)
bca5e55620
Update Makefile to support pushing images to an insecure registry
...
Update Makefile to support pushing images to an insecure registry
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2025-02-19 11:22:47 +08:00
Wenkai Yin(尹文开)
eb5230e12f
Merge restore helper image into Velero server image
...
Merge restore helper image into Velero server image
Fixes #8484
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2025-01-03 14:12:23 +08:00
Lyndon-Li
ed9af610e5
support specified buildx instance
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-12-06 14:48:47 +08:00
Lyndon-Li
baf74d67a7
build hybrid image
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-12-04 10:29:34 +08:00
Lyndon-Li
dd18cb49e6
Merge branch 'main' into build-hybrid-image
2024-12-03 13:20:37 +08:00
Lyndon-Li
18b3d96e64
build hybrid image
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-11-26 17:10:14 +08:00
lyndon-li
40a95aab32
Merge pull request #8455 from kaovilai/accessible-singleplat-images
...
Run the E2E test on kind / run-e2e-test (push) Blocked by required conditions
Run the E2E test on kind / build (push) Failing after 11m56s
Main CI / Build (push) Failing after 5m29s
Run the E2E test on kind / setup-test-matrix (push) Failing after 11m32s
Close stale issues and PRs / stale (push) Successful in 2m18s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 5m17s
Trivy Nightly Scan / Trivy nightly scan (velero-restore-helper, main) (push) Failing after 1m57s
Make single platform built image locally accessible.
2024-11-26 16:49:32 +08:00
Tiger Kaovilai
483f0978e8
Make single platform built image accessible.
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2024-11-25 12:37:55 -05:00
Tiger Kaovilai
3517487611
Makefile: new-changelog handles () in pr title.
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2024-11-24 04:19:40 -05:00
Lyndon-Li
51490af667
Merge branch 'main' into build-hybrid-image
2024-11-20 13:44:04 +08:00
Lyndon-Li
cc47be933d
Revert "Upload Velero build package saved from build image to Google cloud storage"
...
This reverts commit 0b6df61eca .
2024-11-19 19:15:41 +08:00
Lyndon-Li
7cc0c99a08
Revert "Rename secret for Google cloud storage"
...
This reverts commit 4ab2712f6b .
2024-11-19 19:05:02 +08:00
Lyndon-Li
de7231cf86
Revert "Save vvelero image tarball only for velero namespace in docker registry ( #5581 )"
...
This reverts commit 1ea1d4df67 .
2024-11-19 17:23:16 +08:00
Lyndon-Li
b92605f5fc
build hybrid image
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-11-19 16:45:34 +08:00
Shubham Pampattiwar
7a51e0dad6
Merge pull request #8252 from kaovilai/mkcontainer-multiplat
...
Allow multi-arch manifest-list from `make container`
2024-11-14 10:17:55 -08:00
Daniel Jiang
10260bd34c
Merge pull request #8056 from kaovilai/makelocalnodocker
...
Allow `make local` to work without `docker` in path
2024-10-09 08:34:09 +08:00
Tiger Kaovilai
3f4a1c295a
Makefile: Add BUILDX_PUSH var
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2024-10-01 16:16:47 -04:00
Tiger Kaovilai
a4416874cf
Allow multi-arch manifest-list from make container
...
by changing output type to image.
Then you can execute command like so to create a multi-arch image
```
BUILDX_PLATFORMS=linux/amd64,linux/arm64 BUILDX_OUTPUT_TYPE=image make container
```
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2024-09-27 10:29:08 -04:00
Tiger Kaovilai
0b447771f1
Add new-changelog to Makefile
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2024-08-19 23:33:10 -04:00
Tiger Kaovilai
d6f89e2d07
Allow make local to work without docker in path
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2024-07-29 00:08:42 -04:00
Ming Qiu
a0fb7398cf
Merge makefile for e2e perf test
...
Signed-off-by: Ming Qiu <ming.qiu@broadcom.com >
2024-04-19 02:15:30 +00:00
Tiger Kaovilai
8f8bc9fd9e
Add notes for podman / colima usage on macOS
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2024-03-25 11:29:16 +07:00
Tiger Kaovilai
b1d95cf2aa
Set GOBIN so Makefile don't modify $PATH on go install Fix realPath resolving when cloud credentials is prefixed by ~ for home dir Use ~/.docker/config.json if REGISTRY_CREDENTIAL_FILE not defined and skip step if does not exists since it is optional
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Set `GOBIN` so Makefile don't modify $PATH on `go install`
Fix realPath resolving when cloud credentials is prefixed by `~` for home dir
Use `~/.docker/config.json` if REGISTRY_CREDENTIAL_FILE not defined and skip step if does not exists since it is optional
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Add kind testdata storageclass
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Add kind testdata storageclass
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
log `Start to install Azure VolumeSnapshotClass ...` only on azure when csi is enabled
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Add BSL_CONFIG example and notes
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Makefile: Set `GOBIN` for `_output/...`
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
README spacing
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
StandbyClusterObjectStoreProvider typo
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Specify velero namespace during get/delete command
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Use object stores rather than cloudProvider for bucket queries
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Remove debug print
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
simplify NS get changes, add velero NS to `DeleteBackupResource`
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Skip file system backups on kind which uses hostPath volumes
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Add StorageClass change test to PR kind e2e
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Add more tests to pr
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Add NS mapping to PR e2e
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Add `SKIP_KIND` to some jobs containing volumes
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Remove kind from kibishii tests
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Label volume resource policies as restic, skip restic/snapshot tests, add more tests
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
TTLTest is a snapshot test
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Remove non working tests
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Resolve https://github.com/vmware-tanzu/velero/pull/7353#issuecomment-1925660077
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
address https://github.com/vmware-tanzu/velero/pull/7353/files#r1477218762
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Address https://github.com/vmware-tanzu/velero/pull/7353#issuecomment-1923414840
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2024-02-04 22:17:37 -05:00
Ming Qiu
3b45830012
Add performance E2E test
...
Signed-off-by: Ming Qiu <mqiu@vmware.com >
2023-08-15 01:46:36 +00:00
Xun Jiang/Bruce Jiang
e51a9d4e1e
Integrate pushing to docker hub and gcr.io in one docker build and push command. ( #6199 )
...
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com >
Co-authored-by: Xun Jiang <blackpiglet@gmail.com >
2023-07-18 08:05:57 +08:00
Mateus Oliveira
9c0562cb94
fix: Lastest release link in website
...
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com >
2023-06-19 10:49:25 -03:00
Wenkai Yin(尹文开)
914ccdf4c6
Improve the unit test coverage of pkg/cmd/server package ( #6342 )
...
Improve the unit test coverage of pkg/cmd/server package
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2023-06-05 23:15:24 +08:00
lyndon
5b75f35262
Add data mover CRD under v2alpha1 ( #6176 )
...
* add data mover CRD under v1alpha1
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
* data mover CRDs to v2alpha1
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
* data mover crd changes
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
---------
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2023-05-16 15:09:54 -04:00
Xun Jiang/Bruce Jiang
15d44724e7
Modify golangci.yaml file. Resolve found lint issues. ( #6008 )
...
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
Co-authored-by: Xun Jiang <blackpiglet@gmail.com >
2023-03-24 12:15:08 +08:00
Ming
e6c8f3afa5
Bump up restic version to 0.15.0
...
Signed-off-by: Ming <mqiu@vmware.com >
2023-01-19 02:43:09 +00:00
Xun Jiang
d1608e7723
Remove container-builder-env section.
...
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
2023-01-16 16:17:59 +08:00
Ming
2f3732fa44
Fix CVEs scanned by trivy
...
Signed-off-by: Ming <mqiu@vmware.com >
2022-12-02 06:57:49 +00:00
danfengliu
1ea1d4df67
Save vvelero image tarball only for velero namespace in docker registry ( #5581 )
...
Signed-off-by: danfengl <danfengl@vmware.com >
2022-11-11 09:29:11 +08:00
danfengl
78dae45c52
Update upgrade test for 1.10
...
Signed-off-by: danfengl <danfengl@vmware.com >
2022-11-10 03:18:01 +00:00
danfengl
4ab2712f6b
Rename secret for Google cloud storage
...
Signed-off-by: danfengl <danfengl@vmware.com >
2022-11-09 07:17:25 +00:00
danfengl
0b6df61eca
Upload Velero build package saved from build image to Google cloud storage
...
Signed-off-by: danfengl <danfengl@vmware.com >
2022-11-08 13:44:04 +00:00
lyndon
d52ec8c079
Pod Volume Backup/Restore Refactor: Rename Init Helper ( #5432 )
...
* restore helper refactor
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
* resolve codespell
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2022-10-17 13:42:09 +08:00
Daniel Jiang
9173ac117e
Let "make shell xxx" respect GOPROXY
...
This commit mitigates the issue for running "make update" locally when
the network is not friendly for accessing the default "proxy.golang.org"
Signed-off-by: Daniel Jiang <jiangd@vmware.com >
2022-07-18 19:22:50 +08:00
Daniel Jiang
89e90d9be4
Delete orphan CSI snapshots in backup sync controller
...
This commit makes backup sync controller delete the volumesnapshot and
volumesnapshotcontent created by the backup which is cleaned up as orphan
Signed-off-by: Daniel Jiang <jiangd@vmware.com >
2022-05-05 10:54:34 +08:00
Xun Jiang
8064421e83
Update integrated Restic version and add insecureSkipTLSVerify for Restic CLI
...
1. Add --insecure-tls for ResticManager's commands.
2. Add --insecure-tls in PodVolumeBackup and PodVolumeRestore controller.
3. Upgrade integrated Restic version to v0.13.1
4. Change --last flag in Restic command to --latest=1 due to Restic version update.
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-04-18 21:29:33 +08:00
Aditya Sharma
47aa093a16
Build for darwin_arm64 ( #4409 )
...
Signed-off-by: Aditya Sharma <git@adi.run >
2021-11-30 11:27:29 -05:00
Wenkai Yin(尹文开)
9f0ea22c60
Fix CVE-2020-29652 and CVE-2020-26160 ( #4274 )
...
Bump up restic to v0.12.1 to fix CVE-2020-26160.
Bump up module "github.com/vmware-tanzu/crash-diagnostics" to v0.3.7 to fix CVE-2020-29652.
The "github.com/vmware-tanzu/crash-diagnostics" updates client-go to v0.22.2 which introduces several break changes, this commit updates the related codes as well
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2021-11-03 13:30:26 -07:00
danfengl
4db866a0b2
Add upgrade test into E2E tests
...
Signed-off-by: danfengl <danfengl@vmware.com >
2021-09-08 13:16:53 +00:00
Bridget McErlean
e525f30856
Fix push-build-image target
...
The `push-build-image` target was broken in #3634 . The `ifneq`
conditional block had tabs for indentation which results in incorrect
behaviour. Instead, remove whitespace before the conditional block like
we do for other similar blocks.
Signed-off-by: Bridget McErlean <bmcerlean@vmware.com >
2021-07-16 18:14:56 -04:00
Bridget McErlean
198ea57407
Allow registry to be configured at build time
...
This adds a new `buildinfo` variable `ImageRegistry` that can set at
build time like the `Version` variable. This allows us to customise the
Velero binary to use different registries.
If the variable is set, this variable wille be used when creating the
URIs for both the main `velero` and `velero-restic-restore-helper`
images. If it is not set, default to using Dockerhub (`velero/velero`,
`velero/velero-restic-restore-helper`).
There are numerous ways in which the Velero binary can be built so all
of them have been updated to add the new link time flag to set the
variable:
* `make local` (used for local developer builds to build for the local
OS and ARCH)
* `make build` (used by developers and also VMware internal builds to
build a specific OS and ARCH)
* Goreleaser config (used when creating OSS release binaries)
* Dockerfile (used to build the Velero binary used within the image)
All of these workflows are currently triggered from our Makefile where
the variable `REGISTRY` is already available with the default value of
`velero` and used to build the image tag. Where the new `ImageRegistry`
build variable is needed, we pass through this Makefile variable to
those tasks so it can be used accordingly.
The GitHub action and the `./hack/docker-push.sh` script used to push
container images has not been modified. This will continue to use the
default registry specified in the Makefile and will not explicitly pass
it in.
Signed-off-by: Bridget McErlean <bmcerlean@vmware.com >
2021-07-14 15:42:53 -04:00