mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-01-04 04:04:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,945 Commits 39 Branches 174 Tags
main
Commit Graph

35 Commits

Author SHA1 Message Date
Shubham Pampattiwar
27ca08b5a5 Address review comments: rename metrics to repo_maintenance_* 
- Rename metric constants from maintenance_job_* to repo_maintenance_*
- Update metric help text to clarify these are for repo maintenance
- Rename functions: RegisterMaintenanceJob* → RegisterRepoMaintenance*
- Update all test references to use new names

Addresses review comments from @Lyndon-Li on PR #9414

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
 2025-12-02 11:36:15 -08:00
Shubham Pampattiwar
fdf439963c Add Prometheus metrics for maintenance jobs 
Adds three new Prometheus metrics to track backup repository
maintenance job execution:

- velero_maintenance_job_success_total: Counter for successful jobs
- velero_maintenance_job_failure_total: Counter for failed jobs
- velero_maintenance_job_duration_seconds: Histogram for job duration

Metrics use repository_name label to identify specific BackupRepositories.
Duration is recorded for both successful and failed jobs (when job runs),
but not when job fails to start.

Includes comprehensive unit and integration tests.

Fixes #9225

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
 2025-12-02 11:36:15 -08:00
Xun Jiang
e8208097ba Bump k8s library to v1.33. 
Replace deprecated EventExpansion method with WithContext methods.
Modify UTs.
Align the E2E ginkgo CLI version with go.mod

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-09-10 17:58:38 +08:00
Xun Jiang
ec99b50970 Remove the repository maintenance job parameters from velero server. 
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-08-07 23:25:22 +08:00
Shubham Pampattiwar
d8f222c83f Add ConfigMap support for keepLatestMaintenanceJobs 
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

add changelog file

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

lint fix

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
 2025-07-31 16:33:46 -07:00
Tiger Kaovilai
1daa685e7d Make ResticIdentifier optional for kopia repositories (#8987) 
The ResticIdentifier field in BackupRepository is only relevant for restic
repositories. For kopia repositories, this field is unused and should be
omitted. This change:

- Adds omitempty tag to ResticIdentifier field in BackupRepository CRD
- Updates controller to only populate ResticIdentifier for restic repos
- Adds tests to verify behavior for both restic and kopia repository types

This ensures backward compatibility while properly handling kopia repositories
that don't require a restic-compatible identifier.

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
 2025-07-24 22:25:09 -04:00
Lyndon-Li
34f8b73507 bump up kopia to v0.21.1 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2025-07-22 15:56:04 +08:00
Xun Jiang/Bruce Jiang
5ebb055c57 Add UT for maintenance's DeleteOldJobs function. (#9013) 
Unify the k8s.io/api/batch/v1 import alias to bactchv1api.

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-06-26 20:49:26 -04:00
Matthieu MOREL
07ea14962c fix require-error rule from testifylint 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-06-23 15:39:54 +00:00
Matthieu MOREL
c6a420bd3a chore: define common aliases for k8s packages (#8672)
Some checks failed
Run the E2E test on kind / build (push) Failing after 6m48s
Details
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Details
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Details
Main CI / Build (push) Failing after 35s
Details
Close stale issues and PRs / stale (push) Successful in 8s
Details
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m11s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 47s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 49s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 43s
Details 
* lchore: define common alias for k8s packages

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-04-22 06:14:47 -04:00
Tiger Kaovilai
1b7d9014a5 add to unmarshal test 
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
 2025-02-20 16:40:49 -06:00
Xun Jiang/Bruce Jiang
fa156c3961 Don't run maintenance on the ReadOnly BackupRepositories. 
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
 2025-02-13 13:46:53 +08:00
Xun Jiang/Bruce Jiang
10a5b7b702 Merge pull request #8624 from mmorel-35/revive/use-any 
chore: enable use-any from revive
 2025-02-07 15:09:05 +08:00
Lyndon-Li
0a4b05cb6e repo maintenance for windows 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2025-01-17 19:06:57 +08:00
Matthieu MOREL
cbba3bdde7 chore: enable use-any from revive 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-01-17 07:58:10 +01:00
Lyndon-Li
fc9683688a move maintenance to a separate folder 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2025-01-13 10:57:14 +08:00
Lyndon-Li
4ce7361f5a recall repo maintenance history on restart 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2025-01-07 12:58:43 +08:00
Lyndon-Li
db69829fd7 repo maintenance job out of repo manager 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2025-01-06 16:25:33 +08:00
Lyndon-Li
912b116bdb always use job's time 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2025-01-03 16:50:35 +08:00
Lyndon-Li
92390e9af5 add repo maintain result in history 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-12-23 15:37:27 +08:00
Lyndon-Li
3b2c50b459 add repo maintain result in history 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-12-19 16:20:15 +08:00
Lyndon-Li
c9bfd33077 isolate repo maintenane history 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-12-19 15:33:58 +08:00
Matthieu MOREL
226a4c1138 golangci-lint: enable and fix thelper linter 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-10-17 08:12:57 +02:00
Tiger Kaovilai
3f9c2dc789 Reduces ~140 indirect imports for plugin/framework importers (#8208) 
* Avoid plugin framework importers from needing cloud provider imports

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
 2024-09-13 10:21:51 +08:00
Shubham Pampattiwar
b62b38f566 Merge pull request #8093 from Lyndon-Li/backkup-repo-config 
Backup repo config
 2024-08-12 13:44:00 -07:00
Tiger Kaovilai
92b9e59fd5 Unused parameters 
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
 2024-07-31 22:15:15 -04:00
Lyndon-Li
7b7727e808 issue 7620: backup repo config 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-07-31 16:41:27 +08:00
Matthieu MOREL
c8baaa9b11 testifylint: enable more rules (#8024) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-07-18 10:43:16 -04:00
Xun Jiang/Bruce Jiang
d640cc16ab Merge pull request #7573 from mmorel-35/golangci-lint-exclude-rules 
golangci-lint: use exclude-rules instead of skip-files and skip-dirs
 2024-03-28 16:39:40 +08:00
Ming Qiu
8d63c76c92 Add maintenance job 
Signed-off-by: Ming Qiu <mqiu@vmware.com>
 2024-03-28 03:22:06 +00:00
Matthieu MOREL
ef04ef6361 golangci-lint: use exclude-rules instead of skip-files and skip-dirs 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-03-27 20:17:34 +00:00
Tiger Kaovilai
da0f5d5850 Field labels for Duration, Time, client.ObjectKey, KibishiiData, VeleroCLI2Version 
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
 2023-04-16 12:34:28 -04:00
lyndon
53c3f4b436 Issue fix 5226 (#5768) 
* fix issue 5226

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-02-07 17:47:25 +08:00
Fish-pro
843c70959f Clean up unnecessary convert (#5819) 
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
 2023-02-06 14:50:31 +08:00
Lyndon-Li
5f7f69366c remove restic from code 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2022-10-13 13:45:32 +08:00