Steve Kriss
30ca0e4322
split out collecting items from backing up items
...
Signed-off-by: Steve Kriss <krisss@vmware.com >
2020-05-01 15:30:42 -06:00
Steve Kriss
19c52434b4
simplify group/resource/item backupper structure
...
Signed-off-by: Steve Kriss <krisss@vmware.com >
2020-05-01 15:29:01 -06:00
Nolan Brubaker
577af5a5b1
Merge pull request #2487 from skriss/fix-error-logging
...
don't return an error from log hook if value is not an error type
2020-05-01 16:11:16 -04:00
Nolan Brubaker
1ed5a13012
Merge pull request #2484 from skriss/fix-2319
...
bug fix: fix int/float conversion issue with CRD type in restore plugin
2020-05-01 16:09:57 -04:00
Ashish Amarnath
bf52caf658
Delete CSI volumesnapshots created as part of a backup in its deletion ( #2411 )
...
* delete CSI volumesnapshots in backup on backup delete
Signed-off-by: Ashish Amarnath <ashisham@vmware.com >
* set vsc deletionpolicy to delete prior to vs deletion
Signed-off-by: Ashish Amarnath <ashisham@vmware.com >
* add more unit tests
Signed-off-by: Ashish Amarnath <ashisham@vmware.com >
* add change log
Signed-off-by: Ashish Amarnath <ashisham@vmware.com >
* passes build need to pass unit tests
Signed-off-by: Ashish Amarnath <ashisham@vmware.com >
* remove GetNamespacesInBackup
Signed-off-by: Ashish Amarnath <ashisham@vmware.com >
* fix unit tests
Signed-off-by: Ashish Amarnath <ashisham@vmware.com >
* check feature flag instead of nil check
Signed-off-by: Ashish Amarnath <ashisham@vmware.com >
* cleanup
Signed-off-by: Ashish Amarnath <ashisham@vmware.com >
2020-05-01 16:05:20 -04:00
Rafael Brito
0d97f9400e
Backup all groups and versions with backward compatibility ( #2373 )
...
* Backup all API Groups versions while keeping backward compatibility
Signed-off-by: Rafael Brito <rbrito@vmware.com >
* Backup all API Groups versions while keeping backward compatibility
Signed-off-by: Rafael Brito <rbrito@vmware.com >
* Adding feature flag to enable backup of multiple API group versions
Signed-off-by: Rafael Brito <rbrito@vmware.com >
2020-05-01 15:54:57 -04:00
Martin Odstrčilík
26f67f1b10
add support for getting Azure Storage Account key from ENV variable ( #2455 )
...
Signed-off-by: Martin Odstrcilik <martin.odstrcilik@gmail.com >
2020-05-01 07:55:50 -07:00
Steve Kriss
5cc6c12eb4
don't return an error from log hook if value is not an error type
...
Signed-off-by: Steve Kriss <krisss@vmware.com >
2020-04-30 15:30:22 -06:00
Steve Kriss
e148ddad8f
Add backwards-compatibility for flags passed to plugins ( #2479 )
...
* update plugin server to ignore unknown flags during parse
Signed-off-by: Steve Kriss <krisss@vmware.com >
2020-04-30 13:19:55 -07:00
Steve Kriss
2d55cd2ed8
bug fix: fix int/float conversion issue with CRD type in restore plugin
...
Signed-off-by: Steve Kriss <krisss@vmware.com >
2020-04-30 09:06:03 -06:00
Steve Kriss
15b2a1c9c6
bug fix: don't remove unresolvable includes from includes-excludes lists ( #2462 )
...
* bug fix: don't remove unresolvable includes from includes-excludes lists
Signed-off-by: Steve Kriss <krisss@vmware.com >
* changelog
Signed-off-by: Steve Kriss <krisss@vmware.com >
2020-04-27 17:17:39 -04:00
FNU Raghavendra Manjunath
98d2fc732e
clarify the wording for restore describe for namespaces included ( #2449 )
...
* clarify the wording for restore describe for namespaces included
Instead of showing it as "*" explicitly mention that all the namespaces
from the backup object are included.
refer to https://github.com/vmware-tanzu/velero/issues/1918
Signed-off-by: Raghavendra M <raghavendra@redhat.com >
* Update pkg/cmd/util/output/restore_describer.go
Co-Authored-By: Ashish Amarnath <ashisham@vmware.com >
Signed-off-by: Raghavendra M <raghavendra@redhat.com >
* Update pkg/cmd/util/output/restore_describer.go
Co-Authored-By: Ashish Amarnath <ashisham@vmware.com >
Signed-off-by: Raghavendra M <raghavendra@redhat.com >
Co-authored-by: Ashish Amarnath <ashisham@vmware.com >
2020-04-24 14:44:20 -07:00
Mayank
962f5d6859
Skipping validation for volumesnapshotlocation for backup if snapshotvolume set to false ( #2450 )
...
* Disabling validation for volumesnapshotlocation if the backup has snapshotvolume set to false
Signed-off-by: mayank <mayank.patel@mayadata.io >
* adding a changelog
Signed-off-by: mayank <mayank.patel@mayadata.io >
* addressing review comment
Signed-off-by: mayank <mayank.patel@mayadata.io >
2020-04-24 09:46:20 -07:00
Nolan Brubaker
aa3abefdbf
Address review feedback
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
16cf2780d8
Fetch contents based on volumesnapshots found
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
bc04c568cd
Return list of errors for encoding/zipping
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
eefd12b3e4
Rename CSI variables to be more descriptive
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
b567859655
Add data description for encoding JSON in case of error
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
d31951c81c
Add CSI feature flag constant
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
15d4c11305
Wrap CSI lister access in a nil check
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
b4e18b489c
Clean up object contents when other files fail
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
ad18318bb1
Rename snapshotter factory variable, return nil in wrapper
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
6c3fc8c780
Addresss simple review feedback
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
9372eaa31b
Reduce duplication in object serialization
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
850554911f
Reduce duplication in object storage uploads
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
9c1a2e884b
Update comments
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
5202885349
Remove unused CSI client variable
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
9719e4de9d
Don't defer cancelFunc, since it causes issues
...
Infomers won't start if cancelFunc is invoked as soon as the newServer
function exits via the defer
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
b7142465fc
Wrap usage of the CSI informer in flag checks
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:18 -04:00
Nolan Brubaker
c71318bf19
Address more review feedback
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:17 -04:00
Nolan Brubaker
5bde12939e
Address review feedback on object store
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:17 -04:00
Nolan Brubaker
5de15c450b
Address some review feedback on server
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:17 -04:00
Nolan Brubaker
aff529e5d5
Upload CSI volumesnapshots associated with backup
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:17 -04:00
Nolan Brubaker
6a7beaf5ce
Plumb CSI listers through to backup controller
...
Account for having CSI enabled or not, as well as having the snapshot
CRDs installed in the kubernetes cluster.
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:17 -04:00
Nolan Brubaker
232e1d8927
Add clients for CSI snapshots
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:17 -04:00
Nolan Brubaker
b4be7eccb9
Document locations for CSI support
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-20 13:49:17 -04:00
Nolan Brubaker
29769eeb5b
Merge pull request #2439 from skriss/dynamic-list-refactor
...
change dynamic client's List return type to UnstructuredList
2020-04-16 15:16:30 -04:00
Ashish Amarnath
bf2ef69aa7
Merge pull request #2431 from nrb/fix2429
...
Annotate backups with kubernetes version information
2020-04-15 11:45:10 -07:00
Steve Kriss
ca58d7ab90
change dynamic client's List return type to UnstructuredList
...
Signed-off-by: Steve Kriss <krisss@vmware.com >
2020-04-15 12:41:47 -06:00
Steve Kriss
1826b6b67b
bug fix: populate namespace in logs for backup errors ( #2438 )
...
Signed-off-by: Steve Kriss <krisss@vmware.com >
2020-04-15 10:31:40 -07:00
Nolan Brubaker
67322d555e
Write kubernetes version info to annoations
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-04-14 17:11:04 -04:00
Ashish Amarnath
824bc8eec5
Merge pull request #2390 from skriss/fix-2366
...
bug fix: save PVBs even if no snapshot was taken
2020-04-08 12:21:43 -07:00
Samuel Lucidi
c8223608ba
Add --cacert flag to velero cli commands ( #2364 )
...
* Add --cacert flag to velero cli commands
Adds a --cacert flag to the log and describe commands
that takes a path to a PEM-encoded certificate bundle
as an alternative to --insecure-skip-tls-verify for
dealing with self-signed certificates.
Signed-off-by: Sam Lucidi <slucidi@redhat.com >
2020-04-03 08:02:41 -07:00
Mayank
016868ecd3
add restore item action to update PVC selected-node annotation ( #2377 )
...
* New RestoreItemAction for PVC with annotation `volume.kubernetes.io/selected-node`
Signed-off-by: mayank <mayank.patel@mayadata.io >
2020-04-03 08:01:34 -07:00
Ashish Amarnath
061b4463ce
ensure target namespace exists prior to retoring a resource ( #2389 )
...
Signed-off-by: Ashish Amarnath <ashisham@vmware.com >
2020-04-03 07:57:01 -07:00
Steve Kriss
91228522be
bug fix: save PVBs even if no snapshot was taken
...
Signed-off-by: Steve Kriss <krisss@vmware.com >
2020-04-02 13:17:41 -06:00
Ashish Amarnath
969526cee5
Merge pull request #2381 from nrb/plugin-feature-flag
...
Add features flag to plugin server
2020-03-31 16:57:02 -07:00
Samuel Lucidi
02b5578810
Add --cacert flag to the installer ( #2368 )
...
* Add --cacert flag to the installer
Allows setting the cacert field on the BSL during
the install process using the file at the path
specified by the --cacert field.
Signed-off-by: Sam Lucidi <slucidi@redhat.com >
* Add changelog for #2368
Signed-off-by: Sam Lucidi <slucidi@redhat.com >
2020-03-31 14:48:16 -06:00
Nolan Brubaker
bc2717fca1
Add features flag to plugin server
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-03-31 14:01:47 -04:00
Nolan Brubaker
7c87aebe5f
Only add CA cert to plugin config if it's defined
...
Signed-off-by: Nolan Brubaker <brubakern@vmware.com >
2020-03-31 13:59:37 -04:00