Steve Kriss
b029860b46
AWS: remove region requirement from config for backupStorageProvider
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-05-22 11:59:53 -07:00
Calle Pettersson
24dfef6f15
Handle errors in additionalItemBackupper
...
Signed-off-by: Calle Pettersson <cpettsson@gmail.com >
2018-05-22 18:32:48 +02:00
Mike Arpaia
cb7bcea5c3
Add functional options for the Ark config install library
...
Signed-off-by: Mike Arpaia <mike@arpaia.co >
2018-05-22 09:21:12 -06:00
Andy Goldstein and GitHub
aeb5f6d832
Merge pull request #437 from marpaia/install-api
...
Add library code to install required server components
2018-05-18 16:48:42 -04:00
Mike Arpaia
16f707aa11
Add library code to install required server components
...
This PR includes Go library code to assist with the installation of
required server-side components.
Signed-off-by: Mike Arpaia <mike@arpaia.co >
2018-05-18 14:43:06 -06:00
Andy Goldstein and GitHub
2fde1f5fc1
Merge pull request #500 from nrb/fix-497
...
Exit when failing to update a backup's phase
2018-05-17 14:23:41 -04:00
Andy Goldstein and GitHub
3a746a3f73
Merge pull request #496 from nrb/fix-477
...
Check restore Phase before downloading logs
2018-05-17 13:23:23 -04:00
Andy Goldstein and GitHub
f288902e3e
Merge pull request #490 from skriss/jsonpatch
...
Use JSON merge patches everywhere
2018-05-17 13:02:47 -04:00
Nolan Brubaker
7eac6675e8
Exit when failing to update a backup's phase
...
Signed-off-by: Nolan Brubaker <nolan@heptio.com >
2018-05-17 12:47:38 -04:00
Nolan Brubaker
f6761ddd00
Check restore Phase before downloading logs
...
Signed-off-by: Nolan Brubaker <nolan@heptio.com >
2018-05-17 12:20:55 -04:00
Steve Kriss and GitHub
5d74a92cf1
Merge pull request #484 from nrb/move-groupresources
...
Consolidate commonly used GroupResource objects
2018-05-15 14:02:29 -07:00
Nolan Brubaker
f936c55a37
Consolidate commonly used GroupResource objects
...
Signed-off-by: Nolan Brubaker <nolan@heptio.com >
2018-05-15 15:55:15 -04:00
Andy Goldstein and GitHub
ad93135adb
Merge pull request #483 from skriss/graceful-shutdown-on-sigs
...
shutdown gracefully on SIGINT/SIGTERM
2018-05-15 14:33:09 -04:00
Andy Goldstein and GitHub
67263d2652
Merge pull request #486 from nrb/fix-475
...
Filter on resources that support get & delete
2018-05-15 10:58:56 -04:00
Nolan Brubaker
4fcd222777
Expand required resource verbs with get and delete
...
Some resources use GET for listing, which resulted in errors.
Signed-off-by: Nolan Brubaker <nolan@heptio.com >
2018-05-15 10:55:03 -04:00
Steve Kriss
6d6f734bc9
use json merge patches
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-05-14 14:34:24 -07:00
Steve Kriss
1c950aa17b
unit test to ensure new cohabitatingResources map for each backup
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-05-14 10:23:21 -07:00
Steve Kriss
ed7fbc9178
use new cohabitatingResources map for each backup
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-05-11 16:30:14 -07:00
Steve Kriss
20f56e9868
cleanup plugin subprocesses on server exit
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-05-11 09:48:46 -07:00
Steve Kriss
09c20b51e6
shutdown gracefully on SIGINT/SIGTERM
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-05-10 16:22:14 -07:00
Steve Kriss
fbb5ead4e9
add replicasets and daemonsets to cohabitating resources
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-05-10 14:15:01 -07:00
Andy Goldstein and GitHub
43b1f9a19e
Merge pull request #418 from skriss/refactor-patch-tests
...
use typed structs for decoding patch JSON in unit tests
2018-05-09 15:44:21 -04:00
Andy Goldstein and GitHub
ea83ed32f5
Merge pull request #470 from skriss/backup-cluster-roles-and-bindings
...
backups: include clusterroles/bindings that reference serviceaccounts
2018-05-09 13:21:13 -04:00
Steve Kriss
041cfc2173
backups: include clusterroles/bindings that reference serviceaccounts
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-05-09 10:03:55 -07:00
Andy Goldstein and GitHub
ef5ac7fd05
Merge pull request #463 from nrb/fix-454
...
Don't restore completed pods or jobs
2018-05-09 09:59:34 -04:00
Steve Kriss
e81de2491f
remove duplicate github.com/satori/go.uuid dependency
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-05-07 10:02:59 -07:00
Steve Kriss
51928e9177
use typed structs for decoding patch JSON in unit tests
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-05-07 09:22:20 -07:00
Steve Kriss
6754955bcd
when syncing backups, set their namespace to current cluster's Ark ns
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-05-07 09:12:51 -07:00
Nolan Brubaker
923870390b
Skip completed jobs and pods when restoring
...
Completed jobs and pods may be useful in the backup for auditing
purposes, but don't recreate them when restoring.
Signed-off-by: Nolan Brubaker <nolan@heptio.com >
2018-05-02 12:16:54 -04:00
Andy Goldstein and GitHub
18d6b233da
Merge pull request #453 from nrb/fix-444
...
Make empty excludes string more accurate
2018-04-24 14:53:33 -04:00
Andy Goldstein and GitHub
c8989231eb
Merge pull request #417 from skriss/upgrade-k8s-deps
...
Upgrade apimachinery, client-go, api, kubernetes dependencies
2018-04-24 14:53:11 -04:00
Nolan Brubaker
05cb059b1a
Make empty excludes string more accurate
...
Signed-off-by: Nolan Brubaker <nolan@heptio.com >
2018-04-24 14:34:56 -04:00
Steve Kriss
72d7e5e01d
azure: pass full snapshot name when restoring disk
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-04-23 12:51:05 -07:00
Steve Kriss
a466208975
add backwards-compatibility for azure snapshot ID
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-04-23 11:34:37 -07:00
Steve Kriss
3dc093c24a
regenerate code with updated generator
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-04-20 12:59:22 -07:00
Steve Kriss
989169dcfe
remove unused kubernetes/pkg/util/version dependency
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-04-20 12:59:22 -07:00
Steve Kriss
97e52f2b3c
add timeout arg to rest.NewRequest()
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-04-20 12:58:53 -07:00
Steve Kriss
961d7f2924
kubernetes/pkg/printers/ShortHumanDuration -> apimachinery/pkg/util/duration
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-04-20 12:58:53 -07:00
Nolan Brubaker
300a010959
Remove finalizers from backups before syncing
...
Signed-off-by: Nolan Brubaker <nolan@heptio.com >
2018-04-18 17:32:39 -04:00
Andy Goldstein and GitHub
730ddb2113
Merge pull request #391 from containscafeine/handle-restore-missing-error
...
Introduce validation logic to `ark restore logs`
2018-04-12 11:07:29 -04:00
Shubham Minglani
7f3e88151b
Add bash and zsh completion support
...
This commit adds support for auto completion for bash and zsh
shells. A new root level command called "completion" has been
introduced, and the user can get the auto completion code by
running `ark completion bash/zsh`.
For bash completion, the built-in GenBashCompletion() from cobra
has been used, but for zsh, the built-in GenZshCompletion() is
known to cause issues. The workaround has been copied from zsh
completion code of kubectl.
Signed-off-by: Shubham <shubham@linux.com >
2018-04-12 13:26:23 +05:30
Shubham
468c4faf1b
Introduce validation logic to ark restore logs
...
This commit introduces validation logic to `ark restore logs`
command, the way it already exists in other commands like `ark
restore create`.
Before the logs for a restore are fetched from the server, the
server is contacted to check if the specified restore exists. If
it does not, it errors out.
Fixes #389
Signed-off-by: Shubham <shubham@linux.com >
2018-04-12 13:06:32 +05:30
Andy Goldstein and GitHub
0998f6d8af
Merge pull request #405 from nrb/ignore-duplicates
...
Compare for duplicates before logging object exists errors
2018-04-11 09:47:37 -04:00
Nolan Brubaker
33cc85cd0c
Compare backup and cluster objects before logging
...
When restoring resources that raise an already exists error, check their
equality before logging a message on the restore. If they're the same
except for some metadata, don't generate a message.
The restore process was modified so that if an object had an empty
namespace string, no namespace key is created on the object. This was to
avoid manipulating the copy of the current cluster's object by adding
the target namespace.
There are some cases right now that are known to not be equal via this
method:
- The `default` ServiceAccount in a namespace will not match, primarily
because of differing default tokens. These will be handled in their own
patch
- IP addresses for Services are recorded in the backup object, but are
either not present on the cluster object, or different. An issue for
this already exists at https://github.com/heptio/ark/issues/354
- Endpoints have differing values for `renewTime`. This may be
insubstantial, but isn't currently handled by the resetMetadataAndStatus
function.
- PersistentVolume objects do not match on spec fields, such as
claimRef and cloud provider persistent disk info
Signed-off-by: Nolan Brubaker <nolan@heptio.com >
2018-04-10 14:55:48 -04:00
Andy Goldstein and GitHub
258f3e011e
Merge pull request #409 from skriss/fix-398
...
get backup name from restore spec when handling restore DownloadRequests
2018-04-10 13:29:07 -04:00
Steve Kriss
0d2b49acce
get backup name from restore spec when handling restore DownloadRequests
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-04-09 10:50:10 -07:00
Steve Kriss
5bb47d2b7a
extract a helper for comparing slices of Actions reliably
...
Signed-off-by: Steve Kriss <steve@heptio.com >
2018-04-09 09:39:33 -07:00
Andy Goldstein
3f2e222ae4
Don't allow deletion of in-progress backups
...
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com >
2018-04-06 13:08:39 -04:00
Andy Goldstein
644a75e3c1
Set DeleteBackupRequest labels if missing
...
When the BackupDeletionController processes a request, set the request's
backup-name and backup-uid labels if they aren't currently set.
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com >
2018-04-05 15:38:44 -04:00
Andy Goldstein
ef57a44827
Require DeleteBackupRequest.Spec.BackupName
...
Make sure a DeleteBackupRequest has its Spec.BackupName filled in. If
not, record an error in the status and mark the request as processed.
Signed-off-by: Andy Goldstein <andy.goldstein@gmail.com >
2018-04-05 14:53:10 -04:00