mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-01-06 21:36:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,923 Commits 40 Branches 174 Tags
aa3bd251ddcc3c4ed58f50fbe692f17259d3e2d7
Commit Graph

141 Commits

Author SHA1 Message Date
Shubham Pampattiwar
4ba2effaac Add nolint directives for intentional deprecated function usage 
The ShouldPerformSnapshotWithVolumeHelper function and tests intentionally
use NewVolumeHelperImpl (deprecated) for backwards compatibility with
third-party plugins. Add nolint:staticcheck to suppress the linter
warnings with explanatory comments.

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
 2025-12-17 10:54:11 -08:00
Shubham Pampattiwar
f592a264a6 Address review feedback: remove deprecated functions 
Remove deprecated functions that were marked for removal per review:
- Remove GetPodsUsingPVC (replaced by GetPodsUsingPVCWithCache)
- Remove IsPVCDefaultToFSBackup (replaced by IsPVCDefaultToFSBackupWithCache)
- Remove associated tests for deprecated functions
- Add deprecation marker to NewVolumeHelperImpl
- Add deprecation marker to ShouldPerformSnapshotWithBackup

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
 2025-12-17 10:44:15 -08:00
Shubham Pampattiwar
987edf5037 Add global VolumeHelper caching in CSI PVC BIA plugin 
Address review feedback to have a global VolumeHelper instance per
plugin process instead of creating one on each ShouldPerformSnapshot
call.

Changes:
- Add volumeHelper, cachedForBackup, and mu fields to pvcBackupItemAction
  struct for caching the VolumeHelper per backup
- Add getOrCreateVolumeHelper() method for thread-safe lazy initialization
- Update Execute() to use cached VolumeHelper via
  ShouldPerformSnapshotWithVolumeHelper()
- Update filterPVCsByVolumePolicy() to accept VolumeHelper parameter
- Add ShouldPerformSnapshotWithVolumeHelper() that accepts optional
  VolumeHelper for reuse across multiple calls
- Add NewVolumeHelperForBackup() factory function for BIA plugins
- Add comprehensive unit tests for both nil and non-nil VolumeHelper paths

This completes the fix for issue #9179 by ensuring the PVC-to-Pod cache
is built once per backup and reused across all PVC processing, avoiding
O(N*M) complexity.

Fixes #9179

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
 2025-12-15 14:18:05 -08:00
Xun Jiang
64e3643006 Fix linter error reported.
Some checks failed
Run the E2E test on kind / get-go-version (push) Failing after 1m17s
Details
Run the E2E test on kind / build (push) Has been skipped
Details
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Details
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Details 
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-11-26 14:16:42 +08:00
Lyndon-Li
99d87aae5b fix linter error 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2025-11-24 17:21:00 +08:00
Lyndon-Li
34f8b73507 bump up kopia to v0.21.1 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2025-07-22 15:56:04 +08:00
Matthieu MOREL
07ea14962c fix require-error rule from testifylint 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-06-23 15:39:54 +00:00
Matthieu MOREL
c6a420bd3a chore: define common aliases for k8s packages (#8672)
Some checks failed
Run the E2E test on kind / build (push) Failing after 6m48s
Details
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Details
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Details
Main CI / Build (push) Failing after 35s
Details
Close stale issues and PRs / stale (push) Successful in 8s
Details
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m11s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 47s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 49s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 43s
Details 
* lchore: define common alias for k8s packages

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-04-22 06:14:47 -04:00
Matthieu MOREL
9010d9b13e chore: enable unnecessary-stmt from revive 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-02-08 12:11:22 +00:00
Matthieu MOREL
cbba3bdde7 chore: enable use-any from revive 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-01-17 07:58:10 +01:00
Lyndon-Li
11cd6d922b hybrid deploy 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-12-17 13:05:46 +08:00
Lyndon-Li
0ea4eb563a hybrid deploy 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-12-10 18:28:18 +08:00
Matthieu MOREL
226a4c1138 golangci-lint: enable and fix thelper linter 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-10-17 08:12:57 +02:00
Scott Seago
6fa81ec9b9 fixed error message typo for item block action 
Signed-off-by: Scott Seago <sseago@redhat.com>
 2024-10-15 15:22:19 -04:00
Tiger Kaovilai
3f9c2dc789 Reduces ~140 indirect imports for plugin/framework importers (#8208) 
* Avoid plugin framework importers from needing cloud provider imports

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
 2024-09-13 10:21:51 +08:00
Wenkai Yin(尹文开)
dc6eeafe98 Pass Velero server command args to the plugins 
Pass Velero server command args to the plugins

Fixes #7806

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
 2024-09-04 13:43:27 +08:00
Scott Seago
ba9c109868 Create new ItemBlockAction (IBA) plugin type 
Signed-off-by: Scott Seago <sseago@redhat.com>
 2024-07-29 11:08:54 -04:00
Matthieu MOREL
c8baaa9b11 testifylint: enable more rules (#8024) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-07-18 10:43:16 -04:00
Matthieu MOREL
c69f47d5d2 Migrate from github.com/golang/protobuf to google.golang.org/protobuf (#7593) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-07-16 16:28:07 -04:00
Matthieu MOREL
35c90f1672 testifylint: enable error-nil rule (#7670) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-07-16 12:23:16 -04:00
Xun Jiang
c4ce6a3382 Expose the VolumeHelper to third-party plugins. 
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
 2024-07-03 11:16:56 +08:00
Matthieu MOREL
facfb9552f migrating to sdk/resourcemanager/**/arm** from services/**/mgmt/** (#7596) 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-04-15 09:55:52 -04:00
Xun Jiang
59eeec268b Update CSI document. Remove the CSI plugin verifier. 
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
 2024-04-12 13:51:20 +08:00
Matthieu MOREL
ef04ef6361 golangci-lint: use exclude-rules instead of skip-files and skip-dirs 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-03-27 20:17:34 +00:00
Xun Jiang
d70535b6d2 Add nolintlint linter. 
Signed-off-by: Xun Jiang <jxun@vmware.com>
 2023-11-29 11:13:46 +08:00
Lyndon-Li
873197ff50 issue 6693: partially fail restore if CSI snapshot is involved but CSI feature is not ready 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-11-09 17:37:23 +08:00
yanggang
1efd533d0d Fix wrong logs in markDataDownloadsCancel() and add missiong license file. 
Signed-off-by: yanggang <gang.yang@daocloud.io>
 2023-10-19 14:04:41 +01:00
Mateus Oliveira
913b610196 fix: Typos and add more spell checking rules to CI (#6415) 
* fix: Typos and add more spell checking rules to CI

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>

* fixup! fix: Typos and add more spell checking rules to CI

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>

* fixup! fix: Typos and add more spell checking rules to CI

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>

* fixup! fix: Typos and add more spell checking rules to CI

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>

* fixup! fix: Typos and add more spell checking rules to CI

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>

* fixup! fix: Typos and add more spell checking rules to CI

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>

* fixup! fix: Typos and add more spell checking rules to CI

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>

* fixup! fix: Typos and add more spell checking rules to CI

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>

---------

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
 2023-07-21 17:25:24 -04:00
Efim Smykov
aed8c8ec1b Fix typos related to Delete Item Action plugin type (#6333) 
Signed-off-by: Nutrymaco <efim7299@icloud.com>
 2023-06-09 15:44:03 +08:00
Ming
f03e73bfc2 Fix PluginConfigLabelSelector bugs 
Signed-off-by: Ming <mqiu@vmware.com>
 2023-05-15 02:46:24 +00:00
Xun Jiang
f051ecaee9 Enable errcheck linter and resolve found issues. 
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
 2023-04-28 09:33:42 +08:00
qiuming
fbba4e5c77 Merge pull request #6151 from kaovilai/expose-getpluginconfig 
Make GetPluginConfig accessible from other packages.
 2023-04-26 17:42:19 +08:00
Xun Jiang/Bruce Jiang
a8a17d725a Merge pull request #6194 from blackpiglet/linter_more 
Enable more linters, and remove mal-functioned milestoned issue action.
 2023-04-26 14:12:47 +08:00
Xun Jiang/Bruce Jiang
e106bbf06b Enable linter revive and resolve found errors: part 2. (#6177) 
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
Co-authored-by: Xun Jiang <blackpiglet@gmail.com>
 2023-04-26 14:05:22 +08:00
Xun Jiang
443f732e51 Enable more linters, and remove mal-functioned milestoned issue action. 
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
 2023-04-25 23:31:51 +08:00
Xun Jiang/Bruce Jiang
51c67089f5 Merge branch 'main' into linter_staticcheck 
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
 2023-04-25 15:49:05 +08:00
Xun Jiang
bbc1e2e151 Enable stylecheck linter and resolve found issues. 
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
 2023-04-25 14:37:02 +08:00
Xun Jiang
cb0ada1e1c Enable staticcheck and resolve found issues. 
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
 2023-04-25 11:33:40 +08:00
Xun Jiang/Bruce Jiang
1fd28e8a36 Fix usestdlibvars and whitespace linters issues. (#6162) 
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
Co-authored-by: Xun Jiang <blackpiglet@gmail.com>
 2023-04-24 09:10:55 +08:00
Tiger Kaovilai
08f7f555f3 mv pkg/restore/pod_volume_restore_action.go/getPluginConfig pkg/plugin/framework/common/plugin_config.go/GetPluginConfig 
Fixes Expose GetPluginConfig #4865

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
 2023-04-15 07:04:42 +00:00
Xun Jiang
fc692c49e6 Update Golang version to v1.19 for branch main. 
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
 2023-04-04 12:00:19 +08:00
Xun Jiang/Bruce Jiang
15d44724e7 Modify golangci.yaml file. Resolve found lint issues. (#6008) 
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
Co-authored-by: Xun Jiang <blackpiglet@gmail.com>
 2023-03-24 12:15:08 +08:00
Daniel Jiang
458560795b Remove Reference of itemsnapshotter (#5997) 
It will be removed as we choose to use BIAv2 for progress monitoring.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2023-03-21 09:05:29 +08:00
Scott Seago
2155b2b215 RIAv2 async operations controller work 
Signed-off-by: Scott Seago <sseago@redhat.com>
 2023-03-17 14:30:39 -04:00
杨刚 (成都)
ad9c6e8dee delete io/ioutil package. (#5955) 
Signed-off-by: yanggang <gang.yang@daocloud.io>
 2023-03-16 09:25:58 +08:00
Scott Seago
dd63e8182c Follow-on fixes for BIAv2 controller work 
Signed-off-by: Scott Seago <sseago@redhat.com>
 2023-03-13 10:29:36 -04:00
Scott Seago
c3d1d83da5 BIAv2 async operations controller work 
Signed-off-by: Scott Seago <sseago@redhat.com>
 2023-03-01 11:49:17 -05:00
Fish-pro
ef05af13bf Clean up unused variables and functions (#5818) 
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
 2023-02-09 10:53:24 +08:00
Fish-pro
843c70959f Clean up unnecessary convert (#5819) 
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
 2023-02-06 14:50:31 +08:00
Scott Seago
9f6f13f0c5 RestoreItemAction v2 API implementation 
Signed-off-by: Scott Seago <sseago@redhat.com>
 2023-01-10 16:26:28 -05:00