Ming
ac58c7508b
Fix restic backups to multiple backup storage locations bug
...
Signed-off-by: Ming <mqiu@vmware.com >
2022-08-03 07:03:58 +00:00
Daniel Jiang
18375cf1a9
Skip registering "crd-remap-version" plugin when feature flag ( #5165 ) ( #5173 )
...
"EnableAPIGroupVersions" is set
The crd-remap-version plugin will always backup v1b1 resource for some
CRD. It impacts the feature flag `EnableAPIGroupVersions` which means to
backup all versions, and make migration fail.
In this commit the featureSet was removed from plugin server struct b/c
it blocks the parm `--features` to be populated correctly. This change
should not have negative impact b/c the attribute in server struct is never used.
Fixes #5146
Signed-off-by: Daniel Jiang <jiangd@vmware.com >
2022-08-03 09:53:54 +08:00
Xun Jiang
4d20c5a112
Delay CA file deletion in PVB controller
...
Fix #5140 .
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-07-26 11:10:07 +08:00
Scott Seago
b5c14d90bb
Modify BackupStoreGetter to avoid BSL spec changes
...
Pass in a new copy of the map of config values rather than
modifying the BSL Spec.Config and then pass in that field.
Signed-off-by: Scott Seago <sseago@redhat.com >
2022-07-19 11:07:18 -04:00
Wenkai Yin(尹文开)
1996ee3be0
Fix bsl validation bug
...
Fix bsl validation bug: the BSL is validated continually and doesn't respect the validation period configured
Fixes #5056
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2022-07-11 10:44:48 +08:00
Scott Seago
5dbc98e679
When spec.RestoreStatus is empty, don't restore status
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2022-06-16 10:13:01 -04:00
Xun Jiang
806234e043
Add more information for failing to get path or snapshot in restic backup and restore.
...
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-06-13 11:32:55 +08:00
Wenkai Yin(尹文开)
d16bdf1f80
Bugs fixing: use patch to update status and set default GC period
...
1. Use patch rather status patch in backup sync controller as we have disable status as sub resource
2. Set the GC period with default value if it isn't set
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2022-06-10 17:15:19 +08:00
Wenkai Yin(尹文开)
c3a32a116f
Merge pull request #4976 from reasonerjt/vsc-policy-reset-undo
...
Undo setting the VSC's deletion policy during backup
2022-06-10 09:12:46 +08:00
Daniel Jiang
f5649bcc1f
Undo setting the VSC's deletion policy during backup
...
It's not necessary to set the deletion policy as the delete item action
plugin in CSI plugin will set it to Delete when the backup is deleted.
Signed-off-by: Daniel Jiang <jiangd@vmware.com >
2022-06-09 16:26:05 +08:00
Wenkai Yin(尹文开)
34087fe5f4
Disable status as sub resource in CRDs
...
When enabling the status as sub resource in CRD, the status will be ignored when creating the CR with status, this will cause issues when syncing backups/pvbs
Fixes #4950
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2022-06-09 07:52:08 +08:00
Wenkai Yin(尹文开)
6fa4d7d606
Mark in-progress CRs as failed when starting the server
...
Mark in-progress CRs as failed when starting the server
Fixes #4953
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2022-06-07 17:02:17 +08:00
Scott Seago
a79c1a5877
Merge pull request #4785 from RafaeLeal/restore-status
...
Add ability to restore status on selected resources
2022-05-24 09:41:18 -04:00
Rafael Leal
e0e3016efa
Cleanup resetStatus
...
Signed-off-by: Rafael Leal <rafaelealdias@gmail.com >
2022-05-23 17:53:32 -03:00
Scott Seago
471e357952
Merge pull request #4914 from blackpiglet/4912-fix-completion-zsh
...
Make velero completion zsh command output can be used by `source` com…
2022-05-23 10:05:12 -04:00
Rafael Leal
131c8a920f
Remove break line
...
Signed-off-by: Rafael Leal <rafaelealdias@gmail.com >
2022-05-19 17:36:21 -03:00
Rafael Leal
bcef5e1d5e
Refactor to simplify
...
Signed-off-by: Rafael Leal <rafaelealdias@gmail.com >
2022-05-17 10:39:14 -03:00
Wenkai Yin(尹文开)
44199db79d
Enhance the map flag to support parsing input value contains entry delimiters
...
Enhance the map flag to support parsing input value contains entry delimiters
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2022-05-17 13:56:41 +08:00
Xun Jiang
3db40a58a4
Make velero completion zsh command output can be used by source command.
...
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-05-17 10:01:46 +08:00
Rafael Leal
d85ed612cb
Cleanup
...
Signed-off-by: Rafael Leal <rafaelealdias@gmail.com >
2022-05-12 12:01:00 -03:00
Rafael Leal
206709b978
Cleanup
...
Signed-off-by: Rafael Leal <rafaelealdias@gmail.com >
2022-05-12 12:01:00 -03:00
Rafael Leal
8ecc11fad2
Add restore status to cli
...
Signed-off-by: Rafael Leal <rafaelealdias@gmail.com >
2022-05-12 12:00:34 -03:00
Rafael Leal
7f22974719
Update CRDs
...
Signed-off-by: Rafael Leal <rafaelealdias@gmail.com >
2022-05-12 11:59:49 -03:00
Rafael Leal
04aa7a849f
Fixes tests hopefully
...
Signed-off-by: Rafael Leal <rafaelealdias@gmail.com >
2022-05-12 11:59:05 -03:00
Rafael Leal
0b9d6ae73d
Add restore status mechanism
...
Signed-off-by: Rafael Leal <rafaelealdias@gmail.com >
2022-05-12 11:59:05 -03:00
Rafael Leal
7f1f881c28
Add resource status
...
Signed-off-by: Rafael Leal <rafaelealdias@gmail.com >
2022-05-12 11:58:47 -03:00
Rafael Leal
e374eb9da4
Add StatusUpdater
...
Signed-off-by: Rafael Leal <rafaelealdias@gmail.com >
2022-05-12 11:57:41 -03:00
Rafael Leal
6a721403fb
Fix DeepEqual when status is updated
...
Signed-off-by: Rafael Leal <rafaelealdias@gmail.com >
2022-05-12 10:47:24 -03:00
Daniel Jiang
9b5257663a
Merge pull request #4650 from shubham-pampattiwar/add-label-selectors
...
Add multiple label selector support to Velero Backup and Restore APIs
2022-05-11 23:16:28 +08:00
Shubham Pampattiwar
bfdb68a35a
add multiple label selector support to backup API
...
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
remove backup CLI bits
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
labelselectors spec option for velero restore
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
add changelog file
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
update spec name to OrLabelSelectors
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
minor fixes
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
add validations for labelSelector and orLabelSelectors
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
update crds.gp after fixing conflicts
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
fix CI and add unit tests
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
updated OrLabelSelector spec description and added validation failure unit tests
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
add comments and change log level
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
update site docs
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
wrap pager client calls in a function
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
resolve confilcts and update crds.go
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
rebase and update crds.go
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
combine listing items for a given label
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
2022-05-11 09:57:47 -04:00
Wenkai Yin(尹文开)
879d03398b
Merge pull request #4894 from blackpiglet/bsl-refactor
...
Refactor BSL controller with periodical enqueue source
2022-05-11 19:23:51 +08:00
Xun Jiang
989a1e3ebb
Refactor BSL controller with periodical enqueue source.
...
Add filter functions for PeriodicalEnqueueSource.
Move BSL's valication frequency check test case to PeriodicalEnqueueSource's test.
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-05-11 15:31:47 +08:00
qiuming
d48e1d9db7
Merge pull request #4897 from ywk253100/220609_gc
...
Make garbage collection for expired backups configurable
2022-05-11 10:46:03 +08:00
Wenkai Yin(尹文开)
6a551e546e
Make garbage collection for expired backups configurable
...
Make garbage collection for expired backups configurable
Fixes #4875
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2022-05-11 10:33:59 +08:00
Shubham Pampattiwar
e3106f3e10
add existingResourcePolicy to Restore API
...
add updateall policy option
fix updating labels
dump updateAll policy option
remove updateAll policy refs
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
add changelog file
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
update docs
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
patch labels for sa if policy is update
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
fix existingResourcePolicy for serviceaccounts
modularize changes and add unit tests
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
fix conflicts and update crds.go
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
change log level from info to error
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
update crds.go
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
2022-05-09 13:36:24 -04:00
Xun Jiang/Bruce Jiang
40a36d2941
Merge pull request #4859 from qiuming-best/restic-repo-tmp
...
Convert Restic Repository resource/controller to the Kubebuilder framework
2022-05-09 17:57:01 +08:00
Wenkai Yin(尹文开)
1d8d2bdb4f
Merge pull request #4890 from sseago/restoreitemaction-label-fix
...
continue rather than return for non-matching restore action label
2022-05-09 14:34:03 +08:00
Ming
ef7e5a8388
change func name and repository description
...
Signed-off-by: Ming <mqiu@vmware.com >
2022-05-09 13:57:02 +08:00
Xun Jiang/Bruce Jiang
62dde34f86
Merge pull request #4893 from ywk253100/220506_restart
...
Make in-progress PVB/PVR as failed when restic controller restarts to avoid hanging backup/restore
2022-05-07 17:32:40 +08:00
Wenkai Yin(尹文开)
034cda2571
Make in-progress PVB/PVR as failed when restic controller restarts to avoid hanging backup/restore
...
Make in-progress PVB/PVR as failed when restic controller restarts to avoid hanging backup/restore
Fixes #4772
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2022-05-07 16:51:06 +08:00
Ming
752b28166f
Merge branch 'main' of https://github.com/qiuming-best/velero into restic-repo-tmp
2022-05-06 14:43:00 +08:00
Scott Seago
da916846b1
continue rather than return for non-matching restore action label
...
When iterating over applicable restore actions, if a non-matching label
selector is found, velero should continue to the next action rather than
returning from the restoreItem func, which ends up preventing the item's
restore entirely.
Signed-off-by: Scott Seago <sseago@redhat.com >
2022-05-05 08:37:48 -04:00
Xun Jiang
a69bd8b1f3
Remove VolumeSnapshot created during backup, when the VolumeSnapshotClass's DeletionPolicy is set to Delete.
...
1. Delete VolumeSnapshot directly when DeletionPolicy set to Retain.
2. Change VolumeSnapshotContent's DeletionPolicy to Retain, then delete VolumeSnapshot. After that delete VolumeSnapshotContent and change VSC DeletionPolicy to Delete back, then re-create the VolumeSnapshotContent.
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-05-05 18:30:59 +08:00
Xun Jiang
6421f8ad02
Make waiting VolumeSnapshot to ready process parallel.
...
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-05-05 14:32:55 +08:00
Wenkai Yin(尹文开)
aa71427576
Merge pull request #4887 from reasonerjt/delete-orphan-vs
...
Delete orphan CSI snapshots in backup sync controller
2022-05-05 11:27:44 +08:00
Daniel Jiang
89e90d9be4
Delete orphan CSI snapshots in backup sync controller
...
This commit makes backup sync controller delete the volumesnapshot and
volumesnapshotcontent created by the backup which is cleaned up as orphan
Signed-off-by: Daniel Jiang <jiangd@vmware.com >
2022-05-05 10:54:34 +08:00
Daniel Jiang
628164668f
Merge pull request #4655 from ywk253100/220214_pod_volume_restore
...
Convert Pod Volume Restore resource/controller to the Kubebuilder framework
2022-05-05 10:33:41 +08:00
Ming
06d3d731ed
Refactor restic repository
...
Signed-off-by: Ming <mqiu@vmware.com >
2022-04-29 10:26:00 +08:00
Daniel Jiang
ad6c5a5ad6
Change the name of UT to be more consistent
...
Signed-off-by: Daniel Jiang <jiangd@vmware.com >
2022-04-28 14:47:37 +08:00
Xun Jiang/Bruce Jiang
001229a8b3
Merge pull request #4855 from reasonerjt/bak-delete-refact
...
Refactor backup deletion controller based on kubebuilder
2022-04-28 10:48:11 +08:00