mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-04-29 20:06:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,137 Commits 52 Branches 180 Tags
b635035d79f4e2fd3960e51d85b9af59dce3b19c
Commit Graph

91 Commits

Author SHA1 Message Date
Priyansh Choudhary
8a6ac7af1c fix: backup deletion silently succeeds when tarball download fails (#9693)
Some checks failed
Run the E2E test on kind / get-go-version (push) Failing after 1m13s
Details
Run the E2E test on kind / build (push) Has been skipped
Details
Run the E2E test on kind / setup-test-matrix (push) Successful in 11s
Details
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Details
Main CI / get-go-version (push) Successful in 13s
Details
Main CI / Build (push) Failing after 34s
Details
Close stale issues and PRs / stale (push) Successful in 14s
Details
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m34s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 1m5s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 1m1s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 1m4s
Details 
* Enhance backup deletion logic to handle tarball download failures and clean up associated CSI VolumeSnapshotContents
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* added changelog
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* Refactor error handling in backup deletion
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* Refactor backup deletion logic to skip CSI snapshot cleanup on tarball download failure
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* prevent backup deletion when errors occur
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* added logger
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
 2026-04-14 16:36:40 -04:00
Lyndon-Li
61238ee0ae issue 9077: don't block backup deletion on list VS error 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2025-07-23 11:32:18 +08:00
Shubham Pampattiwar
a73a150d98 Accommodate VGS workflows in PVC CSI plugin 
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

Add changelog file

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

make update

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

lint fix

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

add unit tests for getVSForPVC func

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

Use v1beta1 instead of v1 v1alpha1

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

go mod tidy

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

update updateVGSCreatedVS func to use retry on conflict

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

make update minor fix

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

fix ut assert

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

Address PR feedback

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

minor updates

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

remove unsused func and add todo for dep upgrades

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
 2025-07-21 11:36:40 -07:00
Xun Jiang
f604a5da48 Add BSL status check for backup/restore operations. 
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-05-30 10:21:32 +08:00
Matthieu MOREL
c6a420bd3a chore: define common aliases for k8s packages (#8672)
Some checks failed
Run the E2E test on kind / build (push) Failing after 6m48s
Details
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Details
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Details
Main CI / Build (push) Failing after 35s
Details
Close stale issues and PRs / stale (push) Successful in 8s
Details
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m11s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 47s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 49s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 43s
Details 
* lchore: define common alias for k8s packages

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update .golangci.yaml

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-04-22 06:14:47 -04:00
Matthieu MOREL
6a6a237ba7 Bump golangci-lint from v1.57.2 to v1.64.5 (#8641)
Some checks failed
Run the E2E test on kind / build (push) Failing after 5m43s
Details
Run the E2E test on kind / setup-test-matrix (push) Successful in 2s
Details
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Details
build-image / Build (push) Failing after 8s
Details
Main CI / Build (push) Failing after 33s
Details 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-03-04 13:55:29 +05:30
Daniel Jiang
1c372893ec Clean up leaked CSI snapshot for incomplete backup 
This commit makes sure when a backup is deleted the controller will
delete the CSI snapshot even when the bakckup tarball is not uploaded.

fixes #8160

Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com>
 2025-01-22 17:17:41 +08:00
Wenkai Yin(尹文开)
0a4e417aab Bump up version of client-go and controller-runtime 
Bump up version of client-go to v0.30.5
Bump up version of controller-runtime to v0.18.5

Fixes #8274

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
 2024-10-08 18:53:12 +08:00
Tiger Kaovilai
3f9c2dc789 Reduces ~140 indirect imports for plugin/framework importers (#8208) 
* Avoid plugin framework importers from needing cloud provider imports

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
 2024-09-13 10:21:51 +08:00
Tiger Kaovilai
c8aa37d852 Remove additional param, use pkg/constant 
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
 2024-09-11 17:13:37 -04:00
Tiger Kaovilai
5c4c66bee9 Add controller name to periodical_enqueue_source 
The code changes are related to the `NewPeriodicalEnqueueSource` function in the `kube/periodical_enqueue_source.go` file. This function is used to create a new instance of the `PeriodicalEnqueueSource` struct, which is responsible for periodically enqueueing objects into a work queue.

The changes involve adding two new parameters to this function: `controllerName string` and modifying the existing `logger` parameter to include additional fields.

Here's what changed:

1. A new `controllerName` parameter was added to the `NewPeriodicalEnqueueSource` function.

These changes are to adding more context or metadata to the logging output, possibly for debugging or monitoring purposes.

The other files (`restore_operations_controller.go`, `schedule_controller.go`, and their respective test files) were modified to use this updated `NewPeriodicalEnqueueSource` function with the new `controllerName` parameter.

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
 2024-09-09 12:07:07 -04:00
Wenkai Yin(尹文开)
dc6eeafe98 Pass Velero server command args to the plugins 
Pass Velero server command args to the plugins

Fixes #7806

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
 2024-09-04 13:43:27 +08:00
Daniel Jiang
5c88c897a5 Patch dbr's status when error happens 
This commit makes sure the dbr's status is "Processed" when an error
happens before the actual deletion is started

fixes #7812

Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com>
 2024-08-06 18:37:34 +08:00
Anshul Ahuja
1a167f9ebf Fail Delete Backup if BSL is not available (#8029) 
* Fail Delete Backup if BSL is not available

Signed-off-by: Anshul Ahuja <anshul.ahu@gmail.com>

* linter

Signed-off-by: Anshul Ahuja <anshul.ahu@gmail.com>

---------

Signed-off-by: Anshul Ahuja <anshul.ahu@gmail.com>
 2024-07-31 10:53:39 -04:00
Matthieu MOREL
a9085033b2 build(deps): bump json-patch to v5.8.0 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-03-29 14:08:33 +00:00
lyndon-li
a2c87fc8b2 Merge pull request #7438 from Lyndon-Li/batch-delete-snapshot 
Issue 7281: batch delete snapshot
 2024-03-27 13:31:07 +08:00
Lyndon-Li
d538fc87ad batch delete snapshot 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-03-27 11:21:51 +08:00
Xun Jiang
efb94ae610 Refactor the native snapshot definition code. 
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
 2024-03-20 15:38:07 +08:00
Wenkai Yin(尹文开)
8752c3a820 Bump up the versions of severel Kubernetes-related libs 
Bump up the versions of severel Kubernetes-related libs

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
 2024-03-05 13:09:38 +08:00
Lyndon-Li
32d92ca964 batch delete snapshot 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-02-18 14:49:21 +08:00
Lyndon-Li
200fd80448 isue 6928: remove snapshot deletion timeout for PVB 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-01-08 11:28:23 +08:00
Xun Jiang
c77bec73bb Move VolumesInformation to an independant package. 
Signed-off-by: Xun Jiang <jxun@vmware.com>
 2023-12-04 08:33:37 +08:00
Xun Jiang
f5c159ce56 Resolve linter issues. 
Signed-off-by: Xun Jiang <jxun@vmware.com>
 2023-11-29 11:15:43 +08:00
Xun Jiang
cddc11e000 Enable linter errchkjson. 
Signed-off-by: Xun Jiang <jxun@vmware.com>
 2023-11-29 11:13:46 +08:00
Yang Gang
e5e99c75a0 Fix dep package describe and ci words spell. (#6924) 
Signed-off-by: yanggang <gang.yang@daocloud.io>
 2023-10-09 12:12:14 +05:30
allenxu404
846f0de178 enhance uninstall and backup deletion for restore finalizer 
Signed-off-by: allenxu404 <qix2@vmware.com>
 2023-08-03 16:43:33 +08:00
Xun Jiang/Bruce Jiang
f666667e5b Merge pull request #6547 from reasonerjt/del-moved-snapshot 
Delete moved snapshots when the backup is deleted
 2023-07-27 15:10:33 +08:00
Daniel Jiang
b0a343cd48 Delete moved snapshots when the backup is deleted 
This commit introduces a deleteItemAction which writes a temporary configmap to
record the snapshot info so that the controller can trigger repo manager
to remove the snapshot

This process is a bit chatty and we should consider to refactor the code
so it's easier to connect to the repo directly in the DIA

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2023-07-27 13:27:33 +08:00
Daniel Jiang
c500e8dc34 Delete the expired deletebackuprequests that are stuck in "InProgress" 
state

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2023-07-10 10:15:19 +08:00
Xun Jiang/Bruce Jiang
15d44724e7 Modify golangci.yaml file. Resolve found lint issues. (#6008) 
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
Co-authored-by: Xun Jiang <blackpiglet@gmail.com>
 2023-03-24 12:15:08 +08:00
杨刚 (成都)
1d8ca4f2ef delete unused parms for UpdateVolumeSnapshotLocationWithCredentialConfig (#5954) 
Signed-off-by: yanggang <gang.yang@daocloud.io>
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
Co-authored-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
 2023-03-15 13:50:54 +08:00
Xun Jiang
41fc641298 Add credential file store in the backup deletion controller. 
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
 2022-10-31 16:59:26 +08:00
Lyndon-Li
c92f06ef17 fix lint loop iterator problem 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2022-10-18 22:40:48 +08:00
Lyndon-Li
d7b4583b2b fix lint errors 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2022-10-18 21:53:47 +08:00
Lyndon-Li
5f7f69366c remove restic from code 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2022-10-13 13:45:32 +08:00
Scott Seago
b6088356e6 plugin versioning v1 refactor for VolumeSnapshotter 
Signed-off-by: Scott Seago <sseago@redhat.com>
 2022-09-21 13:47:23 -04:00
lyndon
0282e65221 Kopia Pod Volume Backup/Restore (#5259) 
* kopia pvbr

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2022-09-05 10:29:30 +08:00
Xun Jiang/Bruce Jiang
6fea973c57 Migrate backup sync controller from code-generator to kubebuilder (#5218) 
* Migrate backup sync controller from code-generator to kubebuilder

1. use kubebuilder's reconcile logic to replace controller's old logic.
2. use ginkgo and gomega to replace testing.
3. modify BSL reconciler registration method.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

* Add Option for PeriodicalEnqueueSource.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
Co-authored-by: Xun Jiang <blackpiglet@gmail.com>
 2022-08-30 16:55:39 +08:00
Wenkai Yin(尹文开)
4a5647a891 Move the code in pkg/restic/common.go to the proper package 
Move the code in pkg/restic/common.go to the proper package

Fixes #5243

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
 2022-08-29 10:04:58 +08:00
Wenkai Yin(尹文开)
047c7531fa Refactor the restic repo related code for Kopia integration 
Refactor the restic repo related code for Kopia integration

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
 2022-08-17 11:49:53 +08:00
Tiger Kaovilai
9a5c3aceff typo initialise -> initialize 
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
 2022-07-18 12:05:10 -04:00
Wenkai Yin(尹文开)
34087fe5f4 Disable status as sub resource in CRDs 
When enabling the status as sub resource in CRD, the status will be ignored when creating the CR with status, this will cause issues when syncing backups/pvbs

Fixes #4950

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
 2022-06-09 07:52:08 +08:00
Daniel Jiang
74fd158a1c Refactor backup deletion controller based on kubebuilder 
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2022-04-27 17:00:54 +08:00
Daniel Jiang
04f59ce003 Bump up to v1 API for CSI snapshot 
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2022-03-31 22:55:03 +08:00
Daniel Jiang
d7aa82d8ed Return the error when getting backup store in backup deletion controller (#4465) 
Per discussion in
https://github.com/vmware-tanzu/velero/issues/4260#issuecomment-947721686
https://github.com/vmware-tanzu/velero/issues/4260#issuecomment-951347384

return the error to avoid a panic when downloading the backup tarball

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
 2021-12-21 05:38:13 +08:00
Kyle William
030104f179 Delete residual file caused by network interruption and so on. Fixes #3204 (#3241) 
Signed-off-by: huangkai <huangkai76@huawei.com>
 2021-06-02 16:41:50 -04:00
Ashish Amarnath
fc8569e9f0 ✨ ⚠️ Remove CSI volumesnapshot artifact deletion (#3734) 
This change is incompatible with velero-plugin-for-csi
releases <= v0.1.2

Remove special casing of CSI volumesnapshot artifacts
from backup deletion logic as this has been moved to
a DeleteItemAction plugin in the velero-plugin-for-csi repo

Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
 2021-05-04 13:58:41 -04:00
Bridget McErlean
38c08e087b Replace NewObjectBackupStore with interface (#3329) 
In preparation for modifying the instantiation of `BackupStores` to be
able to load credentials, change the function `NewObjectBackupStore` to
be an interface that is passed in to all controllers.

Previously, the function to get a new backup store was configurable but
for many controllers was fixed to use `NewObjectBackupStore`. This
change introduces an interface for getting the backup store and wraps
the functionality from `NewObjectBackupStore` in a type which implements
this interface. This will allow more flexibility when introducing
credentials for a specific backup store as it will allow us to create a
new `ObjectBackupStoreGetter` type which can be configured to add
credentials config when creating the ObjectBackupStore without needing
to change the API used by the controllers.

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
 2021-02-08 13:04:08 -05:00
Ron Green
861cc78bcd refactor(external-snapshotter): bump to v4 
Signed-off-by: Ron Green <11993626+georgettica@users.noreply.github.com>
 2021-01-26 13:06:27 +02:00
Bridget McErlean
a877354750 Don't fail backup deletion if downloading tarball fails (#2993) 
* Don't fail backup if downloading tarball fails

Previously, we would always attempt to download the tarball for a backup
for processing DeleteItemAction plugins, even if there weren't any.
This caused an issue for some users in the case where the backup tarball
had been deleted from object storage as the backup deletion would fail.

Now, we only attempt to download the tarball in the case where there are
DeleteItemAction plugins. If downloading that tarball fails, we log
the error, skip the processing of the DeleteItemAction plugins and
proceed with the rest of the deletion.

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>

* Skip file removal in closeAndRemoveFile if nil

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
 2020-11-30 10:58:34 -08:00