Priyansh Choudhary
c8bdf07c3a
Add context logger utilities for enhanced logging support
...
Signed-off-by: Priyansh Choudhary <im1706@gmail.com >
2025-08-08 17:12:46 +05:30
Xun Jiang and Xun Jiang/Bruce Jiang
ec99b50970
Remove the repository maintenance job parameters from velero server.
...
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
2025-08-07 23:25:22 +08:00
Tiger Kaovilai and Claude
35d2cc0890
Add priority class support for Velero server and node-agent
...
- Add --server-priority-class-name and --node-agent-priority-class-name flags to velero install command
- Configure data mover pods (PVB/PVR/DataUpload/DataDownload) to use priority class from node-agent-configmap
- Configure maintenance jobs to use priority class from repo-maintenance-job-configmap (global config only)
- Add priority class validation with ValidatePriorityClass and GetDataMoverPriorityClassName utilities
- Update e2e tests to include PriorityClass testing utilities
- Move priority class design document to Implemented folder
- Add comprehensive unit tests for all priority class implementations
- Update documentation for priority class configuration
- Add changelog entry for #8883
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
remove unused test utils
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
feat: add unit test for getting priority class name in maintenance jobs
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
doc update
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
feat: add priority class validation for repository maintenance jobs
- Add ValidatePriorityClassWithClient function to validate priority class existence
- Integrate validation in maintenance.go when creating maintenance jobs
- Update tests to cover the new validation functionality
- Return boolean from ValidatePriorityClass to allow fallback behavior
This ensures maintenance jobs don't fail due to non-existent priority classes,
following the same pattern used for data mover pods.
Addresses feedback from:
https://github.com/vmware-tanzu/velero/pull/8883#discussion_r2238681442
Refs #8869
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
refactor: clean up priority class handling for data mover pods
- Fix comment in node_agent.go to clarify PriorityClassName is only for data mover pods
- Simplify server.go to use dataPathConfigs.PriorityClassName directly
- Remove redundant priority class logging from controllers as it's already logged during server startup
- Keep logging centralized in the node-agent server initialization
This reduces code duplication and clarifies the scope of priority class configuration.
🤖 Generated with [Claude Code](https://claude.ai/code )
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
refactor: remove GetDataMoverPriorityClassName from kube utilities
Remove GetDataMoverPriorityClassName function and its tests as priority
class is now read directly from dataPathConfigs instead of parsing from
ConfigMap. This simplifies the codebase by eliminating the need for
indirect ConfigMap parsing.
Refs #8869
🤖 Generated with [Claude Code](https://claude.ai/code )
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
refactor: remove priority class validation from install command
Remove priority class validation during install as it's redundant
since validation already occurs during server startup. Users cannot
see console logs during install, making the validation warnings
ineffective at this stage.
The validation remains in place during server and node-agent startup
where it's more appropriate and visible to users.
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Co-Authored-By: Claude <noreply@anthropic.com >
2025-08-06 01:36:22 -04:00
Shubham Pampattiwar
d8f222c83f
Add ConfigMap support for keepLatestMaintenanceJobs
...
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
add changelog file
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
lint fix
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
2025-07-31 16:33:46 -07:00
Xun Jiang/Bruce Jiang and GitHub
770ff142d7
Add imagePullSecrets inheritage for VGDP pod and maintenance job. ( #9096 )
...
Run the E2E test on kind / build (push) Failing after 8m21s
Run the E2E test on kind / setup-test-matrix (push) Successful in 4s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 42s
Close stale issues and PRs / stale (push) Successful in 21s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m49s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 1m17s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 3m30s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 3m12s
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
2025-07-23 13:55:16 -04:00
Lyndon-Li
34f8b73507
bump up kopia to v0.21.1
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-07-22 15:56:04 +08:00
Lyndon-Li
b5502330e5
bump up kopia to v0.21.1
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-07-22 13:40:12 +08:00
Daniel Jiang and GitHub
479c21c58a
Merge pull request #8994 from mmorel-35/usetesting
...
chore: enable usetesting linter
2025-07-11 17:34:30 +08:00
Xun Jiang/Bruce Jiang and GitHub
5ebb055c57
Add UT for maintenance's DeleteOldJobs function. ( #9013 )
...
Unify the k8s.io/api/batch/v1 import alias to bactchv1api.
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
2025-06-26 20:49:26 -04:00
Matthieu MOREL
4089a92147
chore: enable usetesting linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-06-26 08:05:50 +02:00
Jan Jansen and Xun Jiang/Bruce Jiang
81105031a7
copy security context from origin pod
...
Signed-off-by: Jan Jansen <jan.jansen@gdata.de >
2025-06-24 16:17:08 +08:00
Matthieu MOREL
07ea14962c
fix require-error rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-06-23 15:39:54 +00:00
Matthieu MOREL
f42335c8af
fix empty rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-06-22 22:41:08 +02:00
Matthieu MOREL
59825a0506
fix len rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-06-22 22:41:08 +02:00
Lyndon-Li
2e7d11e3b6
bump kopia v0.20.1
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-06-18 13:35:12 +08:00
hu-keyu and GitHub
e06b62e3a8
issue8827: Pass logger in call chain ( #8875 )
...
Run the E2E test on kind / build (push) Failing after 6m42s
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 36s
Close stale issues and PRs / stale (push) Successful in 9s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m4s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 56s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 49s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 57s
* Pass logger in call chain
Signed-off-by: hu-keyu <hzldd999@gmail.com >
2025-04-23 14:44:05 +08:00
Matthieu MOREL and GitHub
c6a420bd3a
chore: define common aliases for k8s packages ( #8672 )
...
Run the E2E test on kind / build (push) Failing after 6m48s
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 35s
Close stale issues and PRs / stale (push) Successful in 8s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m11s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 47s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 49s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 43s
* lchore: define common alias for k8s packages
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update .golangci.yaml
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update .golangci.yaml
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update .golangci.yaml
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
---------
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-04-22 06:14:47 -04:00
Lyndon-Li
f1dcb7ba11
add third party annotation support for maintenance job
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-03-25 13:43:38 +08:00
Lyndon-Li
3c5ebbadd3
issue 8803: use deterministic name to create backupRepository
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-03-24 18:34:33 +08:00
Tiger Kaovilai
178b6e3db5
add more maintenance interval unit tests
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2025-02-21 14:22:11 -06:00
Tiger Kaovilai
3fb8c72b6c
empty string case
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2025-02-20 16:40:49 -06:00
Tiger Kaovilai
92617d07c5
log only if not equal
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2025-02-20 16:40:49 -06:00
Tiger Kaovilai
271ff180e9
lint
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2025-02-20 16:40:48 -06:00
Tiger Kaovilai
21ae1cbe82
Address https://github.com/vmware-tanzu/velero/pull/8581#pullrequestreview-2622445640
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2025-02-20 16:40:48 -06:00
Tiger Kaovilai
3bb39d9331
Address https://github.com/vmware-tanzu/velero/pull/8581#pullrequestreview-2622443771
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2025-02-20 16:40:48 -06:00
Tiger Kaovilai
c153651044
Pass all backupRepoConfig keys to storageVariables, and thus RepoOptions.
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2025-02-20 16:40:48 -06:00
Tiger Kaovilai
5a79e70d79
Configurable Kopia Maintenance Interval
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
comment update
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
comment
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2025-02-20 16:40:48 -06:00
Xun Jiang/Bruce Jiang and GitHub
10a5b7b702
Merge pull request #8624 from mmorel-35/revive/use-any
...
chore: enable use-any from revive
2025-02-07 15:09:05 +08:00
Lyndon-Li
0a4b05cb6e
repo maintenance for windows
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-01-17 19:06:57 +08:00
Matthieu MOREL
cbba3bdde7
chore: enable use-any from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-01-17 07:58:10 +01:00
lyndon-li and GitHub
5b1738abf8
Merge pull request #8580 from Lyndon-Li/recall-repo-maintenance-history-on-restart
...
Run the E2E test on kind / build (push) Failing after 5m31s
Run the E2E test on kind / setup-test-matrix (push) Successful in 2s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 32s
Close stale issues and PRs / stale (push) Successful in 9s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 53s
Trivy Nightly Scan / Trivy nightly scan (velero-restore-helper, main) (push) Failing after 49s
Recall repo maintenance history on restart
2025-01-17 14:08:27 +08:00
Lyndon-Li
91fcb65118
add maintenance wait backoff log
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-01-16 13:38:51 +08:00
Lyndon-Li
0045e94072
get maintenance result only for failed jobs
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-01-15 17:35:12 +08:00
Lyndon-Li
3900f2f117
recall repo maintenance history on restart
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-01-15 15:05:02 +08:00
Lyndon-Li
34c26dd476
avoid to create new repo when BSL is readonly
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-01-14 17:12:46 +08:00
Lyndon-Li
e79dbb8d60
change udmrepo config file location to tmp
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-01-13 15:53:54 +08:00
Lyndon-Li
fc9683688a
move maintenance to a separate folder
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-01-13 10:57:14 +08:00
Lyndon-Li
4ce7361f5a
recall repo maintenance history on restart
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-01-07 12:58:43 +08:00
Lyndon-Li
6b73a256d5
recall repo maintenance history on restart
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-01-06 17:11:03 +08:00
Lyndon-Li
db69829fd7
repo maintenance job out of repo manager
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-01-06 16:25:33 +08:00
Lyndon-Li
912b116bdb
always use job's time
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-01-03 16:50:35 +08:00
Lyndon-Li
6ff0aa32e3
recall existing repo maintenance to history
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-01-02 11:16:46 +08:00
Daniel Jiang and GitHub
eb48cbd60f
Merge pull request #8297 from kaovilai/aws-getbucketregion-hint
...
Run the E2E test on kind / build (push) Failing after 6m8s
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 57s
Close stale issues and PRs / stale (push) Successful in 12s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m16s
Trivy Nightly Scan / Trivy nightly scan (velero-restore-helper, main) (push) Failing after 1m19s
Set hinting region to use for GetBucketRegion() in pkg/repository/config/aws.go
2024-12-11 14:19:11 +08:00
Lyndon-Li
3cd85f5b43
ping kopia to 0.18.2
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-12-03 13:06:26 +08:00
Daniel Jiang and GitHub
a9c9f19368
Merge pull request #8169 from mpryc/aws_creds_exposed
...
Fix #8168 - AWS secrets should not be exposed while running tests
2024-11-18 20:34:05 +08:00
Daniel Jiang and GitHub
e7da6727cf
Merge pull request #8343 from evhan/maintenance-job-env-from
...
Copy "envFrom" from Velero server when creating maintenance jobs
2024-11-18 20:28:44 +08:00
Evan Hanson
70d88901b9
Copy "envFrom" from Velero server when creating maintenance jobs
...
Signed-off-by: Evan Hanson <evanhanson@catalyst.net.nz >
2024-10-30 15:01:59 +13:00
Mikaël Cluseau
e770f0c308
fix(pkg/repository/maintenance): don't panic when there's no container statuses
...
Signed-off-by: Mikaël Cluseau <mikael.cluseau@gmail.com >
2024-10-22 07:07:45 +02:00
Matthieu MOREL
d06601e977
fix: use Contains or ErrorContains with testify
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2024-10-18 20:36:45 +02:00
Tiger Kaovilai
69b456af70
Set hinting region to use for GetBucketRegion() in pkg/repository/config/aws.go
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2024-10-14 10:08:12 -05:00
Priyansh Choudhary
Xun JiangandXun Jiang/Bruce Jiang
Tiger KaovilaiandClaude
Shubham Pampattiwar
Lyndon-Li
Daniel JiangandGitHub
Matthieu MOREL
Jan JansenandXun Jiang/Bruce Jiang
hu-keyuandGitHub
lyndon-liandGitHub
Evan Hanson
Mikaël Cluseau