Shubham Pampattiwar
436c82b977
Add snapshotClass parameter validation
...
Validate the snapshotClass parameter in Action.validate(): it must only
appear on snapshot actions, must be a string, and must not be empty.
Follows the same validation pattern as the dataMover parameter.
Ref: #8807
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
2026-07-24 14:55:43 -07:00
chlins
666d14de32
feat(resourcepolicies): support dataMover parameter in snapshot volume policy action
...
Signed-off-by: chlins <chlins.zhang@gmail.com >
2026-07-15 15:26:23 +08:00
chlins
a191a449fb
feat(resourcepolicies): support PVC volume mode and access mode matching
...
Signed-off-by: chlins <chlins.zhang@gmail.com >
2026-06-15 16:08:38 +08:00
Xun Jiang
49b670a791
Replace github.com/pkg/errors by github.com/cockroachdb/errors
...
Change errors.Cause to errors.Is, because github.com/cockroachdb/errors
New() function create a error with error stack with depth 1, but
github.com/pkg/errors's New() function create error with no depth.
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
2026-06-10 15:55:57 +08:00
Xun Jiang
e15e0af346
Replace gopkg.in/yaml.v3 by go.yaml.in/yaml/v3
...
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
2026-06-10 15:54:17 +08:00
e8fa708933
Add custom action type to volume policies ( #9540 )
...
Run the E2E test on kind / get-go-version (push) Failing after 1m0s
Run the E2E test on kind / build (push) Has been skipped
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / get-go-version (push) Successful in 10s
Main CI / Build (push) Failing after 25s
Close stale issues and PRs / stale (push) Successful in 11s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m34s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 1m3s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 1m3s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 1m13s
* Add custom action type to volume policies
Signed-off-by: Scott Seago <sseago@redhat.com >
* Update internal/resourcepolicies/resource_policies.go
Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com >
Signed-off-by: Scott Seago <sseago@redhat.com >
* added "custom" to validation list
Signed-off-by: Scott Seago <sseago@redhat.com >
* responding to review comments
Signed-off-by: Scott Seago <sseago@redhat.com >
---------
Signed-off-by: Scott Seago <sseago@redhat.com >
Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com >
2026-04-07 10:22:38 -07:00
80211d77e5
feat: Add VolumePolicy support for PVC Phase conditions to allow skipping Pending PVCs
...
This commit implements VolumePolicy support for PVC Phase conditions, resolving
vmware-tanzu/velero#7233 where backups fail with ''PVC has no volume backing this claim''
for Pending PVCs.
Changes made:
- Extended VolumePolicy API to support PVC phase conditions
- Added pvcPhaseCondition struct with matching logic
- Modified getMatchAction() to evaluate policies for unbound PVCs before returning errors
- Added case to GetMatchAction() to handle PVC-only scenarios (nil PV)
- Added comprehensive unit tests for PVC phase parsing and matching
Users can now skip Pending PVCs through volume policy configuration:
apiVersion: v1
kind: ConfigMap
metadata:
name: volume-policy
namespace: velero
data:
policy.yaml: |
version: v1
volumePolicies:
- conditions:
pvcPhase: [Pending]
action:
type: skip
chore: rename changelog file to match PR #9166
Renamed changelogs/unreleased/7233-claude to changelogs/unreleased/9166-claude
to match the opened PR at https://github.com/vmware-tanzu/velero/pull/9166
docs: Add PVC phase condition support to VolumePolicy documentation
- Added pvcPhase field to YAML template example
- Documented pvcPhase as a supported condition in the list
- Added comprehensive examples for using PVC phase conditions
- Included examples for Pending, Bound, and Lost phases
- Demonstrated combining PVC phase with other conditions
Co-Authored-By: Tiger Kaovilai <kaovilai@users.noreply.github.com >
2025-12-22 10:07:05 +07:00
Shubham Pampattiwar and GitHub
0eb1040a0a
Add labels as a criteria for volume policy ( #8713 )
...
Run the E2E test on kind / build (push) Failing after 6m23s
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 38s
Close stale issues and PRs / stale (push) Successful in 9s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m5s
Trivy Nightly Scan / Trivy nightly scan (velero-restore-helper, main) (push) Failing after 55s
* Add labels as a criteria for volume policy
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
add changelog file
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
handle err
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
use labels selector.matches
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
make update
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
remove fetching pvc from volume policy filtering
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
add more ut coverage
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
* minor updates
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
use VolumeFilterData struct in GetMatchAction func
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
update parsePVC func and add more ut
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
lint fix
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
---------
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
2025-02-26 10:02:45 -05:00
Matthieu MOREL
cbba3bdde7
chore: enable use-any from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-01-17 07:58:10 +01:00
074f26539d
Adding Support For VolumeAttributes in Resource Policy ( #8383 )
...
Run the E2E test on kind / build (push) Failing after 10m15s
Run the E2E test on kind / setup-test-matrix (push) Successful in 1m15s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 4m47s
Close stale issues and PRs / stale (push) Failing after 11m58s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 11m40s
Trivy Nightly Scan / Trivy nightly scan (velero-restore-helper, main) (push) Failing after 14m53s
* Adding VolumeAttributes validations in resource policy
Signed-off-by: mayaggar <mayaggar@microsoft.com >
* adding tests
Signed-off-by: mayaggar <mayaggar@microsoft.com >
* adding tests
Signed-off-by: mayaggar <mayaggar@microsoft.com >
* adding tests
Signed-off-by: mayaggar <mayaggar@microsoft.com >
* added changelog
Signed-off-by: mayaggar <mayaggar@microsoft.com >
* changelog
Signed-off-by: mayaggar <mayaggar@microsoft.com >
* design spec
Signed-off-by: mayaggar <mayaggar@microsoft.com >
* lint fixes
Signed-off-by: mayaggar <mayaggar@microsoft.com >
* doc update
Signed-off-by: mayaggar <mayaggar@microsoft.com >
* doc update
Signed-off-by: mayaggar <mayaggar@microsoft.com >
* Update internal/resourcepolicies/volume_resources_validator.go
Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com >
Signed-off-by: Mayank Aggarwal <mayankagg9722@gmail.com >
* doc name update
Signed-off-by: mayaggar <mayaggar@microsoft.com >
---------
Signed-off-by: mayaggar <mayaggar@microsoft.com >
Signed-off-by: Mayank Aggarwal <mayankagg9722@gmail.com >
Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com >
2024-11-28 10:17:07 +05:30
Shubham Pampattiwar
8d2bef2486
Extend Volume Policies feature to support more actions
...
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
fix volume policy action execution
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
remove unused files
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
add changelog file
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
fix CI linter errors
fix linter errors
address pr review comments
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
fix via make update cmd
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
address PR feedback and add tests
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
fix codespell
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
fix ci linter checks
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
remove volsToExclude processing from volume policy logic and add tests
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
fix ci linter issue
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
2024-04-23 12:54:14 -07:00
qiuming and GitHub
5ff5073cc3
Add volume types filter in resource policies ( #6863 )
...
Signed-off-by: Ming Qiu <mqiu@vmware.com >
2023-10-16 17:36:54 -04:00
yanggang
11745809c4
Add missing file licences and do some clean works.
...
Signed-off-by: yanggang <gang.yang@daocloud.io >
2023-09-29 04:25:01 +01:00
1fd28e8a36
Fix usestdlibvars and whitespace linters issues. ( #6162 )
...
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
Co-authored-by: Xun Jiang <blackpiglet@gmail.com >
2023-04-24 09:10:55 +08:00
Ming
a3cef5b0d3
Adjust match resource policies
...
Signed-off-by: Ming <mqiu@vmware.com >
2023-03-23 03:48:26 +00:00
qiuming and GitHub
086dbd344f
Handle backup of volume by resource policies ( #5901 )
...
* Handle backup of volume by resource policies
Signed-off-by: Ming <mqiu@vmware.com >
2023-03-21 14:39:25 +08:00