mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-09-13 11:34:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,823 Commits 98 Branches 187 Tags
e8af012ac574dea895affc2ff45e82ca0e08098e
Commit Graph
12 Commits
Author SHA1 Message Date
chlinsandgithub-actions[bot] 0f86521735 Verify extracted item paths stay inside the backup directory 
archive.GetItemFilePath/GetVersionedItemFilePath joined the group resource,
namespace and name into a path without checking the result against rootDir.
Those components can come from backup contents - the additional items a
RestoreItemAction returns are built from annotations on a backed up object -
so a component containing ".." resolved to an arbitrary file on the Velero
pod, which was then Stat'd, unmarshalled and restored as a Kubernetes object.

Both helpers now return an error when the joined path escapes rootDir, and all
callers handle it. rootDir is empty when building an entry path inside the
backup tarball, so "." is used as the containment base for that relative form.

Signed-off-by: chlins <chlins.zhang@gmail.com>
 2026-07-31 06:02:43 +00:00
Chlins ZhangandGitHub c825e3c136 fix(delete): surface DeleteItemAction plugin errors from InvokeDeleteActions (#9993)
Run the E2E test on kind / get-go-version (push) Failing after 56s
Details
Run the E2E test on kind / build (push) Has been skipped
Details
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Details
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Details
Main CI / get-go-version (push) Successful in 11s
Details
Main CI / Build (push) Failing after 21s
Details 
Signed-off-by: chlins <chlins.zhang@gmail.com>
 2026-07-13 14:51:54 -07:00
Xun Jiang 49b670a791 Replace github.com/pkg/errors by github.com/cockroachdb/errors 
Change errors.Cause to errors.Is, because github.com/cockroachdb/errors
New() function create a error with error stack with depth 1, but
github.com/pkg/errors's New() function create error with no depth.

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2026-06-10 15:55:57 +08:00
Xun Jiang 908e2c63ba Check whether the action is a CSI action and whether CSI feature is 
enabled, before executing the action.

The DeleteItemAction is not checked, because the DIA doesn't have a
method to get the action's plugin name.
This should be OK, because the CSI will check whether the VS and VSC
have a backup name annotation. If the VS and VSC is not handled by
the CSI plugin, then they don't have the annotation.

Signed-off-by: Xun Jiang <jxun@vmware.com>
 2023-10-24 16:54:38 +08:00
Xun Jiang f051ecaee9 Enable errcheck linter and resolve found issues. 
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
 2023-04-28 09:33:42 +08:00
Xun Jiang/Bruce JiangGitHubXun Jiang
 		1fd28e8a36 Fix usestdlibvars and whitespace linters issues. (#6162) 
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
Co-authored-by: Xun Jiang <blackpiglet@gmail.com>
 2023-04-24 09:10:55 +08:00
Scott Seago e3e2a8dfa0 plugin/framework refactoring for BackupItemAction v1 
Refactors the framework  package to implement the plugin versioning changes
needed for BIA v1 and overall package refactoring to support plugin versions
in different packages. This should be all that's needed to move on to
v2 for BackupItemAction. The remaining plugin types still need similar
refactoring to what's being done here for BIA before attempting a
v2 implementation.

Signed-off-by: Scott Seago <sseago@redhat.com>
 2022-09-15 11:15:30 -04:00
I538157andYuval Manor 74db20993b fix: delete empty backups 
Signed-off-by: Yuval Manor <yuvalman958@gmail.com>
 2022-04-12 13:13:56 +03:00
Wenkai Yin(尹文开)andGitHub 72fc1d2c0b Parse resource from backup tarball directly rather than resolving it via discovery service to avoid #4009 (#4398) 2021-12-21 19:28:55 +08:00
David L. Smith-UchidaandGitHub 5677e04bb1 Consolidated code for resolving actions and plugins into ActionResolver (#4410) 
* Consolidated code for resolving actions and plugins into ActionResolver.  Added BackupWithResolvers and
RestoreWithResolvers.  Introduces ItemSnapshooterResolver to bring ItemSnapshotter plugins into backup and
restore.  ItemSnapshotters are not used yet.

Added action_resolver_test

Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>

* Addressed review comments

Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
 2021-12-10 12:53:47 -05:00
Lars LehtonenandGitHub 15d7a9dfb6 internal/delete: fix dropped error (#4016) 
Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com>
 2021-08-18 15:02:41 +08:00
Nolan BrubakerandGitHub 718a94ad05 Invoke DeleteItemActions on backup deletion (#2815) 
* Add serving and listing support

Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
 2020-08-20 17:24:29 -07:00