mirrors/velero
1
0
Fork 0
mirror of https://github.com/vmware-tanzu/velero.git synced 2026-09-18 22:14:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,823 Commits 102 Branches 187 Tags
e8af012ac574dea895affc2ff45e82ca0e08098e
Commit Graph
39 Commits
Author SHA1 Message Date
R4mboandGitHub c20b09e281 fix nil pointer dereference in WaitUntilVSCHandleIsReady when a VSC error has no message (#10352) 
* fix nil pointer dereference in WaitUntilVSCHandleIsReady when a VSC error has no message

Signed-off-by: samay43 <samayrbhat43@gmail.com>

* add changelog entry

Signed-off-by: samay43 <samayrbhat43@gmail.com>

---------

Signed-off-by: samay43 <samayrbhat43@gmail.com>
 2026-08-21 15:11:09 -04:00
R4mboandGitHub b8de7ba506 fix nil pointer dereference in EnsureDeleteVS and EnsureDeleteVSC timeout paths (#10292) 
* fix nil pointer dereference in EnsureDeleteVS and EnsureDeleteVSC timeouts

Signed-off-by: samay43 <samayrbhat43@gmail.com>

* add changelog entry

Signed-off-by: samay43 <samayrbhat43@gmail.com>

---------

Signed-off-by: samay43 <samayrbhat43@gmail.com>
 2026-08-17 16:55:14 +08:00
Krishna AwasthiandGitHub 41b95b5919 Refactor: Replace context.TODO() with properly plumbed contexts in CSI actions (#10247) 
Signed-off-by: opbot_xd <awasthikrishna23052005@gmail.com>
 2026-08-14 16:17:29 +08:00
Shubham Pampattiwar 9eaefe7908 Add volume policy tier to VolumeSnapshotClass selection 
Add GetVolumeSnapshotClassFromVolumePolicy helper and extend
GetVolumeSnapshotClass with a policySnapshotClass parameter. The new
tier sits between PVC annotation and backup annotation in the priority
chain: PVC annotation > volume policy > backup annotation > VSC label.

Ref: #8807

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
 2026-07-24 14:55:43 -07:00
Scott Seagoandaider c60a5bcc7c feat: Implement early frequent polling for CSI snapshots 
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat>
Signed-off-by: Scott Seago <sseago@redhat.com>
 2026-07-01 11:56:48 -04:00
Scott Seagoandaider fa20e46016 refactor: Optimize VSC handle readiness polling for VSS backups 
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat>
Signed-off-by: Scott Seago <sseago@redhat.com>
 2026-07-01 11:00:18 -04:00
Xun Jiang 49b670a791 Replace github.com/pkg/errors by github.com/cockroachdb/errors 
Change errors.Cause to errors.Is, because github.com/cockroachdb/errors
New() function create a error with error stack with depth 1, but
github.com/pkg/errors's New() function create error with no depth.

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2026-06-10 15:55:57 +08:00
Nolan EmirotGitHubPriyansh ChoudharynolanemirotLyndon-LiDaniel Jiang
 		fc6361ba06 perf: better string concatenation (#9705) 
* perf: better string concatenation

Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: nolanemirot <nolan.emirot@broadcom.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>

* fix: backup deletion silently succeeds when tarball download fails (#9693)

* Enhance backup deletion logic to handle tarball download failures and clean up associated CSI VolumeSnapshotContents
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* added changelog
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* Refactor error handling in backup deletion
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* Refactor backup deletion logic to skip CSI snapshot cleanup on tarball download failure
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* prevent backup deletion when errors occur
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* added logger
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>

* perf: better string concatenation

Signed-off-by: emirot <emirot.nolan@gmail.com>

* Add delay to avoid race conditions during VolumeSnapshotContent deletion (#9700)

* Add delay to avoid race conditions during VolumeSnapshotContent deletion
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* updated changelog
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

* Updated Changelog
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>

* block data mover design

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>

* block data mover design

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>

* irregular volume size

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>

* block data mover design

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>

* Update the "community" page of website (#9722)

Update the community page to add the correct links to community meeting
and meeting notes.
I also removed the referece of google group as I confirmed the last
message was sent 2 years ago.

Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>

* perf: better string concatenation

Signed-off-by: emirot <emirot.nolan@gmail.com>

---------

Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: nolanemirot <nolan.emirot@broadcom.com>
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com>
Co-authored-by: Priyansh Choudhary <im1706@gmail.com>
Co-authored-by: nolanemirot <nolan.emirot@broadcom.com>
Co-authored-by: Lyndon-Li <lyonghui@vmware.com>
Co-authored-by: Daniel Jiang <daniel.jiang@broadcom.com>
 2026-04-16 02:56:25 -04:00
lyndon-liandGitHub e6aab8ca93 add events to diagnose (#9296)
Run the E2E test on kind / get-go-version (push) Failing after 1m10s
Details
Run the E2E test on kind / build (push) Has been skipped
Details
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Details
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Details
Main CI / get-go-version (push) Failing after 16s
Details
Main CI / Build (push) Has been skipped
Details
Close stale issues and PRs / stale (push) Successful in 11s
Details
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m43s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 1m5s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 1m2s
Details
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 1m2s
Details 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2025-10-09 14:13:43 -04:00
weeixandTiger Kaovilai 80da461458 clarify VolumeSnapshotClass error for mismatched driver/provisioner 
Signed-off-by: weeix <weeix@users.noreply.github.com>
 2025-09-02 18:31:13 -05:00
Xun Jiang c84aab7f6f Remove the WaitUntilVSCHandleIsReady from vs BIA. 
Becasue the pvc BIA already run WaitUntilVSCHandleIsReady,
no need to do the same work in vs BIA.

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-07-31 15:35:05 +08:00
Xun JiangandXun Jiang/Bruce Jiang a61a073aea Avoid checking the VS and VSC status in the backup finalizing phase. 
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-07-24 13:28:05 +08:00
Shubham Pampattiwar a73a150d98 Accommodate VGS workflows in PVC CSI plugin 
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

Add changelog file

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

make update

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

lint fix

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

add unit tests for getVSForPVC func

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

Use v1beta1 instead of v1 v1alpha1

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

go mod tidy

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

update updateVGSCreatedVS func to use retry on conflict

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

make update minor fix

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

fix ut assert

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

Address PR feedback

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

minor updates

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

remove unsused func and add todo for dep upgrades

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
 2025-07-21 11:36:40 -07:00
Xun Jiang 1b7175394a Skip VS and VSC not created by backup. 
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-06-07 10:51:05 +08:00
hu-keyuandGitHub 5160f96c2e issue8294: inherit k8s default volumeSnapshotClass (#8721)
Run the E2E test on kind / build (push) Failing after 7m33s
Details
Run the E2E test on kind / setup-test-matrix (push) Successful in 2s
Details
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Details
Main CI / Build (push) Failing after 38s
Details 
* inherit k8s default volumeSnapshotClass

Signed-off-by: hu-keyu <hzldd999@gmail.com>

* add doc change for issue8294

Signed-off-by: hu-keyu <hzldd999@gmail.com>

---------

Signed-off-by: hu-keyu <hzldd999@gmail.com>
 2025-04-07 12:21:13 +05:30
Xun Jiang 6b7dd12bf7 Modify VS and VSC restore actions. 
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-02-25 10:44:45 +08:00
Xun Jiang eb77151f48 Delete VSC after backup completes. 
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
 2025-02-19 14:36:59 +08:00
Matthieu MOREL ae5e94e822 chore: enable increment-decrement from revive 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-02-07 20:58:39 +01:00
Daniel Jiang 1c372893ec Clean up leaked CSI snapshot for incomplete backup 
This commit makes sure when a backup is deleted the controller will
delete the CSI snapshot even when the bakckup tarball is not uploaded.

fixes #8160

Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com>
 2025-01-22 17:17:41 +08:00
Wenkai Yin(尹文开)andGitHub 0224d99889 Merge pull request #8482 from Lyndon-Li/data-mover-exposer-diagnostic
Run the E2E test on kind / build (push) Failing after 6m17s
Details
Run the E2E test on kind / setup-test-matrix (push) Successful in 5s
Details
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Details
Main CI / Build (push) Failing after 1m3s
Details
Close stale issues and PRs / stale (push) Has started running
Details
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Has started running
Details
Trivy Nightly Scan / Trivy nightly scan (velero-restore-helper, main) (push) Has started running
Details 
Data mover exposer diagnostic
 2024-12-13 14:28:37 +08:00
Lyndon-Li 8b545532e2 issue 8267: add informative logs when expose error 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-12-12 11:19:26 +08:00
Lyndon-Li b607259563 add diagnostic for data mover exposer 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-12-04 14:49:58 +08:00
Lyndon-Li e4e9b18b37 add diagnostic for data mover exposer 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-12-04 10:28:50 +08:00
Wenkai Yin(尹文开) 23ca089d40 Use '"' rather than '`' in the log to avoid unexpected new line 
Use '"' rather than '`' in the log to avoid unexpected new line

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
 2024-10-09 14:44:13 +08:00
Xun Jiang d3cc42d577 Change the timeout handling code due to third-party package change 
The wait error changed from `timed out waiting for the condition`
to `context deadline exceeded`.

Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
 2024-04-13 23:27:02 +08:00
Xun Jiang 30995bcbd2 Add more UT for the CSI plugins. 
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
 2024-04-13 23:22:43 +08:00
Lyndon-Li 61061d5c83 issue 7648: merge main 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-04-12 10:18:02 +08:00
Lyndon-Li bf03938dd2 issue 7648: don't leak snapshot on failure 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2024-04-11 19:23:57 +08:00
Xun Jiang/Bruce JiangandGitHub 8df4e6aded Merge branch 'main' into merge_csi 
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
 2024-04-10 18:54:16 +08:00
Xun Jiang 31e140919a Merge CSI plugin code. 
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
 2024-04-10 14:53:29 +08:00
Matthieu MOREL a9085033b2 build(deps): bump json-patch to v5.8.0 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2024-03-29 14:08:33 +00:00
Wenkai Yin(尹文开) 8752c3a820 Bump up the versions of severel Kubernetes-related libs 
Bump up the versions of severel Kubernetes-related libs

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
 2024-03-05 13:09:38 +08:00
Lyndon-Li 067984b13c Issue 7068: add a finalizer to protect retained VSC 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-11-15 16:04:07 +08:00
Lyndon-Li cb651d0436 issue 7068: add a finalizer to protect retained VSC 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-11-14 10:18:07 +08:00
Lyndon-Li 53489b10ad issue 6786:always delete VSC regardless of the deletion policy 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-09-15 12:10:20 +08:00
Lyndon-Li b90c5bba3d continue wait on csi snapshot error 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-08-10 11:34:26 +08:00
Lyndon-Li 22c88ba330 data mover fail earlier for snapshot creation error 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-08-08 12:05:56 +08:00
Lyndon-Li 217b1dd066 add UT for pkg/util 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-06-08 14:00:58 +08:00
Lyndon-Li 25624d3030 data mover backup expose 
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
 2023-06-02 11:51:36 +08:00