Emily McMullan
ec4a7072b3
add server setting for default timeouts
...
Signed-off-by: Emily McMullan <emcmulla@redhat.com >
2023-03-10 10:15:09 -05:00
Xun Jiang/Bruce Jiang
7d7e3fff0d
Refoctor backup controller with controller-runtime. ( #5969 )
...
Signed-off-by: Ming <mqiu@vmware.com >
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
Co-authored-by: Ming <mqiu@vmware.com >
2023-03-10 08:59:40 +08:00
Xun Jiang/Bruce Jiang
6d8f086283
Merge pull request #5956 from Lyndon-Li/issue-fix-5935
...
Fix issue 5935
2023-03-09 15:28:47 +08:00
Lyndon-Li
40aae5ebdd
fix issue 5935
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2023-03-09 14:24:51 +08:00
Scott Seago
c3d1d83da5
BIAv2 async operations controller work
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2023-03-01 11:49:17 -05:00
Zhizhen He
fb1dc110f2
Replace k8s.io/apimachinery/pkg/util/clock with k8s.io/utils/clock
...
Signed-off-by: Zhizhen He <hezhizhen.yi@gmail.com >
2023-02-21 11:56:17 +08:00
Scott Seago
fa58a775e8
Merge pull request #5576 from anshulahuja98/backupresults
...
Publish backup results to enhance error info
2023-02-18 17:00:49 -05:00
Anshul Ahuja
8c3ddf0f73
Publish backup results extracted from backup logs
...
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com >
2023-02-16 09:57:53 +05:30
allenxu404
a5a165b0c3
add prometheus metrics to record warning total and last status of backups
...
Signed-off-by: allenxu404 <qix2@vmware.com >
2023-01-30 15:40:59 +08:00
Scott Seago
9a54142257
BackupItemAction v2 API implementation
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2023-01-09 18:36:47 -05:00
lyndon
cc9d492479
Merge pull request #5485 from Obmondo/fix/error-message
...
Fix pointer deference to string in error message
2022-11-04 14:15:56 +08:00
Xun Jiang/Bruce Jiang
150570feec
Remove redundancy code block left by #5388 . ( #5483 )
...
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
2022-10-27 14:20:26 +08:00
Faizan Ahmad
9d01432007
Fix pointer deference to string in error message
...
Signed-off-by: Faizan Ahmad <faizan@obmondo.com >
2022-10-25 07:52:00 +05:30
Xun Jiang/Bruce Jiang
5027aae194
Add more nil pointer check for CSI related code in backup controller. ( #5388 )
...
Add some corner cases checking for CSI snapshot in backup controller.
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
2022-10-24 10:42:08 +08:00
lyndon
162680b39c
Merge branch 'main' into velero-docker-image-go-1.18
...
Signed-off-by: lyndon <98304688+Lyndon-Li@users.noreply.github.com >
2022-10-19 09:29:36 +08:00
Shubham Pampattiwar
34cca77533
Add nil check before execution of csi snapshot delete
...
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
add changelog
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
2022-10-18 11:51:55 -04:00
Lyndon-Li
d7b4583b2b
fix lint errors
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2022-10-18 21:53:47 +08:00
Xun Jiang/Bruce Jiang
9cb46deb73
Add CSI VolumeSnapshot client back. ( #5449 )
...
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
2022-10-18 14:58:03 +08:00
Xun Jiang/Bruce Jiang
ce247a3d90
Remove snapshot related lister, informer and client from backup controller. ( #5299 )
...
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
2022-09-23 15:44:39 +08:00
lyndon
c81f0db886
rename pvbr param ( #5370 )
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2022-09-23 09:13:36 +08:00
lyndon
ede7b197ae
Merge pull request #5297 from blackpiglet/remove_apex_log
...
Remove github.com/apex/log logger.
2022-09-16 16:47:36 +08:00
Scott Seago
596114b427
Add credentials to volume snapshot locations.
...
This is analogous to the BSL creds work that was done previously, but for VSLs instead.
Signed-off-by: Scott Seago <sseago@redhat.com >
2022-09-08 08:59:17 -04:00
Xun Jiang
b49e39c021
Remove github.com/apex/log logger.
...
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
2022-09-07 08:52:16 +08:00
李龙峰
5cddaeae6c
check vsc null pointer
...
Signed-off-by: 李龙峰 <lilongfeng@inspur.com >
2022-08-22 14:44:17 +08:00
Xun Jiang/Bruce Jiang
a5f4f8f9fc
Merge branch 'main' into 5048-CSI-snapshot-timeout-configurable
2022-08-08 17:18:44 +08:00
Xun Jiang
f8d9cfdb84
Make CSI snapshot creation timeout configurable for backup and schedule.
...
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-08-08 17:07:26 +08:00
allenxu404
e5d828a2a4
modify variables defination and expose err
...
Signed-off-by: allenxu404 <qix2@vmware.com >
2022-08-08 12:05:08 +08:00
allenxu404
eb08bdeb62
fix issue#2413 by treating namespaces with exclude label as excludedNamespaces
...
Signed-off-by: allenxu404 <qix2@vmware.com >
2022-08-04 20:00:11 +08:00
Wenkai Yin(尹文开)
c3a32a116f
Merge pull request #4976 from reasonerjt/vsc-policy-reset-undo
...
Undo setting the VSC's deletion policy during backup
2022-06-10 09:12:46 +08:00
Daniel Jiang
f5649bcc1f
Undo setting the VSC's deletion policy during backup
...
It's not necessary to set the deletion policy as the delete item action
plugin in CSI plugin will set it to Delete when the backup is deleted.
Signed-off-by: Daniel Jiang <jiangd@vmware.com >
2022-06-09 16:26:05 +08:00
Wenkai Yin(尹文开)
34087fe5f4
Disable status as sub resource in CRDs
...
When enabling the status as sub resource in CRD, the status will be ignored when creating the CR with status, this will cause issues when syncing backups/pvbs
Fixes #4950
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2022-06-09 07:52:08 +08:00
Wenkai Yin(尹文开)
6fa4d7d606
Mark in-progress CRs as failed when starting the server
...
Mark in-progress CRs as failed when starting the server
Fixes #4953
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2022-06-07 17:02:17 +08:00
Shubham Pampattiwar
bfdb68a35a
add multiple label selector support to backup API
...
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
remove backup CLI bits
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
labelselectors spec option for velero restore
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
add changelog file
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
update spec name to OrLabelSelectors
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
minor fixes
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
add validations for labelSelector and orLabelSelectors
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
update crds.gp after fixing conflicts
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
fix CI and add unit tests
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
updated OrLabelSelector spec description and added validation failure unit tests
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
add comments and change log level
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
update site docs
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
wrap pager client calls in a function
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
resolve confilcts and update crds.go
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
rebase and update crds.go
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
combine listing items for a given label
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
2022-05-11 09:57:47 -04:00
Xun Jiang
a69bd8b1f3
Remove VolumeSnapshot created during backup, when the VolumeSnapshotClass's DeletionPolicy is set to Delete.
...
1. Delete VolumeSnapshot directly when DeletionPolicy set to Retain.
2. Change VolumeSnapshotContent's DeletionPolicy to Retain, then delete VolumeSnapshot. After that delete VolumeSnapshotContent and change VSC DeletionPolicy to Delete back, then re-create the VolumeSnapshotContent.
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-05-05 18:30:59 +08:00
Xun Jiang
6421f8ad02
Make waiting VolumeSnapshot to ready process parallel.
...
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-05-05 14:32:55 +08:00
Daniel Jiang
89e90d9be4
Delete orphan CSI snapshots in backup sync controller
...
This commit makes backup sync controller delete the volumesnapshot and
volumesnapshotcontent created by the backup which is cleaned up as orphan
Signed-off-by: Daniel Jiang <jiangd@vmware.com >
2022-05-05 10:54:34 +08:00
Scott Seago
58a8371ca2
Merge pull request #4833 from ywk253100/220413_restart
...
Make in-progress backup/restore as failed when doing the reconcile
2022-04-27 11:45:01 -04:00
Wenkai Yin(尹文开)
dfc86566b8
Make in-progress backup/restore as failed when doing the reconcile
...
Make in-progress backup/restore as failed when doing the reconcile to avoid hanging in in-progress status
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2022-04-26 11:05:03 +08:00
Xun Jiang
22dd0b2ebb
Modify CSI VolumeSnapshot metric related code.
...
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-04-23 12:59:56 +08:00
Wenkai Yin(尹文开)
9e786d681b
Merge pull request #4832 from reasonerjt/fix-rm-csi-bak-tmp
...
Make the vsc created by backup sync controller deletable
2022-04-20 17:19:09 +08:00
Daniel Jiang
4f9e445142
Make the vsc created by backup sync controller deletable
...
Fixes #4760
This commit make changes in 2 parts:
1) When a volumesnapshotcontent is persisted during backup, velero will reset its
`Source` field to remove the VolumeHandle, so that the
csi-snapshotter will not try to call `CreateSnapshot` when its synced
to another cluster with a backup.
2) Make sure the referenced volumesnapshotclasses are persisted and
synced with the backup, so that when the volumesnapshotcontent is
deleted the storage snapshot is also removed.
Signed-off-by: Daniel Jiang <jiangd@vmware.com >
2022-04-19 15:06:59 +08:00
qiuming
9373c8a383
Merge pull request #4818 from blackpiglet/2499-add-metric-for-csi-snapshot
...
Add CSI VolumeSnapshot related metrics.
2022-04-15 16:55:37 +08:00
Xun Jiang
9aa4e9e860
Update according to comments. Remove csiVolumeSnapshotsStorageTotal related code.
...
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-04-15 08:05:56 +00:00
Xun Jiang
4daeec7ab9
Update CRD and GRPC.
...
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-04-09 12:35:09 +00:00
Xun Jiang
368a1ddf3c
Add CSI VolumeSnapshot related metrics.
...
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-04-09 00:57:28 +08:00
Daniel Jiang
7c40949992
Merge pull request #4800 from reasonerjt/bump-up-csi-to-v1
...
Bump up to v1 API for CSI snapshot
2022-04-01 13:46:00 +08:00
Daniel Jiang
04f59ce003
Bump up to v1 API for CSI snapshot
...
Signed-off-by: Daniel Jiang <jiangd@vmware.com >
2022-03-31 22:55:03 +08:00
Scott Seago
8e4f88db68
Merge pull request #4295 from mercedes-benz/tobiasgiese/items-metrics
...
Add metrics backup_items_total and backup_items_errors
2022-03-25 16:40:43 -04:00
Tobias Giese
1b8da68fc2
metrics: add items gauges
...
Signed-off-by: Tobias Giese <tobias.giese@daimler.com >
2022-03-22 18:36:55 +01:00
David L. Smith-Uchida
5677e04bb1
Consolidated code for resolving actions and plugins into ActionResolver ( #4410 )
...
* Consolidated code for resolving actions and plugins into ActionResolver. Added BackupWithResolvers and
RestoreWithResolvers. Introduces ItemSnapshooterResolver to bring ItemSnapshotter plugins into backup and
restore. ItemSnapshotters are not used yet.
Added action_resolver_test
Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com >
* Addressed review comments
Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com >
2021-12-10 12:53:47 -05:00