49b670a791
Replace github.com/pkg/errors by github.com/cockroachdb/errors
...
Change errors.Cause to errors.Is, because github.com/cockroachdb/errors
New() function create a error with error stack with depth 1, but
github.com/pkg/errors's New() function create error with no depth.
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
2026-06-10 15:55:57 +08:00
dda779de65
Reject restores from backups not in a completed or partially failed phase ( #9792 )
...
Run the E2E test on kind / get-go-version (push) Failing after 1m3s
Run the E2E test on kind / build (push) Has been skipped
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
build-image / Build (push) Failing after 16s
Main CI / get-go-version (push) Successful in 12s
Main CI / Build (push) Failing after 36s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m41s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 1m25s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 1m18s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 1m17s
Close stale issues and PRs / stale (push) Has started running
* Add phase check validations in restore controller
Signed-off-by: subhramit <subhramit.bb@live.in >
* Adapt existing tests
Signed-off-by: subhramit <subhramit.bb@live.in >
* Add tests
Signed-off-by: subhramit <subhramit.bb@live.in >
* Update doc
Signed-off-by: subhramit <subhramit.bb@live.in >
* Add changelog
Signed-off-by: Subhramit Basu <subhramit.bb@live.in >
* Update pkg/controller/restore_controller_test.go
Signed-off-by: Subhramit Basu <subhramit.bb@live.in >
---------
Signed-off-by: subhramit <subhramit.bb@live.in >
Signed-off-by: Subhramit Basu <subhramit.bb@live.in >
2026-06-08 16:10:32 -04:00
dd82645909
Fix PodVolumeBackup list scope during restore
...
Restrict the listing of PodVolumeBackup resources to the specific
restore namespace in both the core restore controller and the pod
volume restore action plugin. This prevents "Forbidden" errors when
Velero is configured with namespace-scoped minimum privileges,
avoiding the need for cluster-scoped list permissions for
PodVolumeBackups.
Fixes : #9681
Signed-off-by: Adam Zhang <adam.zhang@broadcom.com >
2026-04-08 16:50:09 +08:00
f604a5da48
Add BSL status check for backup/restore operations.
...
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
2025-05-30 10:21:32 +08:00
6a6a237ba7
Bump golangci-lint from v1.57.2 to v1.64.5 ( #8641 )
...
Run the E2E test on kind / build (push) Failing after 5m43s
Run the E2E test on kind / setup-test-matrix (push) Successful in 2s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
build-image / Build (push) Failing after 8s
Main CI / Build (push) Failing after 33s
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-03-04 13:55:29 +05:30
a3cee616dc
Upgrade go.mod k8s.io/ go.mod to v0.31.3 and set klog.SetLogger() for client-go ( #8450 )
...
Run the E2E test on kind / build (push) Failing after 5m44s
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
build-image / Build (push) Failing after 10s
Main CI / Build (push) Failing after 31s
Close stale issues and PRs / stale (push) Successful in 7s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 59s
Trivy Nightly Scan / Trivy nightly scan (velero-restore-helper, main) (push) Failing after 45s
Also bumped to support upgraded k8s.io/ deps.
- controller-gen to v0.16.5
- sigs.k8s.io/controller-runtime v0.19.2
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2025-02-17 15:05:10 -05:00
1e54f1cb15
chore: enable var-declaration from revive ( #8636 )
...
Run the E2E test on kind / build (push) Failing after 5m28s
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 33s
Close stale issues and PRs / stale (push) Successful in 8s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 52s
Trivy Nightly Scan / Trivy nightly scan (velero-restore-helper, main) (push) Failing after 56s
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-01-22 15:56:44 -05:00
74790d9f60
Added tracking for deleted namespace status check in restore flow ( #8233 )
...
* Added tracking for deleted namespace status check in restore flow
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com >
fixed unittest
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com >
refactored tracker execution and caller
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com >
added change log
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com >
Author: sangitaray2021 <sangitaray@microsft.com >
Author: sangitaray2021 <sangitaray@microsoft.com >
Date: Thu Sep 19 02:26:14 2024 +0530
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com >
* fixed linter issuer
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com >
* incorporated PR comments
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com >
* resolved comments
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com >
---------
Signed-off-by: sangitaray2021 <sangitaray@microsoft.com >
2024-11-18 13:41:07 +05:30
c643ee5fd4
Retry completion status patch for backup and restore resources
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
update to design #8063
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2024-09-10 17:01:14 -04:00
3c937d42dd
ignore .git dir when formatting
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2024-05-10 14:12:29 -04:00
e1bef5b6c2
Add existingResourcePolicy restore CR validation to controller.
...
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
2024-05-01 11:39:03 -04:00
0a280e5786
Track and persist restore volume info
...
Signed-off-by: Daniel Jiang <jiangd@vmware.com >
2024-04-11 17:32:18 +08:00
efb94ae610
Refactor the native snapshot definition code.
...
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com >
2024-03-20 15:38:07 +08:00
2b8bb871d3
Add the finalization phase to the restore workflow
...
Signed-off-by: allenxu404 <qix2@vmware.com >
2024-02-29 13:51:45 +08:00
28df14d9d5
Modify restore logic.
...
Signed-off-by: Xun Jiang <jxun@vmware.com >
2023-12-05 10:01:16 +08:00
c77bec73bb
Move VolumesInformation to an independant package.
...
Signed-off-by: Xun Jiang <jxun@vmware.com >
2023-12-04 08:33:37 +08:00
ca97248f2a
Use VolumeInfo to help restore the PV.
...
Add VolumeInfo for left PVs during backup.
Signed-off-by: Xun Jiang <jxun@vmware.com >
2023-12-04 08:33:37 +08:00
1fb0529d98
Add DataUpload Result and CSI VolumeSnapshot check for restore PV.
...
Signed-off-by: Xun Jiang <jxun@vmware.com >
2023-11-06 22:40:03 +08:00
20a1118acf
Make configmapref check case insensitive ( #6804 )
...
* Make configmapref check case insensitive
Signed-off-by: Anshul Ahuja <anshul.ahu@gmail.com >
* update resourcemodfier test case to validate case
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com >
---------
Signed-off-by: Anshul Ahuja <anshul.ahu@gmail.com >
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com >
Co-authored-by: Anshul Ahuja <anshulahuja@microsoft.com >
2023-10-26 15:30:21 +05:30
7750e12151
Perf improvements for existing resource restore
...
Use informer cache with dynamic client for Get calls on restore
When enabled, also make the Get call before create.
Add server and install parameter to allow disabling this feature,
but enable by default
Signed-off-by: Scott Seago <sseago@redhat.com >
2023-10-11 10:51:39 -04:00
da6ac026d1
Update restore controller logic for restore deletion
...
1. Skip deleting the restore files from storage if the backup/BSL is not found
2. Allow deleting the restore files from storage even though the BSL is readonly
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2023-09-06 09:19:42 +08:00
69bc84cf0c
fix issue 6571
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2023-08-03 14:46:02 +08:00
0bb509ccdd
add restore finalizer to clean up external resources
...
Signed-off-by: allenxu404 <qix2@vmware.com >
2023-07-19 18:56:35 +08:00
ce7d2bfc87
add more logs
...
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com >
2023-07-11 11:16:44 +05:30
4e6d31dc38
linting
...
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com >
2023-07-06 11:29:33 +05:30
ed4437ad22
initial draft
...
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com >
2023-07-05 13:51:32 +05:30
f051ecaee9
Enable errcheck linter and resolve found issues.
...
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
2023-04-28 09:33:42 +08:00
443f732e51
Enable more linters, and remove mal-functioned milestoned issue action.
...
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
2023-04-25 23:31:51 +08:00
458560795b
Remove Reference of itemsnapshotter ( #5997 )
...
It will be removed as we choose to use BIAv2 for progress monitoring.
Signed-off-by: Daniel Jiang <jiangd@vmware.com >
2023-03-21 09:05:29 +08:00
2155b2b215
RIAv2 async operations controller work
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2023-03-17 14:30:39 -04:00
ad9c6e8dee
delete io/ioutil package. ( #5955 )
...
Signed-off-by: yanggang <gang.yang@daocloud.io >
2023-03-16 09:25:58 +08:00
7d7e3fff0d
Refoctor backup controller with controller-runtime. ( #5969 )
...
Signed-off-by: Ming <mqiu@vmware.com >
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
Co-authored-by: Ming <mqiu@vmware.com >
2023-03-10 08:59:40 +08:00
40aae5ebdd
fix issue 5935
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2023-03-09 14:24:51 +08:00
eb4ecd3767
Add restored resource list in the output of restore describe command
...
Add restored resource list in the output of restore describe command
Fixes #5199
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2023-02-28 10:43:03 +08:00
c2ac76165e
Make restore controller adopting the controller-runtime framework.
...
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
2023-02-25 11:55:02 +08:00
fb1dc110f2
Replace k8s.io/apimachinery/pkg/util/clock with k8s.io/utils/clock
...
Signed-off-by: Zhizhen He <hezhizhen.yi@gmail.com >
2023-02-21 11:56:17 +08:00
fa58a775e8
Merge pull request #5576 from anshulahuja98/backupresults
...
Publish backup results to enhance error info
2023-02-18 17:00:49 -05:00
8c3ddf0f73
Publish backup results extracted from backup logs
...
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com >
2023-02-16 09:57:53 +05:30
0b6b841f2a
Remove redundant client from restore controller. ( #5759 )
...
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
2023-02-03 15:57:43 +08:00
9f6f13f0c5
RestoreItemAction v2 API implementation
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2023-01-10 16:26:28 -05:00
55873c1c37
Prevent nil panic on exec restore hooks ( #5675 )
...
* Prevent nil panic on exec restore hooks
Signed-off-by: Dylan Murray <dymurray@redhat.com >
2022-12-13 13:45:52 +08:00
d7b4583b2b
fix lint errors
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2022-10-18 21:53:47 +08:00
3f3a5050d6
Exclude "csinodes.storage.k8s.io" and "volumeattachments.storage.k8s.io" from backup and restore by default. ( #5064 )
...
Signed-off-by: Xun Jiang <jxun@vmware.com >
Signed-off-by: Xun Jiang <jxun@vmware.com >
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com >
2022-09-29 15:24:06 +08:00
e8da5df57a
Reduce CRD size.
...
1. Make the Restore hook.InitConatianer server side field pruing disable.
2. Remove restore patch in update-generate-crd-code.sh.
3. Modify related testcases.
4. Add Container fields validation in Restore Init hook.
Signed-off-by: Xun Jiang <jxun@vmware.com >
2022-08-02 19:45:01 +08:00
f562a7ce2b
Update the CRD for kopia integration
...
This commit adds additional fields to podvolumebackup
and podvolumerestore. The resticrepository will be renamed to
backuprepository
Signed-off-by: Daniel Jiang <jiangd@vmware.com >
2022-07-22 00:10:24 +08:00
6fa4d7d606
Mark in-progress CRs as failed when starting the server
...
Mark in-progress CRs as failed when starting the server
Fixes #4953
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2022-06-07 17:02:17 +08:00
bfdb68a35a
add multiple label selector support to backup API
...
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
remove backup CLI bits
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
labelselectors spec option for velero restore
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
add changelog file
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
update spec name to OrLabelSelectors
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
minor fixes
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
add validations for labelSelector and orLabelSelectors
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
update crds.gp after fixing conflicts
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
fix CI and add unit tests
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
updated OrLabelSelector spec description and added validation failure unit tests
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
add comments and change log level
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
update site docs
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
wrap pager client calls in a function
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
resolve confilcts and update crds.go
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
rebase and update crds.go
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
combine listing items for a given label
Signed-off-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com >
2022-05-11 09:57:47 -04:00
dfc86566b8
Make in-progress backup/restore as failed when doing the reconcile
...
Make in-progress backup/restore as failed when doing the reconcile to avoid hanging in in-progress status
Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com >
2022-04-26 11:05:03 +08:00
22189e8e19
Merge pull request #4436 from codegold79/3454-convert-pod-volume-backup-controller-to-kubebuilder-v3-framework
...
Convert Pod Volume Backup resource/controller to the Kubebuilder V3 framework
2022-04-15 15:07:09 +08:00
09ec3ba994
Insert all restore errors and warnings into restore log ( #4743 )
...
This allows a user inspecting the restore logs to see any
errors or warnings generated by the restore so that they
will be seen even without having to use the describe cli.
Signed-off-by: Scott Seago <sseago@redhat.com >
2022-03-21 14:29:03 +08:00
Xun Jiang
Subhramit Basu
Adam Zhang
Matthieu MOREL
Tiger Kaovilai
sangitaray2021
Daniel Jiang
Xun Jiang
allenxu404
Xun Jiang
Anshul Ahuja
Scott Seago
Wenkai Yin(尹文开)
Lyndon-Li
Anshul Ahuja
Xun Jiang
杨刚 (成都)
Xun Jiang/Bruce Jiang
Zhizhen He
Dylan Murray
Shubham Pampattiwar