Lyndon-Li and Joseph
a171687dd7
fix node agent rediness check issue
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2026-08-25 16:07:41 -07:00
7770a0884e
[cherry-pick release-1.18] Fast-fail backup when built-in data mover has no running node-agent ( #10360 )
...
Run the E2E test on kind / setup-test-matrix (push) Successful in 2s
e2e-test-kind.yaml / extract (push) Successful in 16s
Run the E2E test on kind / get-go-version (push) Successful in 18s
push.yml / extract (push) Successful in 12s
Main CI / get-go-version (push) Successful in 13s
Run the E2E test on kind / build (push) Failing after 25s
Run the E2E test on kind / run-e2e-test (push) Skipped
Main CI / Build (push) Failing after 34s
* Fast-fail backup when built-in data mover has no running node-agent
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
Signed-off-by: Joseph <jvaikath@redhat.com >
Signed-off-by: Chai Bot <ship-help-github@redhat.com >
* Run make update to fix import ordering
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com >
Signed-off-by: Joseph <jvaikath@redhat.com >
Signed-off-by: Chai Bot <ship-help-github@redhat.com >
* Create new changelog for release 10360
Signed-off-by: Chai Bot <ship-help-github@redhat.com >
---------
Signed-off-by: Joseph <jvaikath@redhat.com >
Signed-off-by: Chai Bot <ship-help-github@redhat.com >
Co-authored-by: Joseph <jvaikath@redhat.com >
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com >
Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com >
2026-08-25 22:52:02 +00:00
Xun Jiang/Bruce Jiang and GitHub
25402b6209
[1.18] Deprecate inactive maintained packages ( #9912 )
...
Run the E2E test on kind / get-go-version (push) Successful in 59s
Run the E2E test on kind / setup-test-matrix (push) Successful in 4s
Main CI / get-go-version (push) Successful in 14s
Run the E2E test on kind / build (push) Failing after 1m48s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 25s
* Replace github.com/robfig/cron/v3 by github.com/netresearch/go-cron
Replace k8s.io/utils/pointer with k8s.io/utils/ptr
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
* Replace gopkg.in/yaml.v3 by go.yaml.in/yaml/v3
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
* Replace github.com/joho/godotenv.
Move the needed code into Velero repository.
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
* Replace github.com/pkg/errors by github.com/cockroachdb/errors
Change errors.Cause to errors.Is, because github.com/cockroachdb/errors
New() function create a error with error stack with depth 1, but
github.com/pkg/errors's New() function create error with no depth.
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
---------
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com >
2026-07-10 11:20:34 +08:00
Adam Zhang
ea057e42fa
fix node-agent node detection logic
...
Add namespace in ListOptions, to fix node-agent node detection
in its deployed namespace.
Signed-off-by: Adam Zhang <adam.zhang@broadcom.com >
2026-04-03 14:31:13 +08:00
Xun Jiang/Bruce Jiang and GitHub
f8938e7fed
VerifyJSONConfigs verify every elements in Data. ( #9302 )
...
Run the E2E test on kind / get-go-version (push) Failing after 48s
Run the E2E test on kind / build (push) Has been skipped
Run the E2E test on kind / setup-test-matrix (push) Successful in 2s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / get-go-version (push) Failing after 4s
Main CI / Build (push) Has been skipped
Close stale issues and PRs / stale (push) Failing after 6s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 7s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 3s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 3s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 4s
Add error message in the velero install CLI output if VerifyJSONConfigs fail.
Only allow one element in node-agent-configmap's Data.
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
2025-09-29 15:08:05 -04:00
Xun Jiang
c62a486765
Add ConfigMap parameters validation for install CLI and server start.
...
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
2025-08-22 20:31:38 +08:00
Tiger Kaovilai and Claude
35d2cc0890
Add priority class support for Velero server and node-agent
...
- Add --server-priority-class-name and --node-agent-priority-class-name flags to velero install command
- Configure data mover pods (PVB/PVR/DataUpload/DataDownload) to use priority class from node-agent-configmap
- Configure maintenance jobs to use priority class from repo-maintenance-job-configmap (global config only)
- Add priority class validation with ValidatePriorityClass and GetDataMoverPriorityClassName utilities
- Update e2e tests to include PriorityClass testing utilities
- Move priority class design document to Implemented folder
- Add comprehensive unit tests for all priority class implementations
- Update documentation for priority class configuration
- Add changelog entry for #8883
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
remove unused test utils
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
feat: add unit test for getting priority class name in maintenance jobs
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
doc update
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
feat: add priority class validation for repository maintenance jobs
- Add ValidatePriorityClassWithClient function to validate priority class existence
- Integrate validation in maintenance.go when creating maintenance jobs
- Update tests to cover the new validation functionality
- Return boolean from ValidatePriorityClass to allow fallback behavior
This ensures maintenance jobs don't fail due to non-existent priority classes,
following the same pattern used for data mover pods.
Addresses feedback from:
https://github.com/vmware-tanzu/velero/pull/8883#discussion_r2238681442
Refs #8869
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
refactor: clean up priority class handling for data mover pods
- Fix comment in node_agent.go to clarify PriorityClassName is only for data mover pods
- Simplify server.go to use dataPathConfigs.PriorityClassName directly
- Remove redundant priority class logging from controllers as it's already logged during server startup
- Keep logging centralized in the node-agent server initialization
This reduces code duplication and clarifies the scope of priority class configuration.
🤖 Generated with [Claude Code](https://claude.ai/code )
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
refactor: remove GetDataMoverPriorityClassName from kube utilities
Remove GetDataMoverPriorityClassName function and its tests as priority
class is now read directly from dataPathConfigs instead of parsing from
ConfigMap. This simplifies the codebase by eliminating the need for
indirect ConfigMap parsing.
Refs #8869
🤖 Generated with [Claude Code](https://claude.ai/code )
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
refactor: remove priority class validation from install command
Remove priority class validation during install as it's redundant
since validation already occurs during server startup. Users cannot
see console logs during install, making the validation warnings
ineffective at this stage.
The validation remains in place during server and node-agent startup
where it's more appropriate and visible to users.
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com >
Co-Authored-By: Claude <noreply@anthropic.com >
2025-08-06 01:36:22 -04:00
Lyndon-Li
34f8b73507
bump up kopia to v0.21.1
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-07-22 15:56:04 +08:00
lyndon-li and GitHub
06d305ea47
Issue 8344: constrain data path expose ( #9064 )
...
Run the E2E test on kind / build (push) Failing after 7m38s
Run the E2E test on kind / setup-test-matrix (push) Successful in 4s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 39s
Close stale issues and PRs / stale (push) Successful in 22s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m32s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 1m41s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 1m30s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 1m18s
* issue 8344: constrain data path exposure.
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-07-18 13:32:45 +08:00
Lyndon-Li
a752b54614
issue 8857: support third party tolerations
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-07-08 14:23:00 +08:00
Matthieu MOREL
07ea14962c
fix require-error rule from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-06-23 15:39:54 +00:00
Lyndon-Li
d903e9eda7
issue 8960: implement PodVolume exposer for PVB/PVR
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-05-30 13:45:31 +08:00
Lyndon-Li
b7d997130d
issue 8960: implement PodVolume exposer for PVB/PVR
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-05-29 17:09:03 +08:00
Matthieu MOREL and GitHub
c6a420bd3a
chore: define common aliases for k8s packages ( #8672 )
...
Run the E2E test on kind / build (push) Failing after 6m48s
Run the E2E test on kind / setup-test-matrix (push) Successful in 3s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 35s
Close stale issues and PRs / stale (push) Successful in 8s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m11s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-aws, main) (push) Failing after 47s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-gcp, main) (push) Failing after 49s
Trivy Nightly Scan / Trivy nightly scan (velero-plugin-for-microsoft-azure, main) (push) Failing after 43s
* lchore: define common alias for k8s packages
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update .golangci.yaml
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update .golangci.yaml
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
* Update .golangci.yaml
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
---------
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
2025-04-22 06:14:47 -04:00
Lyndon-Li
b170892e64
issue 8754: add third party annotation support
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2025-03-10 10:38:26 +08:00
Lyndon-Li
cfad06b701
Merge branch 'main' into restore-pvc-ignore-wait-for-first-consumer
2025-01-03 14:14:37 +08:00
Lyndon-Li
f5d13aeb17
data mover backup for Windows nodes
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-12-26 02:46:08 +00:00
Lyndon-Li
a56b06bab1
issue 8044: generic restore - allow to ignore WaitForFirstConsumer
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-12-26 10:29:15 +08:00
Lyndon-Li
4ad9c2485a
hybrid deploy
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-12-18 10:50:23 +08:00
Lyndon-Li
a711b1067b
fail fs-backup for windows nodes
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-12-18 10:46:00 +08:00
Wenkai Yin(尹文开) and GitHub
0224d99889
Merge pull request #8482 from Lyndon-Li/data-mover-exposer-diagnostic
...
Run the E2E test on kind / build (push) Failing after 6m17s
Run the E2E test on kind / setup-test-matrix (push) Successful in 5s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 1m3s
Close stale issues and PRs / stale (push) Has started running
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Has started running
Trivy Nightly Scan / Trivy nightly scan (velero-restore-helper, main) (push) Has started running
Data mover exposer diagnostic
2024-12-13 14:28:37 +08:00
lyndon-li and GitHub
a1cf952b8d
Issue 8433: add third party labels to data mover pods when the same labels exist in node-agent pods ( #8487 )
...
Run the E2E test on kind / build (push) Failing after 6m42s
Run the E2E test on kind / setup-test-matrix (push) Successful in 8s
Run the E2E test on kind / run-e2e-test (push) Has been skipped
Main CI / Build (push) Failing after 1m26s
Close stale issues and PRs / stale (push) Successful in 14s
Trivy Nightly Scan / Trivy nightly scan (velero, main) (push) Failing after 1m7s
Trivy Nightly Scan / Trivy nightly scan (velero-restore-helper, main) (push) Failing after 1m19s
* issue 8433: add ask label to data mover pods
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
* check existence of the same label from node-agent
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
---------
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-12-09 12:44:39 -05:00
Lyndon-Li
e4e9b18b37
add diagnostic for data mover exposer
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-12-04 10:28:50 +08:00
Scott Seago
b1035dd49d
add no-relabeling option to backupPVC configmap
...
Signed-off-by: Scott Seago <sseago@redhat.com >
2024-10-14 10:26:55 -04:00
Xun Jiang
26cc41f26d
Implement the Repo maintanence Job configuration design.
...
Remove the resource parameters from the velero server CLI.
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com >
2024-09-09 22:42:56 +08:00
Lyndon-Li
627e2fede6
nod-agent config for pod resources
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-08-22 15:06:35 +08:00
Shubham Pampattiwar and GitHub
86963bf229
Merge pull request #8097 from Lyndon-Li/issue-fix-8032
...
Issue 8032: make node agent configMap name configurable
2024-08-19 14:49:43 -07:00
Lyndon-Li
8cf1749ae0
issue 8032: make node agent configMap name configurable
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-08-19 10:33:17 +08:00
Shubham Pampattiwar
8eac3606d9
Add support for backup PVC configuration
...
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
add changelog file
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
make update
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
pass backupPVCConfig to exposer as part of csi params
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com >
2024-08-13 17:06:06 -07:00
Lyndon-Li
dccde10368
issue-7036: make affinity as list and take 1st one
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-03-18 11:25:27 +08:00
Lyndon-Li
9a907a21f2
issue-7036:data mover load affinties
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2024-02-05 14:13:10 +08:00
Lyndon-Li
58ead55fd1
change node-agent-config name
...
Signed-off-by: Lyndon-Li <yonghui.li@broadcom.com >
2024-01-03 22:02:04 +08:00
Lyndon-Li
8968ae5ec4
add node-agent concurrency doc
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2023-11-29 14:33:51 +08:00
Lyndon-Li
db43200cc8
configurable data path concurrency: all in one json
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2023-11-08 12:02:02 +08:00
Lyndon-Li
68579448d6
configurable data path concurrency: UT
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2023-11-06 20:29:33 +08:00
Lyndon-Li
262f10ff49
Merge branch 'main' into issue-fix-6663
2023-11-06 16:52:41 +08:00
Lyndon-Li
04a9851ee9
configurable data path concurrency: all in cm
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2023-11-06 16:46:13 +08:00
Xun Jiang
a221a88945
Remove dependency of generated client part 2
...
Remove dependecy of generate client from pkg/cmd/cli/snapshotLocation.
Remove the Velero generated informer from PVB and PVR.
Remove dependency of generated client from pkg/podvolume directory.
Replace generated codec with runtime codec.
Signed-off-by: Xun Jiang <jxun@vmware.com >
2023-11-03 17:11:36 +08:00
Lyndon-Li
c44a9b8956
issue 6663: changes for configurable data path concurrency
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2023-10-27 17:37:29 +08:00
Lyndon-Li
d6134ec444
fix issue 6561
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2023-08-01 21:10:01 +08:00
Xun Jiang
180cc4e31d
Enable linter revive and resolve found errors: part 1
...
Signed-off-by: Xun Jiang <blackpiglet@gmail.com >
2023-04-25 23:15:15 +08:00
Lyndon-Li
c92f06ef17
fix lint loop iterator problem
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2022-10-18 22:40:48 +08:00
Lyndon-Li
d7b4583b2b
fix lint errors
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2022-10-18 21:53:47 +08:00
lyndon and GitHub
83ea1cc58b
rename daemonset ( #5390 )
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2022-10-11 14:18:21 +08:00
Lyndon-Li
fbb2606102
issue fix 4874 update
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2022-09-13 11:15:52 +08:00
Lyndon-Li
a12024887f
fix issue 4874
...
Signed-off-by: Lyndon-Li <lyonghui@vmware.com >
2022-09-07 21:44:45 +08:00