/* Copyright 2017 Heptio Inc. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package controller import ( "io" "testing" "time" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/util/clock" core "k8s.io/client-go/testing" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/mock" "github.com/stretchr/testify/require" "github.com/heptio/ark/pkg/apis/ark/v1" "github.com/heptio/ark/pkg/generated/clientset/fake" "github.com/heptio/ark/pkg/generated/clientset/scheme" informers "github.com/heptio/ark/pkg/generated/informers/externalversions" . "github.com/heptio/ark/pkg/util/test" ) type fakeBackupper struct { mock.Mock } func (b *fakeBackupper) Backup(backup *v1.Backup, data io.Writer) error { args := b.Called(backup, data) return args.Error(0) } func TestProcessBackup(t *testing.T) { tests := []struct { name string key string expectError bool expectedIncludes []string expectedExcludes []string backup *TestBackup expectBackup bool }{ { name: "bad key", key: "bad/key/here", expectError: true, }, { name: "lister failed", key: "heptio-ark/backup1", expectError: true, }, { name: "do not process phase FailedValidation", key: "heptio-ark/backup1", backup: NewTestBackup().WithName("backup1").WithPhase(v1.BackupPhaseFailedValidation), expectBackup: false, }, { name: "do not process phase InProgress", key: "heptio-ark/backup1", backup: NewTestBackup().WithName("backup1").WithPhase(v1.BackupPhaseInProgress), expectBackup: false, }, { name: "do not process phase Completed", key: "heptio-ark/backup1", backup: NewTestBackup().WithName("backup1").WithPhase(v1.BackupPhaseCompleted), expectBackup: false, }, { name: "do not process phase Failed", key: "heptio-ark/backup1", backup: NewTestBackup().WithName("backup1").WithPhase(v1.BackupPhaseFailed), expectBackup: false, }, { name: "do not process phase other", key: "heptio-ark/backup1", backup: NewTestBackup().WithName("backup1").WithPhase("arg"), expectBackup: false, }, { name: "invalid included/excluded resources fails validation", key: "heptio-ark/backup1", backup: NewTestBackup().WithName("backup1").WithPhase(v1.BackupPhaseNew).WithIncludedResources("foo").WithExcludedResources("foo"), expectBackup: false, }, { name: "invalid included/excluded namespaces fails validation", key: "heptio-ark/backup1", backup: NewTestBackup().WithName("backup1").WithPhase(v1.BackupPhaseNew).WithIncludedNamespaces("foo").WithExcludedNamespaces("foo"), expectBackup: false, }, { name: "make sure specified included and excluded resources are honored", key: "heptio-ark/backup1", backup: NewTestBackup().WithName("backup1").WithPhase(v1.BackupPhaseNew).WithIncludedResources("i", "j").WithExcludedResources("k", "l"), expectedIncludes: []string{"i", "j"}, expectedExcludes: []string{"k", "l"}, expectBackup: true, }, { name: "if includednamespaces are specified, don't default to *", key: "heptio-ark/backup1", backup: NewTestBackup().WithName("backup1").WithPhase(v1.BackupPhaseNew).WithIncludedNamespaces("ns-1"), expectedIncludes: []string{"*"}, expectBackup: true, }, { name: "ttl", key: "heptio-ark/backup1", backup: NewTestBackup().WithName("backup1").WithPhase(v1.BackupPhaseNew).WithTTL(10 * time.Minute), expectedIncludes: []string{"*"}, expectBackup: true, }, } // flag.Set("logtostderr", "true") // flag.Set("v", "4") for _, test := range tests { t.Run(test.name, func(t *testing.T) { client := fake.NewSimpleClientset() backupper := &fakeBackupper{} cloudBackups := &fakeBackupService{} sharedInformers := informers.NewSharedInformerFactory(client, 0) c := NewBackupController( sharedInformers.Ark().V1().Backups(), client.ArkV1(), backupper, cloudBackups, "bucket", ).(*backupController) c.clock = clock.NewFakeClock(time.Now()) var expiration time.Time var expectedNSes []string if test.backup != nil { // add directly to the informer's store so the lister can function and so we don't have to // start the shared informers. sharedInformers.Ark().V1().Backups().Informer().GetStore().Add(test.backup.Backup) if test.backup.Spec.TTL.Duration > 0 { expiration = c.clock.Now().Add(test.backup.Spec.TTL.Duration) } // set up a Backup object to represent what we expect to be passed to backupper.Backup() copy, err := scheme.Scheme.Copy(test.backup.Backup) assert.NoError(t, err, "copy error") backup := copy.(*v1.Backup) backup.Spec.IncludedResources = test.expectedIncludes backup.Spec.ExcludedResources = test.expectedExcludes if test.backup.Spec.IncludedNamespaces == nil { expectedNSes = []string{"*"} } else { expectedNSes = test.backup.Spec.IncludedNamespaces } backup.Spec.IncludedNamespaces = expectedNSes backup.Status.Phase = v1.BackupPhaseInProgress backup.Status.Expiration.Time = expiration backup.Status.Version = 1 backupper.On("Backup", backup, mock.Anything).Return(nil) cloudBackups.On("UploadBackup", "bucket", backup.Name, mock.Anything, mock.Anything).Return(nil) } // this is necessary so the Update() call returns the appropriate object client.PrependReactor("update", "backups", func(action core.Action) (bool, runtime.Object, error) { obj := action.(core.UpdateAction).GetObject() // need to deep copy so we can test the backup state for each call to update copy, err := scheme.Scheme.DeepCopy(obj) if err != nil { return false, nil, err } ret := copy.(runtime.Object) return true, ret, nil }) // method under test err := c.processBackup(test.key) if test.expectError { require.Error(t, err, "processBackup should error") return } require.NoErrorf(t, err, "processBackup unexpected error: %v", err) if !test.expectBackup { assert.Empty(t, backupper.Calls) assert.Empty(t, cloudBackups.Calls) return } expectedActions := []core.Action{ core.NewUpdateAction( v1.SchemeGroupVersion.WithResource("backups"), v1.DefaultNamespace, NewTestBackup(). WithName(test.backup.Name). WithPhase(v1.BackupPhaseInProgress). WithIncludedResources(test.expectedIncludes...). WithExcludedResources(test.expectedExcludes...). WithIncludedNamespaces(expectedNSes...). WithTTL(test.backup.Spec.TTL.Duration). WithExpiration(expiration). WithVersion(1). Backup, ), core.NewUpdateAction( v1.SchemeGroupVersion.WithResource("backups"), v1.DefaultNamespace, NewTestBackup(). WithName(test.backup.Name). WithPhase(v1.BackupPhaseCompleted). WithIncludedResources(test.expectedIncludes...). WithExcludedResources(test.expectedExcludes...). WithIncludedNamespaces(expectedNSes...). WithTTL(test.backup.Spec.TTL.Duration). WithExpiration(expiration). WithVersion(1). Backup, ), } assert.Equal(t, expectedActions, client.Actions()) }) } }