mirror of
https://github.com/vmware-tanzu/velero.git
synced 2026-09-19 14:34:17 +00:00
Run the E2E test on kind / setup-test-matrix (push) Failing after 3s
Scorecard supply-chain security / Scorecard analysis (push) Skipped
e2e-test-kind.yaml / extract (push) Failing after 6s
Run the E2E test on kind / get-go-version (push) Failing after 7s
Run the E2E test on kind / build (push) Skipped
Run the E2E test on kind / run-e2e-test (push) Skipped
push.yml / extract (push) Failing after 6s
Main CI / get-go-version (push) Failing after 7s
Main CI / Build (push) Skipped
* Remove toleration whitelist for PodVolumeBackup and data mover pods Instead of filtering tolerations through a hardcoded allowlist (ThirdPartyTolerations), inherit all tolerations from the node-agent daemonset for PodVolumeBackup/Restore and DataUpload/Download pods, and from the Velero deployment for maintenance jobs. This enables backups and restores on nodes with custom NoExecute taints, which was previously impossible since only two specific toleration keys were whitelisted. Fixes #9476 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> * Fix codespell: replace 'whitelist' with 'allowlist' in changelog Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> * Implement deduplication of tolerations and add unit tests for the new function Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Merge node-agent-configmap tolerations with third-party allowlist Add a `tolerations` field to the node-agent-configmap so operators can declare hosting-pod tolerations explicitly, per blackpiglet's review feedback that tolerations shouldn't be read from the DaemonSet alone. These are merged with (and deduplicated against) DaemonSet tolerations matching the existing third-party allowlist (kubernetes.azure.com/scalesetpriority, CriticalAddonsOnly), restoring that allowlist per the follow-up suggestion to keep inheriting it alongside the new config option. The toleration dedup helper is moved from pkg/exposer to pkg/util/kube (exported as DeduplicateTolerations) so it can be shared with pkg/nodeagent without an import cycle. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Fix testifylint finding in TestGetTolerations golangci-lint v2.12.0 (pinned in pr-linter-check.yml) flagged the shared assert.Equal after the if/else as require-error: use require for the error assertion so each branch is self-contained, matching the pattern used elsewhere in this file. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Document toleration merge priority in GetTolerations Per blackpiglet's review feedback: clarify that configured tolerations take priority over allowlisted daemonset tolerations because they're appended first and DeduplicateTolerations keeps only the first occurrence of each exact (Key, Operator, Value, Effect) combination. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> --------- Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Happy <yesreply@happy.engineering>
731 lines
24 KiB
Go
731 lines
24 KiB
Go
/*
|
|
Copyright The Velero Contributors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package nodeagent
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"math"
|
|
"net/http"
|
|
"os"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/bombsimon/logrusr/v3"
|
|
"github.com/cockroachdb/errors"
|
|
snapshotv1api "github.com/kubernetes-csi/external-snapshotter/client/v8/apis/volumesnapshot/v1"
|
|
snapshotv1client "github.com/kubernetes-csi/external-snapshotter/client/v8/clientset/versioned"
|
|
"github.com/prometheus/client_golang/prometheus/promhttp"
|
|
"github.com/sirupsen/logrus"
|
|
"github.com/spf13/cobra"
|
|
corev1api "k8s.io/api/core/v1"
|
|
storagev1api "k8s.io/api/storage/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/fields"
|
|
"k8s.io/apimachinery/pkg/labels"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"k8s.io/apimachinery/pkg/util/sets"
|
|
"k8s.io/client-go/kubernetes"
|
|
cacheutil "k8s.io/client-go/tools/cache"
|
|
"k8s.io/klog/v2"
|
|
"k8s.io/utils/clock"
|
|
ctrl "sigs.k8s.io/controller-runtime"
|
|
"sigs.k8s.io/controller-runtime/pkg/cache"
|
|
ctrlclient "sigs.k8s.io/controller-runtime/pkg/client"
|
|
"sigs.k8s.io/controller-runtime/pkg/manager"
|
|
|
|
velerov1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"
|
|
velerov2alpha1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v2alpha1"
|
|
"github.com/vmware-tanzu/velero/pkg/buildinfo"
|
|
"github.com/vmware-tanzu/velero/pkg/client"
|
|
"github.com/vmware-tanzu/velero/pkg/cmd"
|
|
"github.com/vmware-tanzu/velero/pkg/cmd/util/signals"
|
|
"github.com/vmware-tanzu/velero/pkg/constant"
|
|
"github.com/vmware-tanzu/velero/pkg/controller"
|
|
"github.com/vmware-tanzu/velero/pkg/datapath"
|
|
"github.com/vmware-tanzu/velero/pkg/exposer"
|
|
"github.com/vmware-tanzu/velero/pkg/metrics"
|
|
"github.com/vmware-tanzu/velero/pkg/nodeagent"
|
|
repository "github.com/vmware-tanzu/velero/pkg/repository/manager"
|
|
velerotypes "github.com/vmware-tanzu/velero/pkg/types"
|
|
"github.com/vmware-tanzu/velero/pkg/util/filesystem"
|
|
"github.com/vmware-tanzu/velero/pkg/util/kube"
|
|
"github.com/vmware-tanzu/velero/pkg/util/logging"
|
|
)
|
|
|
|
var (
|
|
scheme = runtime.NewScheme()
|
|
)
|
|
|
|
const (
|
|
// the port where prometheus metrics are exposed
|
|
defaultMetricsAddress = ":8085"
|
|
|
|
defaultResourceTimeout = 10 * time.Minute
|
|
defaultDataMoverPrepareTimeout = 30 * time.Minute
|
|
defaultDataPathConcurrentNum = 1
|
|
)
|
|
|
|
type nodeAgentServerConfig struct {
|
|
metricsAddress string
|
|
resourceTimeout time.Duration
|
|
dataMoverPrepareTimeout time.Duration
|
|
nodeAgentConfig string
|
|
backupRepoConfig string
|
|
}
|
|
|
|
func NewServerCommand(f client.Factory) *cobra.Command {
|
|
logLevelFlag := logging.LogLevelFlag(logrus.InfoLevel)
|
|
formatFlag := logging.NewFormatFlag()
|
|
config := nodeAgentServerConfig{
|
|
metricsAddress: defaultMetricsAddress,
|
|
resourceTimeout: defaultResourceTimeout,
|
|
dataMoverPrepareTimeout: defaultDataMoverPrepareTimeout,
|
|
}
|
|
|
|
command := &cobra.Command{
|
|
Use: "server",
|
|
Short: "Run the velero node-agent server",
|
|
Long: "Run the velero node-agent server",
|
|
Hidden: true,
|
|
Run: func(c *cobra.Command, args []string) {
|
|
logLevel := logLevelFlag.Parse()
|
|
logrus.Infof("Setting log-level to %s", strings.ToUpper(logLevel.String()))
|
|
|
|
logger := logging.DefaultMergeLogger(logLevel, formatFlag.Parse())
|
|
logger.Infof("Starting Velero node-agent server %s (%s)", buildinfo.Version, buildinfo.FormattedGitSHA())
|
|
|
|
f.SetBasename(fmt.Sprintf("%s-%s", c.Parent().Name(), c.Name()))
|
|
s, err := newNodeAgentServer(logger, f, config)
|
|
cmd.CheckError(err)
|
|
|
|
s.run()
|
|
},
|
|
}
|
|
|
|
command.Flags().Var(logLevelFlag, "log-level", fmt.Sprintf("The level at which to log. Valid values are %s.", strings.Join(logLevelFlag.AllowedValues(), ", ")))
|
|
command.Flags().Var(formatFlag, "log-format", fmt.Sprintf("The format for log output. Valid values are %s.", strings.Join(formatFlag.AllowedValues(), ", ")))
|
|
command.Flags().DurationVar(&config.resourceTimeout, "resource-timeout", config.resourceTimeout, "How long to wait for resource processes which are not covered by other specific timeout parameters. Default is 10 minutes.")
|
|
command.Flags().DurationVar(&config.dataMoverPrepareTimeout, "data-mover-prepare-timeout", config.dataMoverPrepareTimeout, "How long to wait for preparing a DataUpload/DataDownload. Default is 30 minutes.")
|
|
command.Flags().StringVar(&config.metricsAddress, "metrics-address", config.metricsAddress, "The address to expose prometheus metrics")
|
|
command.Flags().StringVar(&config.nodeAgentConfig, "node-agent-configmap", config.nodeAgentConfig, "The name of ConfigMap containing node-agent configurations.")
|
|
command.Flags().StringVar(&config.backupRepoConfig, "backup-repository-configmap", config.backupRepoConfig, "The name of ConfigMap containing backup repository configurations.")
|
|
|
|
return command
|
|
}
|
|
|
|
type nodeAgentServer struct {
|
|
logger logrus.FieldLogger
|
|
ctx context.Context
|
|
cancelFunc context.CancelFunc
|
|
fileSystem filesystem.Interface
|
|
mgr manager.Manager
|
|
metrics *metrics.ServerMetrics
|
|
metricsAddress string
|
|
namespace string
|
|
nodeName string
|
|
config nodeAgentServerConfig
|
|
kubeClient kubernetes.Interface
|
|
csiSnapshotClient *snapshotv1client.Clientset
|
|
dataPathMgr *datapath.Manager
|
|
dataPathConfigs *velerotypes.NodeAgentConfigs
|
|
backupRepoConfigs map[string]string
|
|
vgdpCounter *exposer.VgdpCounter
|
|
repoConfigMgr repository.ConfigManager
|
|
}
|
|
|
|
func newNodeAgentServer(logger logrus.FieldLogger, factory client.Factory, config nodeAgentServerConfig) (*nodeAgentServer, error) {
|
|
ctx, cancelFunc := context.WithCancel(context.Background())
|
|
|
|
clientConfig, err := factory.ClientConfig()
|
|
if err != nil {
|
|
cancelFunc()
|
|
return nil, err
|
|
}
|
|
|
|
ctrl.SetLogger(logrusr.New(logger))
|
|
klog.SetLogger(logrusr.New(logger)) // klog.Logger is used by k8s.io/client-go
|
|
|
|
if err := velerov1api.AddToScheme(scheme); err != nil {
|
|
cancelFunc()
|
|
return nil, err
|
|
}
|
|
if err := velerov2alpha1api.AddToScheme(scheme); err != nil {
|
|
cancelFunc()
|
|
return nil, err
|
|
}
|
|
if err := corev1api.AddToScheme(scheme); err != nil {
|
|
cancelFunc()
|
|
return nil, err
|
|
}
|
|
if err := storagev1api.AddToScheme(scheme); err != nil {
|
|
cancelFunc()
|
|
return nil, err
|
|
}
|
|
if err := snapshotv1api.AddToScheme(scheme); err != nil {
|
|
cancelFunc()
|
|
return nil, err
|
|
}
|
|
|
|
nodeName := os.Getenv("NODE_NAME")
|
|
|
|
// use a field selector to filter to only pods scheduled on this node.
|
|
cacheOption := cache.Options{
|
|
ByObject: map[ctrlclient.Object]cache.ByObject{
|
|
&corev1api.Pod{}: {
|
|
Field: fields.Set{"spec.nodeName": nodeName}.AsSelector(),
|
|
},
|
|
&velerov1api.PodVolumeBackup{}: {
|
|
Field: fields.Set{"metadata.namespace": factory.Namespace()}.AsSelector(),
|
|
},
|
|
&velerov1api.PodVolumeRestore{}: {
|
|
Field: fields.Set{"metadata.namespace": factory.Namespace()}.AsSelector(),
|
|
},
|
|
&velerov2alpha1api.DataUpload{}: {
|
|
Field: fields.Set{"metadata.namespace": factory.Namespace()}.AsSelector(),
|
|
},
|
|
&velerov2alpha1api.DataDownload{}: {
|
|
Field: fields.Set{"metadata.namespace": factory.Namespace()}.AsSelector(),
|
|
},
|
|
&corev1api.Event{}: {
|
|
Field: fields.Set{"metadata.namespace": factory.Namespace()}.AsSelector(),
|
|
},
|
|
},
|
|
}
|
|
|
|
var mgr manager.Manager
|
|
retry := 10
|
|
for {
|
|
mgr, err = ctrl.NewManager(clientConfig, ctrl.Options{
|
|
Scheme: scheme,
|
|
Cache: cacheOption,
|
|
})
|
|
if err == nil {
|
|
break
|
|
}
|
|
|
|
retry--
|
|
if retry == 0 {
|
|
break
|
|
}
|
|
|
|
logger.WithError(err).Warn("Failed to create controller manager, need retry")
|
|
|
|
time.Sleep(time.Second)
|
|
}
|
|
|
|
if err != nil {
|
|
cancelFunc()
|
|
return nil, errors.Wrap(err, "error creating controller manager")
|
|
}
|
|
|
|
s := &nodeAgentServer{
|
|
logger: logger,
|
|
ctx: ctx,
|
|
cancelFunc: cancelFunc,
|
|
fileSystem: filesystem.NewFileSystem(),
|
|
mgr: mgr,
|
|
config: config,
|
|
namespace: factory.Namespace(),
|
|
nodeName: nodeName,
|
|
metricsAddress: config.metricsAddress,
|
|
repoConfigMgr: repository.NewConfigManager(logger),
|
|
}
|
|
|
|
// the cache isn't initialized yet when "validatePodVolumesHostPath" is called, the client returned by the manager cannot
|
|
// be used, so we need the kube client here
|
|
s.kubeClient, err = factory.KubeClient()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if err := s.validatePodVolumesHostPath(s.kubeClient); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
s.csiSnapshotClient, err = snapshotv1client.NewForConfig(clientConfig)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if err := s.getDataPathConfigs(); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if err := s.getBackupRepoConfigs(); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
s.dataPathMgr = datapath.NewManager(s.getDataPathConcurrentNum(defaultDataPathConcurrentNum))
|
|
|
|
return s, nil
|
|
}
|
|
|
|
func (s *nodeAgentServer) run() {
|
|
signals.CancelOnShutdown(s.cancelFunc, s.logger)
|
|
|
|
go func() {
|
|
metricsMux := http.NewServeMux()
|
|
metricsMux.Handle("/metrics", promhttp.Handler())
|
|
s.logger.Infof("Starting metric server for node agent at address [%s]", s.metricsAddress)
|
|
server := &http.Server{
|
|
Addr: s.metricsAddress,
|
|
Handler: metricsMux,
|
|
ReadHeaderTimeout: 3 * time.Second,
|
|
}
|
|
if err := server.ListenAndServe(); err != nil {
|
|
s.logger.Fatalf("Failed to start metric server for node agent at [%s]: %v", s.metricsAddress, err)
|
|
}
|
|
}()
|
|
s.metrics = metrics.NewNodeMetrics()
|
|
s.metrics.RegisterAllMetrics()
|
|
s.metrics.InitMetricsForNode(s.nodeName)
|
|
|
|
s.logger.Info("Starting controllers")
|
|
|
|
// Get priority class from dataPathConfigs if available
|
|
dataMovePriorityClass := ""
|
|
if s.dataPathConfigs != nil && s.dataPathConfigs.PriorityClassName != "" {
|
|
priorityClass := s.dataPathConfigs.PriorityClassName
|
|
// Validate the priority class exists in the cluster
|
|
ctx, cancel := context.WithTimeout(s.ctx, time.Second*30)
|
|
defer cancel()
|
|
if kube.ValidatePriorityClass(ctx, s.kubeClient, priorityClass, s.logger.WithField("component", "data-mover")) {
|
|
dataMovePriorityClass = priorityClass
|
|
s.logger.WithField("priorityClassName", priorityClass).Info("Using priority class for data mover pods")
|
|
} else {
|
|
s.logger.WithField("priorityClassName", priorityClass).Warn("Priority class not found in cluster, data mover pods will use default priority")
|
|
}
|
|
}
|
|
|
|
var loadAffinity []*kube.LoadAffinity
|
|
if s.dataPathConfigs != nil && len(s.dataPathConfigs.LoadAffinity) > 0 {
|
|
loadAffinity = s.dataPathConfigs.LoadAffinity
|
|
s.logger.Infof("Using customized loadAffinity %v", loadAffinity)
|
|
}
|
|
|
|
var backupPVCConfig map[string]velerotypes.BackupPVC
|
|
if s.dataPathConfigs != nil && s.dataPathConfigs.BackupPVCConfig != nil {
|
|
backupPVCConfig = s.dataPathConfigs.BackupPVCConfig
|
|
s.logger.Infof("Using customized backupPVC config %v", backupPVCConfig)
|
|
}
|
|
|
|
privilegedFsBackup := s.dataPathConfigs != nil && s.dataPathConfigs.PrivilegedFsBackup
|
|
|
|
podResources := corev1api.ResourceRequirements{}
|
|
if s.dataPathConfigs != nil && s.dataPathConfigs.PodResources != nil {
|
|
// To make the PodResources ConfigMap without ephemeral storage request/limit backward compatible,
|
|
// need to avoid set value as empty, because empty string will cause parsing error.
|
|
ephemeralStorageRequest := constant.DefaultEphemeralStorageRequest
|
|
if s.dataPathConfigs.PodResources.EphemeralStorageRequest != "" {
|
|
ephemeralStorageRequest = s.dataPathConfigs.PodResources.EphemeralStorageRequest
|
|
}
|
|
ephemeralStorageLimit := constant.DefaultEphemeralStorageLimit
|
|
if s.dataPathConfigs.PodResources.EphemeralStorageLimit != "" {
|
|
ephemeralStorageLimit = s.dataPathConfigs.PodResources.EphemeralStorageLimit
|
|
}
|
|
|
|
if res, err := kube.ParseResourceRequirements(
|
|
s.dataPathConfigs.PodResources.CPURequest,
|
|
s.dataPathConfigs.PodResources.MemoryRequest,
|
|
ephemeralStorageRequest,
|
|
s.dataPathConfigs.PodResources.CPULimit,
|
|
s.dataPathConfigs.PodResources.MemoryLimit,
|
|
ephemeralStorageLimit,
|
|
); err != nil {
|
|
s.logger.WithError(err).Warn("Pod resource requirements are invalid, ignore")
|
|
} else {
|
|
podResources = res
|
|
s.logger.Infof("Using customized pod resource requirements %v", s.dataPathConfigs.PodResources)
|
|
}
|
|
}
|
|
|
|
if s.dataPathConfigs != nil && s.dataPathConfigs.LoadConcurrency != nil && s.dataPathConfigs.LoadConcurrency.PrepareQueueLength > 0 {
|
|
if counter, err := exposer.StartVgdpCounter(s.ctx, s.mgr, s.dataPathConfigs.LoadConcurrency.PrepareQueueLength); err != nil {
|
|
s.logger.WithError(err).Warnf("Failed to start VGDP counter, VDGP loads are not constrained")
|
|
} else {
|
|
s.vgdpCounter = counter
|
|
s.logger.Infof("VGDP loads are constrained with %d", s.dataPathConfigs.LoadConcurrency.PrepareQueueLength)
|
|
}
|
|
}
|
|
|
|
var cachePVCConfig *velerotypes.CachePVC
|
|
if s.dataPathConfigs != nil && s.dataPathConfigs.CachePVCConfig != nil {
|
|
if err := s.validateCachePVCConfig(*s.dataPathConfigs.CachePVCConfig); err != nil {
|
|
s.logger.WithError(err).Warnf("Ignore cache config %v", s.dataPathConfigs.CachePVCConfig)
|
|
} else {
|
|
cachePVCConfig = s.dataPathConfigs.CachePVCConfig
|
|
s.logger.Infof("Using cache volume configs %v", s.dataPathConfigs.CachePVCConfig)
|
|
}
|
|
}
|
|
|
|
var podLabels map[string]string
|
|
if s.dataPathConfigs != nil && len(s.dataPathConfigs.PodLabels) > 0 {
|
|
podLabels = s.dataPathConfigs.PodLabels
|
|
s.logger.Infof("Using customized pod labels %+v", podLabels)
|
|
}
|
|
|
|
var podAnnotations map[string]string
|
|
if s.dataPathConfigs != nil && len(s.dataPathConfigs.PodAnnotations) > 0 {
|
|
podAnnotations = s.dataPathConfigs.PodAnnotations
|
|
s.logger.Infof("Using customized pod annotations %+v", podAnnotations)
|
|
}
|
|
|
|
var tolerations []corev1api.Toleration
|
|
if s.dataPathConfigs != nil && len(s.dataPathConfigs.Tolerations) > 0 {
|
|
tolerations = s.dataPathConfigs.Tolerations
|
|
s.logger.Infof("Using customized tolerations %+v", tolerations)
|
|
}
|
|
|
|
if s.backupRepoConfigs != nil {
|
|
s.logger.Infof("Using backup repo config %v", s.backupRepoConfigs)
|
|
} else if cachePVCConfig != nil {
|
|
s.logger.Info("Backup repo config is not provided, using default values for cache volume configs")
|
|
}
|
|
|
|
var csiSnapshotMetadataServiceConfigs *velerotypes.CSISnapshotMetadataService
|
|
if s.dataPathConfigs != nil && s.dataPathConfigs.CSISnapshotMetadataServiceConfigs != nil {
|
|
csiSnapshotMetadataServiceConfigs = s.dataPathConfigs.CSISnapshotMetadataServiceConfigs
|
|
s.logger.Infof("Using CSI snapshot metadata service config %v", s.dataPathConfigs.CSISnapshotMetadataServiceConfigs)
|
|
}
|
|
|
|
pvbReconciler := controller.NewPodVolumeBackupReconciler(
|
|
s.mgr.GetClient(),
|
|
s.mgr,
|
|
s.kubeClient,
|
|
s.dataPathMgr,
|
|
s.vgdpCounter,
|
|
s.nodeName,
|
|
s.config.dataMoverPrepareTimeout,
|
|
s.config.resourceTimeout,
|
|
podResources,
|
|
s.metrics,
|
|
s.logger,
|
|
dataMovePriorityClass,
|
|
privilegedFsBackup,
|
|
podLabels,
|
|
podAnnotations,
|
|
tolerations,
|
|
)
|
|
if err := pvbReconciler.SetupWithManager(s.mgr); err != nil {
|
|
s.logger.Fatal(err, "unable to create controller", "controller", constant.ControllerPodVolumeBackup)
|
|
}
|
|
|
|
pvrReconciler := controller.NewPodVolumeRestoreReconciler(
|
|
s.mgr.GetClient(),
|
|
s.mgr,
|
|
s.kubeClient,
|
|
s.dataPathMgr,
|
|
s.vgdpCounter,
|
|
s.nodeName,
|
|
s.config.dataMoverPrepareTimeout,
|
|
s.config.resourceTimeout,
|
|
s.backupRepoConfigs,
|
|
cachePVCConfig,
|
|
podResources,
|
|
s.logger,
|
|
dataMovePriorityClass,
|
|
privilegedFsBackup,
|
|
s.repoConfigMgr,
|
|
podLabels,
|
|
podAnnotations,
|
|
tolerations,
|
|
)
|
|
if err := pvrReconciler.SetupWithManager(s.mgr); err != nil {
|
|
s.logger.WithError(err).Fatal("Unable to create the pod volume restore controller")
|
|
}
|
|
|
|
dataUploadReconciler := controller.NewDataUploadReconciler(
|
|
s.mgr.GetClient(),
|
|
s.mgr,
|
|
s.kubeClient,
|
|
s.csiSnapshotClient.SnapshotV1(),
|
|
s.dataPathMgr,
|
|
s.vgdpCounter,
|
|
loadAffinity,
|
|
backupPVCConfig,
|
|
podResources,
|
|
clock.RealClock{},
|
|
s.nodeName,
|
|
s.config.dataMoverPrepareTimeout,
|
|
s.logger,
|
|
s.metrics,
|
|
dataMovePriorityClass,
|
|
podLabels,
|
|
podAnnotations,
|
|
csiSnapshotMetadataServiceConfigs,
|
|
tolerations,
|
|
)
|
|
if err := dataUploadReconciler.SetupWithManager(s.mgr); err != nil {
|
|
s.logger.WithError(err).Fatal("Unable to create the data upload controller")
|
|
}
|
|
|
|
var restorePVCConfig velerotypes.RestorePVC
|
|
if s.dataPathConfigs != nil && s.dataPathConfigs.RestorePVCConfig != nil {
|
|
restorePVCConfig = *s.dataPathConfigs.RestorePVCConfig
|
|
s.logger.Infof("Using customized restorePVC config %v", restorePVCConfig)
|
|
}
|
|
|
|
dataDownloadReconciler := controller.NewDataDownloadReconciler(
|
|
s.mgr.GetClient(),
|
|
s.mgr,
|
|
s.kubeClient,
|
|
s.dataPathMgr,
|
|
s.vgdpCounter,
|
|
loadAffinity,
|
|
restorePVCConfig,
|
|
s.backupRepoConfigs,
|
|
cachePVCConfig,
|
|
podResources,
|
|
s.nodeName,
|
|
s.config.dataMoverPrepareTimeout,
|
|
s.logger,
|
|
s.metrics,
|
|
dataMovePriorityClass,
|
|
s.repoConfigMgr,
|
|
podLabels,
|
|
podAnnotations,
|
|
csiSnapshotMetadataServiceConfigs,
|
|
tolerations,
|
|
)
|
|
|
|
if err := dataDownloadReconciler.SetupWithManager(s.mgr); err != nil {
|
|
s.logger.WithError(err).Fatal("Unable to create the data download controller")
|
|
}
|
|
|
|
go func() {
|
|
if err := s.waitCacheForResume(); err != nil {
|
|
s.logger.WithError(err).Error("Failed to wait cache for resume, will not resume DU/DD")
|
|
return
|
|
}
|
|
|
|
if err := dataUploadReconciler.AttemptDataUploadResume(s.ctx, s.logger.WithField("node", s.nodeName), s.namespace); err != nil {
|
|
s.logger.WithError(errors.WithStack(err)).Error("Failed to attempt data upload resume")
|
|
}
|
|
|
|
if err := dataDownloadReconciler.AttemptDataDownloadResume(s.ctx, s.logger.WithField("node", s.nodeName), s.namespace); err != nil {
|
|
s.logger.WithError(errors.WithStack(err)).Error("Failed to attempt data download resume")
|
|
}
|
|
|
|
if err := pvbReconciler.AttemptPVBResume(s.ctx, s.logger.WithField("node", s.nodeName), s.namespace); err != nil {
|
|
s.logger.WithError(errors.WithStack(err)).Error("Failed to attempt PVB resume")
|
|
}
|
|
|
|
if err := pvrReconciler.AttemptPVRResume(s.ctx, s.logger.WithField("node", s.nodeName), s.namespace); err != nil {
|
|
s.logger.WithError(errors.WithStack(err)).Error("Failed to attempt PVR resume")
|
|
}
|
|
}()
|
|
|
|
s.logger.Info("Controllers starting...")
|
|
|
|
if err := s.mgr.Start(ctrl.SetupSignalHandler()); err != nil {
|
|
s.logger.Fatal("Problem starting manager", err)
|
|
}
|
|
}
|
|
|
|
func (s *nodeAgentServer) waitCacheForResume() error {
|
|
podInformer, err := s.mgr.GetCache().GetInformer(s.ctx, &corev1api.Pod{})
|
|
if err != nil {
|
|
return errors.Wrap(err, "error getting pod informer")
|
|
}
|
|
|
|
duInformer, err := s.mgr.GetCache().GetInformer(s.ctx, &velerov2alpha1api.DataUpload{})
|
|
if err != nil {
|
|
return errors.Wrap(err, "error getting du informer")
|
|
}
|
|
|
|
ddInformer, err := s.mgr.GetCache().GetInformer(s.ctx, &velerov2alpha1api.DataDownload{})
|
|
if err != nil {
|
|
return errors.Wrap(err, "error getting dd informer")
|
|
}
|
|
|
|
pvbInformer, err := s.mgr.GetCache().GetInformer(s.ctx, &velerov1api.PodVolumeBackup{})
|
|
if err != nil {
|
|
return errors.Wrap(err, "error getting PVB informer")
|
|
}
|
|
|
|
pvrInformer, err := s.mgr.GetCache().GetInformer(s.ctx, &velerov1api.PodVolumeRestore{})
|
|
if err != nil {
|
|
return errors.Wrap(err, "error getting PVR informer")
|
|
}
|
|
|
|
if !cacheutil.WaitForCacheSync(s.ctx.Done(), podInformer.HasSynced, duInformer.HasSynced, ddInformer.HasSynced, pvbInformer.HasSynced, pvrInformer.HasSynced) {
|
|
return errors.New("error waiting informer synced")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// validatePodVolumesHostPath validates that the pod volumes path contains a
|
|
// directory for each Pod running on this node
|
|
func (s *nodeAgentServer) validatePodVolumesHostPath(client kubernetes.Interface) error {
|
|
files, err := s.fileSystem.ReadDir(nodeagent.HostPodVolumeMountPath())
|
|
if err != nil {
|
|
if errors.Is(err, os.ErrNotExist) {
|
|
s.logger.Warnf("Pod volumes host path [%s] doesn't exist, fs-backup is disabled", nodeagent.HostPodVolumeMountPath())
|
|
return nil
|
|
}
|
|
return errors.Wrap(err, "could not read pod volumes host path")
|
|
}
|
|
|
|
// create a map of directory names inside the pod volumes path
|
|
dirs := sets.NewString()
|
|
for _, f := range files {
|
|
if f.IsDir() {
|
|
dirs.Insert(f.Name())
|
|
}
|
|
}
|
|
|
|
pods, err := client.CoreV1().Pods("").List(s.ctx, metav1.ListOptions{FieldSelector: fmt.Sprintf("spec.nodeName=%s,status.phase=Running", s.nodeName)})
|
|
if err != nil {
|
|
return errors.WithStack(err)
|
|
}
|
|
|
|
valid := true
|
|
for _, pod := range pods.Items {
|
|
dirName := string(pod.GetUID())
|
|
|
|
// if the pod is a mirror pod, the directory name is the hash value of the
|
|
// mirror pod annotation
|
|
if hash, ok := pod.GetAnnotations()[corev1api.MirrorPodAnnotationKey]; ok {
|
|
dirName = hash
|
|
}
|
|
|
|
if !dirs.Has(dirName) {
|
|
valid = false
|
|
s.logger.WithFields(logrus.Fields{
|
|
"pod": fmt.Sprintf("%s/%s", pod.GetNamespace(), pod.GetName()),
|
|
"path": nodeagent.HostPodVolumeMountPath() + "/" + dirName,
|
|
}).Debug("could not find volumes for pod in host path")
|
|
}
|
|
}
|
|
|
|
if !valid {
|
|
return errors.New("unexpected directory structure for host-pods volume, ensure that the host-pods volume corresponds to the pods subdirectory of the kubelet root directory")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
var getConfigsFunc = nodeagent.GetConfigs
|
|
|
|
func (s *nodeAgentServer) getDataPathConfigs() error {
|
|
if s.config.nodeAgentConfig == "" {
|
|
s.logger.Info("No node-agent configMap is specified")
|
|
return nil
|
|
}
|
|
|
|
configs, err := getConfigsFunc(s.ctx, s.namespace, s.kubeClient, s.config.nodeAgentConfig)
|
|
if err != nil {
|
|
return errors.Wrapf(err, "error getting node agent configs from configMap %s", s.config.nodeAgentConfig)
|
|
}
|
|
|
|
s.dataPathConfigs = configs
|
|
return nil
|
|
}
|
|
|
|
func (s *nodeAgentServer) getBackupRepoConfigs() error {
|
|
if s.config.backupRepoConfig == "" {
|
|
s.logger.Info("No backup repo configMap is specified")
|
|
return nil
|
|
}
|
|
|
|
cm, err := s.kubeClient.CoreV1().ConfigMaps(s.namespace).Get(s.ctx, s.config.backupRepoConfig, metav1.GetOptions{})
|
|
if err != nil {
|
|
return errors.Wrapf(err, "error getting backup repo configs from configMap %s", s.config.backupRepoConfig)
|
|
}
|
|
|
|
if cm.Data == nil {
|
|
return errors.Errorf("no data is in the backup repo configMap %s", s.config.backupRepoConfig)
|
|
}
|
|
|
|
s.backupRepoConfigs = cm.Data
|
|
return nil
|
|
}
|
|
|
|
func (s *nodeAgentServer) getDataPathConcurrentNum(defaultNum int) int {
|
|
configs := s.dataPathConfigs
|
|
|
|
if configs == nil || configs.LoadConcurrency == nil {
|
|
s.logger.Infof("Concurrency configs are not found, use the default number %v", defaultNum)
|
|
return defaultNum
|
|
}
|
|
|
|
globalNum := configs.LoadConcurrency.GlobalConfig
|
|
|
|
if globalNum <= 0 {
|
|
s.logger.Warnf("Global number %v is invalid, use the default value %v", globalNum, defaultNum)
|
|
globalNum = defaultNum
|
|
}
|
|
|
|
if len(configs.LoadConcurrency.PerNodeConfig) == 0 {
|
|
return globalNum
|
|
}
|
|
|
|
curNode, err := s.kubeClient.CoreV1().Nodes().Get(s.ctx, s.nodeName, metav1.GetOptions{})
|
|
if err != nil {
|
|
s.logger.WithError(err).Warnf("Failed to get node info for %s, use the global number %v", s.nodeName, globalNum)
|
|
return globalNum
|
|
}
|
|
|
|
concurrentNum := math.MaxInt32
|
|
|
|
for _, rule := range configs.LoadConcurrency.PerNodeConfig {
|
|
selector, err := metav1.LabelSelectorAsSelector(&(rule.NodeSelector))
|
|
if err != nil {
|
|
s.logger.WithError(err).Warnf("Failed to parse rule with label selector %s, skip it", rule.NodeSelector.String())
|
|
continue
|
|
}
|
|
|
|
if rule.Number <= 0 {
|
|
s.logger.Warnf("Rule with label selector %s is with an invalid number %v, skip it", rule.NodeSelector.String(), rule.Number)
|
|
continue
|
|
}
|
|
|
|
if selector.Matches(labels.Set(curNode.GetLabels())) {
|
|
if concurrentNum > rule.Number {
|
|
concurrentNum = rule.Number
|
|
}
|
|
}
|
|
}
|
|
|
|
if concurrentNum == math.MaxInt32 {
|
|
s.logger.Infof("Per node number for node %s is not found, use the global number %v", s.nodeName, globalNum)
|
|
concurrentNum = globalNum
|
|
} else {
|
|
s.logger.Infof("Use the per node number %v over global number %v for node %s", concurrentNum, globalNum, s.nodeName)
|
|
}
|
|
|
|
return concurrentNum
|
|
}
|
|
|
|
func (s *nodeAgentServer) validateCachePVCConfig(config velerotypes.CachePVC) error {
|
|
if config.StorageClass == "" {
|
|
return errors.New("storage class is absent")
|
|
}
|
|
|
|
sc, err := s.kubeClient.StorageV1().StorageClasses().Get(s.ctx, config.StorageClass, metav1.GetOptions{})
|
|
if err != nil {
|
|
return errors.Wrapf(err, "error getting storage class %s", config.StorageClass)
|
|
}
|
|
|
|
if sc.ReclaimPolicy != nil && *sc.ReclaimPolicy != corev1api.PersistentVolumeReclaimDelete {
|
|
return errors.Errorf("unexpected storage class reclaim policy %v", *sc.ReclaimPolicy)
|
|
}
|
|
|
|
return nil
|
|
}
|