mirror of
https://github.com/vmware-tanzu/velero.git
synced 2026-11-08 04:18:06 +00:00
KrishhnaT
3efaa0c5ee
* e2e: finish converting the CSI feature checks to FeatureEnabled #10661 routed every check for EnableCSI through FeatureEnabled, which splits the comma-separated --features value instead of comparing the whole thing. One site was left on strings.EqualFold, because #10658 introduced it after #10661 had branched and the rebase applied cleanly without noticing. The result is that KibishiiVolumesAreHostPath and the Kind branch of installKibishii, which are inverses of each other and sit twenty-odd lines apart with comments saying so, disagree whenever a second feature is enabled. With --features=EnableCSI,EnableAPIGroupVersions on kind the mapping swaps in the CSI-backed overlay and the predicate still reports the volumes as hostPath, so the five cases install a cluster they can snapshot and then skip. Convert the last site and test the predicate against the list, case and single-feature shapes, which fails on the list cases before the change. The test would not have run in CI either: hack/test.sh listed ./test but not the other unit-testable packages under test/, so the two existing tests in this package and the five in test/pkg/client and test/util/velero were never executed. List all four. The e2e and perf suites stay out, since they call RunSpecs and need a cluster. Signed-off-by: krishhna24 <krishhnatupedev@gmail.com> * Add changelog for #10678 Signed-off-by: krishhna24 <krishhnatupedev@gmail.com> --------- Signed-off-by: krishhna24 <krishhnatupedev@gmail.com>