mirror of
https://github.com/vmware-tanzu/velero.git
synced 2026-11-08 04:18:06 +00:00
velero backup logs and velero restore logs check the phase before they create a DownloadRequest, and only go ahead for Completed, PartiallyFailed, Failed, WaitingForPluginOperations and WaitingForPluginOperationsPartiallyFailed. Finalizing and FinalizingPartiallyFailed are not on either list, so both commands answer "logs ... are not available until it's finished processing" for a backup or restore in those phases. The log is already in object storage by then. The backup controller writes it in persistBackup (PutBackup uploads the log first) before the Backup is patched out of InProgress, and the restore controller calls PutRestoreLog before it sets the WaitingForPluginOperations or Finalizing phase. Neither finalizer controller writes the log again, and the DownloadRequest controller signs URLs in both phases. Finalizing also comes after WaitingForPluginOperations, which both commands already accept, so a log that could be read while plugin operations were running becomes unreadable again until the finalizer is done. For restores that window is not short. The restore finalizer waits up to the resource timeout for restored PVCs to bind before patching their PVs, and waits for post-restore exec hooks, so a restore can stay in Finalizing for minutes, and a restore stuck there is when its log is most needed. Add the two Finalizing phases to both allowlists. The new table tests create a backup or restore in each phase and check that the phases with a log get as far as requesting it, while New, InProgress and FailedValidation are still refused. Signed-off-by: Max Freedom Pollard <272618364+MaxFreedomPollard@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
129 lines
4.4 KiB
Go
129 lines
4.4 KiB
Go
/*
|
|
Copyright the Velero contributors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package backup
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"time"
|
|
|
|
"github.com/spf13/cobra"
|
|
"github.com/spf13/pflag"
|
|
apierrors "k8s.io/apimachinery/pkg/api/errors"
|
|
kbclient "sigs.k8s.io/controller-runtime/pkg/client"
|
|
|
|
velerov1api "github.com/velero-io/velero/pkg/apis/velero/v1"
|
|
"github.com/velero-io/velero/pkg/client"
|
|
"github.com/velero-io/velero/pkg/cmd"
|
|
"github.com/velero-io/velero/pkg/cmd/cli"
|
|
"github.com/velero-io/velero/pkg/cmd/util/cacert"
|
|
"github.com/velero-io/velero/pkg/cmd/util/downloadrequest"
|
|
)
|
|
|
|
type LogsOptions struct {
|
|
Timeout time.Duration
|
|
InsecureSkipTLSVerify bool
|
|
CaCertFile string
|
|
Client kbclient.Client
|
|
BackupName string
|
|
}
|
|
|
|
func NewLogsOptions() LogsOptions {
|
|
config, err := client.LoadConfig()
|
|
if err != nil {
|
|
fmt.Fprintf(os.Stderr, "WARNING: Error reading config file: %v\n", err)
|
|
}
|
|
|
|
return LogsOptions{
|
|
Timeout: time.Minute,
|
|
InsecureSkipTLSVerify: false,
|
|
CaCertFile: config.CACertFile(),
|
|
}
|
|
}
|
|
|
|
func (l *LogsOptions) BindFlags(flags *pflag.FlagSet) {
|
|
flags.DurationVar(&l.Timeout, "timeout", l.Timeout, "How long to wait to receive logs.")
|
|
flags.BoolVar(&l.InsecureSkipTLSVerify, "insecure-skip-tls-verify", l.InsecureSkipTLSVerify, "If true, the object store's TLS certificate will not be checked for validity. This is insecure and susceptible to man-in-the-middle attacks. Not recommended for production.")
|
|
flags.StringVar(&l.CaCertFile, "cacert", l.CaCertFile, "Path to a certificate bundle to use when verifying TLS connections.")
|
|
}
|
|
|
|
func (l *LogsOptions) Run(c *cobra.Command, f client.Factory) error {
|
|
backup := new(velerov1api.Backup)
|
|
err := l.Client.Get(context.Background(), kbclient.ObjectKey{Namespace: f.Namespace(), Name: l.BackupName}, backup)
|
|
if apierrors.IsNotFound(err) {
|
|
return fmt.Errorf("backup %q does not exist", l.BackupName)
|
|
} else if err != nil {
|
|
return fmt.Errorf("error checking for backup %q: %v", l.BackupName, err)
|
|
}
|
|
|
|
switch backup.Status.Phase {
|
|
case velerov1api.BackupPhaseCompleted, velerov1api.BackupPhasePartiallyFailed, velerov1api.BackupPhaseFailed, velerov1api.BackupPhaseWaitingForPluginOperations, velerov1api.BackupPhaseWaitingForPluginOperationsPartiallyFailed, velerov1api.BackupPhaseFinalizing, velerov1api.BackupPhaseFinalizingPartiallyFailed:
|
|
// terminal, waiting for plugin operations and finalizing phases, do nothing.
|
|
// The log is uploaded before a backup enters any of the non-terminal ones.
|
|
default:
|
|
return fmt.Errorf("logs for backup %q are not available until it's finished processing, please wait "+
|
|
"until the backup has a phase of Completed or Failed and try again", l.BackupName)
|
|
}
|
|
|
|
// Get BSL cacert if available
|
|
bslCACert, err := cacert.GetCACertFromBackup(context.Background(), l.Client, f.Namespace(), backup)
|
|
if err != nil {
|
|
// Log the error but don't fail - we can still try to download without the BSL cacert
|
|
fmt.Fprintf(os.Stderr, "WARNING: Error getting cacert from BSL: %v\n", err)
|
|
bslCACert = ""
|
|
}
|
|
|
|
err = downloadrequest.StreamWithBSLCACert(context.Background(), l.Client, f.Namespace(), l.BackupName, velerov1api.DownloadTargetKindBackupLog, os.Stdout, l.Timeout, l.InsecureSkipTLSVerify, l.CaCertFile, bslCACert)
|
|
return err
|
|
}
|
|
|
|
func (l *LogsOptions) Complete(args []string, f client.Factory) error {
|
|
if len(args) > 0 {
|
|
l.BackupName = args[0]
|
|
}
|
|
|
|
kbClient, err := f.KubebuilderClient()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
l.Client = kbClient
|
|
return nil
|
|
}
|
|
|
|
func NewLogsCommand(f client.Factory) *cobra.Command {
|
|
l := NewLogsOptions()
|
|
|
|
c := &cobra.Command{
|
|
Use: "logs BACKUP",
|
|
Short: "Get backup logs",
|
|
Args: cobra.ExactArgs(1),
|
|
Run: func(c *cobra.Command, args []string) {
|
|
err := l.Complete(args, f)
|
|
cmd.CheckError(err)
|
|
|
|
err = l.Run(c, f)
|
|
cmd.CheckError(err)
|
|
},
|
|
}
|
|
|
|
c.ValidArgsFunction = cli.CompleteBackupNames(f)
|
|
l.BindFlags(c.Flags())
|
|
|
|
return c
|
|
}
|