mirror of
https://github.com/vmware-tanzu/velero.git
synced 2026-10-21 22:03:09 +00:00
KrishhnaTandGitHub
642a5bdf87
* e2e: match --features as the comma-separated list it is --features takes a comma-separated list, but every check for EnableCSI in the suite compares the whole flag value against the single feature name. With --features=EnableCSI,EnableAPIGroupVersions none of them match, so a CSI run quietly behaves as a non-CSI one: BeforeSuite skips installing the VolumeSnapshotClass, installKibishii picks the provider's plain overlay rather than its CSI one, and BuildSnapshotCheckPointFromVolumeInfo returns a checkpoint with EnableCSI false and no snapshot handles, so the CSI snapshot count is never compared against the expected one. One site already used strings.Contains instead, which handles a list but matches any feature whose name merely starts with this one, and misses a value that differs only in case. Add FeatureEnabled, which splits on commas and compares each entry whole and case-insensitively, and route all eleven call sites through it. The table test covers the list, case and prefix shapes that the two previous idioms each got wrong. hack/test.sh listed only ./pkg/..., ./internal/... and ./cmd/..., so nothing under test/ was ever unit tested and this table would not have run in CI. Add ./test, which holds the suite's shared types and nothing that needs a cluster. The e2e suites live in subpackages and stay unlisted. Found while reviewing the kind-csi mapping in #10657, which copied the EqualFold form from the Azure and AWS branches beside it. Signed-off-by: krishhna24 <krishhnatupedev@gmail.com> * Add changelog for #10661 Signed-off-by: krishhna24 <krishhnatupedev@gmail.com> --------- Signed-off-by: krishhna24 <krishhnatupedev@gmail.com>