Files
velero/pkg/label/label_test.go
Xun Jiang/Bruce Jiang 82367e7ff6 Fix the Job build error when BackupReposiotry name longer than 63. (#9350)
* Fix the Job build error when BackupReposiotry name longer than 63.

Fix the Job build error.
Consider the name length limitation change in job list code.
Use hash to replace the GetValidName function.

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>

* Use ref_name to replace ref.

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>

---------

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
2025-11-11 12:56:27 -05:00

86 lines
2.4 KiB
Go

/*
Copyright 2019 the Velero contributors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package label
import (
"testing"
"github.com/stretchr/testify/assert"
)
func TestGetValidLabelName(t *testing.T) {
tests := []struct {
name string
label string
expectedLabel string
}{
{
name: "valid label name should not be modified",
label: "short label value",
expectedLabel: "short label value",
},
{
name: "label with more than 63 characters should be modified",
label: "this_is_a_very_long_label_value_that_will_be_rejected_by_Kubernetes",
expectedLabel: "this_is_a_very_long_label_value_that_will_be_rejected_by_8d0722",
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
labelVal := GetValidName(test.label)
assert.Equal(t, test.expectedLabel, labelVal)
})
}
}
func TestReturnNameOrHash(t *testing.T) {
tests := []struct {
name string
label string
expectedLabel string
}{
{
name: "valid label name should not be modified",
label: "short label value",
expectedLabel: "short label value",
},
{
name: "label with more than 63 characters should be modified",
label: "this_is_a_very_long_label_value_that_will_be_rejected_by_Kubernetes",
expectedLabel: "1a7399f2d00e268fc12daf431d6667319d1461e2609981070bb7e85c",
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
labelVal := ReturnNameOrHash(test.label)
assert.Equal(t, test.expectedLabel, labelVal)
})
}
}
func TestNewSelectorForBackup(t *testing.T) {
selector := NewSelectorForBackup("my-backup")
assert.Equal(t, "velero.io/backup-name=my-backup", selector.String())
}
func TestNewListOptionsForBackup(t *testing.T) {
option := NewListOptionsForBackup("my-backup")
assert.Equal(t, "velero.io/backup-name=my-backup", option.LabelSelector)
}