mirror of
https://github.com/vmware-tanzu/velero.git
synced 2026-01-08 14:21:18 +00:00
* Use Credential from BSL for restic commands This change introduces support for restic to make use of per-BSL credentials. It makes use of the `credentials.FileStore` introduced in PR #3442 to write the BSL credentials to disk. To support per-BSL credentials for restic, the environment for the restic commands needs to be modified for each provider to ensure that the credentials are provided via the correct provider specific environment variables. This change introduces a new function `restic.CmdEnv` to check the BSL provider and create the correct mapping of environment variables for each provider. Previously, AWS and GCP could rely on the environment variables in the Velero deployments to obtain the credentials file, but now these environment variables need to be set with the path to the serialized credentials file if a credential is set on the BSL. For Azure, the credentials file in the environment was loaded and parsed to set the environment variables for restic. Now, we check if the BSL has a credential, and if it does, load and parse that file instead. This change also introduces a few other small improvements. Now that we are fetching the BSL to check for the `Credential` field, we can use the BSL directly to get the `CACert` which means that we can remove the `GetCACert` function. Also, now that we have a way to serialize secrets to disk, we can use the `credentials.FileStore` to get a temp file for the restic repo password and remove the `restic.TempCredentialsFile` function. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com> * Add documentation for per-BSL credentials Signed-off-by: Bridget McErlean <bmcerlean@vmware.com> * Address review feedback Signed-off-by: Bridget McErlean <bmcerlean@vmware.com> * Address review comments Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
281 lines
9.6 KiB
Go
281 lines
9.6 KiB
Go
/*
|
|
Copyright the Velero contributors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package restic
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
|
|
"github.com/pkg/errors"
|
|
"github.com/sirupsen/logrus"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
corev1client "k8s.io/client-go/kubernetes/typed/core/v1"
|
|
"k8s.io/client-go/tools/cache"
|
|
|
|
kbclient "sigs.k8s.io/controller-runtime/pkg/client"
|
|
|
|
"github.com/vmware-tanzu/velero/internal/credentials"
|
|
velerov1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"
|
|
clientset "github.com/vmware-tanzu/velero/pkg/generated/clientset/versioned"
|
|
velerov1client "github.com/vmware-tanzu/velero/pkg/generated/clientset/versioned/typed/velero/v1"
|
|
velerov1informers "github.com/vmware-tanzu/velero/pkg/generated/informers/externalversions/velero/v1"
|
|
velerov1listers "github.com/vmware-tanzu/velero/pkg/generated/listers/velero/v1"
|
|
veleroexec "github.com/vmware-tanzu/velero/pkg/util/exec"
|
|
"github.com/vmware-tanzu/velero/pkg/util/filesystem"
|
|
)
|
|
|
|
// RepositoryManager executes commands against restic repositories.
|
|
type RepositoryManager interface {
|
|
// InitRepo initializes a repo with the specified name and identifier.
|
|
InitRepo(repo *velerov1api.ResticRepository) error
|
|
|
|
// ConnectToRepo runs the 'restic snapshots' command against the
|
|
// specified repo, and returns an error if it fails. This is
|
|
// intended to be used to ensure that the repo exists/can be
|
|
// authenticated to.
|
|
ConnectToRepo(repo *velerov1api.ResticRepository) error
|
|
|
|
// PruneRepo deletes unused data from a repo.
|
|
PruneRepo(repo *velerov1api.ResticRepository) error
|
|
|
|
// UnlockRepo removes stale locks from a repo.
|
|
UnlockRepo(repo *velerov1api.ResticRepository) error
|
|
|
|
// Forget removes a snapshot from the list of
|
|
// available snapshots in a repo.
|
|
Forget(context.Context, SnapshotIdentifier) error
|
|
|
|
BackupperFactory
|
|
|
|
RestorerFactory
|
|
}
|
|
|
|
// BackupperFactory can construct restic backuppers.
|
|
type BackupperFactory interface {
|
|
// NewBackupper returns a restic backupper for use during a single
|
|
// Velero backup.
|
|
NewBackupper(context.Context, *velerov1api.Backup) (Backupper, error)
|
|
}
|
|
|
|
// RestorerFactory can construct restic restorers.
|
|
type RestorerFactory interface {
|
|
// NewRestorer returns a restic restorer for use during a single
|
|
// Velero restore.
|
|
NewRestorer(context.Context, *velerov1api.Restore) (Restorer, error)
|
|
}
|
|
|
|
type repositoryManager struct {
|
|
namespace string
|
|
veleroClient clientset.Interface
|
|
repoLister velerov1listers.ResticRepositoryLister
|
|
repoInformerSynced cache.InformerSynced
|
|
kbClient kbclient.Client
|
|
log logrus.FieldLogger
|
|
repoLocker *repoLocker
|
|
repoEnsurer *repositoryEnsurer
|
|
fileSystem filesystem.Interface
|
|
ctx context.Context
|
|
pvcClient corev1client.PersistentVolumeClaimsGetter
|
|
pvClient corev1client.PersistentVolumesGetter
|
|
credentialsFileStore credentials.FileStore
|
|
}
|
|
|
|
// NewRepositoryManager constructs a RepositoryManager.
|
|
func NewRepositoryManager(
|
|
ctx context.Context,
|
|
namespace string,
|
|
veleroClient clientset.Interface,
|
|
repoInformer velerov1informers.ResticRepositoryInformer,
|
|
repoClient velerov1client.ResticRepositoriesGetter,
|
|
kbClient kbclient.Client,
|
|
pvcClient corev1client.PersistentVolumeClaimsGetter,
|
|
pvClient corev1client.PersistentVolumesGetter,
|
|
credentialFileStore credentials.FileStore,
|
|
log logrus.FieldLogger,
|
|
) (RepositoryManager, error) {
|
|
rm := &repositoryManager{
|
|
namespace: namespace,
|
|
veleroClient: veleroClient,
|
|
repoLister: repoInformer.Lister(),
|
|
repoInformerSynced: repoInformer.Informer().HasSynced,
|
|
kbClient: kbClient,
|
|
pvcClient: pvcClient,
|
|
pvClient: pvClient,
|
|
credentialsFileStore: credentialFileStore,
|
|
log: log,
|
|
ctx: ctx,
|
|
|
|
repoLocker: newRepoLocker(),
|
|
repoEnsurer: newRepositoryEnsurer(repoInformer, repoClient, log),
|
|
fileSystem: filesystem.NewFileSystem(),
|
|
}
|
|
|
|
return rm, nil
|
|
}
|
|
|
|
func (rm *repositoryManager) NewBackupper(ctx context.Context, backup *velerov1api.Backup) (Backupper, error) {
|
|
informer := velerov1informers.NewFilteredPodVolumeBackupInformer(
|
|
rm.veleroClient,
|
|
backup.Namespace,
|
|
0,
|
|
cache.Indexers{cache.NamespaceIndex: cache.MetaNamespaceIndexFunc},
|
|
func(opts *metav1.ListOptions) {
|
|
opts.LabelSelector = fmt.Sprintf("%s=%s", velerov1api.BackupUIDLabel, backup.UID)
|
|
},
|
|
)
|
|
|
|
b := newBackupper(ctx, rm, rm.repoEnsurer, informer, rm.pvcClient, rm.pvClient, rm.log)
|
|
|
|
go informer.Run(ctx.Done())
|
|
if !cache.WaitForCacheSync(ctx.Done(), informer.HasSynced, rm.repoInformerSynced) {
|
|
return nil, errors.New("timed out waiting for caches to sync")
|
|
}
|
|
|
|
return b, nil
|
|
}
|
|
|
|
func (rm *repositoryManager) NewRestorer(ctx context.Context, restore *velerov1api.Restore) (Restorer, error) {
|
|
informer := velerov1informers.NewFilteredPodVolumeRestoreInformer(
|
|
rm.veleroClient,
|
|
restore.Namespace,
|
|
0,
|
|
cache.Indexers{cache.NamespaceIndex: cache.MetaNamespaceIndexFunc},
|
|
func(opts *metav1.ListOptions) {
|
|
opts.LabelSelector = fmt.Sprintf("%s=%s", velerov1api.RestoreUIDLabel, restore.UID)
|
|
},
|
|
)
|
|
|
|
r := newRestorer(ctx, rm, rm.repoEnsurer, informer, rm.log)
|
|
|
|
go informer.Run(ctx.Done())
|
|
if !cache.WaitForCacheSync(ctx.Done(), informer.HasSynced, rm.repoInformerSynced) {
|
|
return nil, errors.New("timed out waiting for cache to sync")
|
|
}
|
|
|
|
return r, nil
|
|
}
|
|
|
|
func (rm *repositoryManager) InitRepo(repo *velerov1api.ResticRepository) error {
|
|
// restic init requires an exclusive lock
|
|
rm.repoLocker.LockExclusive(repo.Name)
|
|
defer rm.repoLocker.UnlockExclusive(repo.Name)
|
|
|
|
return rm.exec(InitCommand(repo.Spec.ResticIdentifier), repo.Spec.BackupStorageLocation)
|
|
}
|
|
|
|
func (rm *repositoryManager) ConnectToRepo(repo *velerov1api.ResticRepository) error {
|
|
// restic snapshots requires a non-exclusive lock
|
|
rm.repoLocker.Lock(repo.Name)
|
|
defer rm.repoLocker.Unlock(repo.Name)
|
|
|
|
snapshotsCmd := SnapshotsCommand(repo.Spec.ResticIdentifier)
|
|
// use the '--last' flag to minimize the amount of data fetched since
|
|
// we're just validating that the repo exists and can be authenticated
|
|
// to.
|
|
snapshotsCmd.ExtraFlags = append(snapshotsCmd.ExtraFlags, "--last")
|
|
|
|
return rm.exec(snapshotsCmd, repo.Spec.BackupStorageLocation)
|
|
}
|
|
|
|
func (rm *repositoryManager) PruneRepo(repo *velerov1api.ResticRepository) error {
|
|
// restic prune requires an exclusive lock
|
|
rm.repoLocker.LockExclusive(repo.Name)
|
|
defer rm.repoLocker.UnlockExclusive(repo.Name)
|
|
|
|
return rm.exec(PruneCommand(repo.Spec.ResticIdentifier), repo.Spec.BackupStorageLocation)
|
|
}
|
|
|
|
func (rm *repositoryManager) UnlockRepo(repo *velerov1api.ResticRepository) error {
|
|
// restic unlock requires a non-exclusive lock
|
|
rm.repoLocker.Lock(repo.Name)
|
|
defer rm.repoLocker.Unlock(repo.Name)
|
|
|
|
return rm.exec(UnlockCommand(repo.Spec.ResticIdentifier), repo.Spec.BackupStorageLocation)
|
|
}
|
|
|
|
func (rm *repositoryManager) Forget(ctx context.Context, snapshot SnapshotIdentifier) error {
|
|
// We can't wait for this in the constructor, because this informer is coming
|
|
// from the shared informer factory, which isn't started until *after* the repo
|
|
// manager is instantiated & passed to the controller constructors. We'd get a
|
|
// deadlock if we tried to wait for this in the constructor.
|
|
if !cache.WaitForCacheSync(ctx.Done(), rm.repoInformerSynced) {
|
|
return errors.New("timed out waiting for cache to sync")
|
|
}
|
|
|
|
repo, err := rm.repoEnsurer.EnsureRepo(ctx, rm.namespace, snapshot.VolumeNamespace, snapshot.BackupStorageLocation)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// restic forget requires an exclusive lock
|
|
rm.repoLocker.LockExclusive(repo.Name)
|
|
defer rm.repoLocker.UnlockExclusive(repo.Name)
|
|
|
|
return rm.exec(ForgetCommand(repo.Spec.ResticIdentifier, snapshot.SnapshotID), repo.Spec.BackupStorageLocation)
|
|
}
|
|
|
|
func (rm *repositoryManager) exec(cmd *Command, backupLocation string) error {
|
|
file, err := rm.credentialsFileStore.Path(RepoKeySelector())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
// ignore error since there's nothing we can do and it's a temp file.
|
|
defer os.Remove(file)
|
|
|
|
cmd.PasswordFile = file
|
|
|
|
loc := &velerov1api.BackupStorageLocation{}
|
|
if err := rm.kbClient.Get(context.Background(), kbclient.ObjectKey{
|
|
Namespace: rm.namespace,
|
|
Name: backupLocation,
|
|
}, loc); err != nil {
|
|
return errors.Wrap(err, "error getting backup storage location")
|
|
}
|
|
|
|
// if there's a caCert on the ObjectStorage, write it to disk so that it can be passed to restic
|
|
var caCertFile string
|
|
if loc.Spec.ObjectStorage != nil && loc.Spec.ObjectStorage.CACert != nil {
|
|
caCertFile, err = TempCACertFile(loc.Spec.ObjectStorage.CACert, backupLocation, rm.fileSystem)
|
|
if err != nil {
|
|
return errors.Wrap(err, "error creating temp cacert file")
|
|
}
|
|
// ignore error since there's nothing we can do and it's a temp file.
|
|
defer os.Remove(caCertFile)
|
|
}
|
|
cmd.CACertFile = caCertFile
|
|
|
|
env, err := CmdEnv(loc, rm.credentialsFileStore)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
cmd.Env = env
|
|
|
|
stdout, stderr, err := veleroexec.RunCommand(cmd.Cmd())
|
|
rm.log.WithFields(logrus.Fields{
|
|
"repository": cmd.RepoName(),
|
|
"command": cmd.String(),
|
|
"stdout": stdout,
|
|
"stderr": stderr,
|
|
}).Debugf("Ran restic command")
|
|
if err != nil {
|
|
return errors.Wrapf(err, "error running command=%s, stdout=%s, stderr=%s", cmd.String(), stdout, stderr)
|
|
}
|
|
|
|
return nil
|
|
}
|