mirror of
https://github.com/vmware-tanzu/velero.git
synced 2026-09-13 11:34:54 +00:00
Run the E2E test on kind / setup-test-matrix (push) Failing after 4s
e2e-test-kind.yaml / extract (push) Failing after 9s
Run the E2E test on kind / get-go-version (push) Failing after 10s
Run the E2E test on kind / build (push) Skipped
Run the E2E test on kind / run-e2e-test (push) Skipped
push.yml / extract (push) Failing after 5s
Main CI / get-go-version (push) Failing after 6s
Main CI / Build (push) Skipped
* Add structured JSON output for velero restore describe command Signed-off-by: Prasad Joshi <prajoshi@redhat.com> * Add changelog for PR 9983 Signed-off-by: Prasad Joshi <prajoshi@redhat.com> * Fix CSI snapshot restore JSON output to distinguish snapshot vs dataMovement type Signed-off-by: Prasad Joshi <prajoshi@redhat.com> * Remove the redundant details wrapper key from podVolumeRestores so phase counts sit flat alongside uploaderType, matching the plaintext output structure. Signed-off-by: Prasad Joshi <prajoshi@redhat.com> * Add missing resourcePolicy to json struct Signed-off-by: Prasad Joshi <prajoshi@redhat.com> * Fix linter issue Signed-off-by: Prasad Joshi <prajoshi@redhat.com> * fix codecoverage Signed-off-by: Prasad Joshi <prajoshi@redhat.com> * Handle nil CSI snapshot fields in restore JSON describe Signed-off-by: Prasad Joshi <prajoshi@redhat.com> * Fix lint issue Signed-off-by: Prasad Joshi <prajoshi@redhat.com> --------- Signed-off-by: Prasad Joshi <prajoshi@redhat.com> Co-authored-by: lyndon-li <98304688+Lyndon-Li@users.noreply.github.com> Co-authored-by: Tiger Kaovilai <tkaovila@redhat.com>
117 lines
4.5 KiB
Go
117 lines
4.5 KiB
Go
/*
|
|
Copyright the Velero contributors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package restore
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
|
|
"github.com/spf13/cobra"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/labels"
|
|
controllerclient "sigs.k8s.io/controller-runtime/pkg/client"
|
|
|
|
velerov1api "github.com/vmware-tanzu/velero/pkg/apis/velero/v1"
|
|
"github.com/vmware-tanzu/velero/pkg/client"
|
|
"github.com/vmware-tanzu/velero/pkg/cmd"
|
|
"github.com/vmware-tanzu/velero/pkg/cmd/cli"
|
|
"github.com/vmware-tanzu/velero/pkg/cmd/util/output"
|
|
"github.com/vmware-tanzu/velero/pkg/label"
|
|
)
|
|
|
|
func NewDescribeCommand(f client.Factory, use string) *cobra.Command {
|
|
var (
|
|
listOptions metav1.ListOptions
|
|
details bool
|
|
insecureSkipTLSVerify bool
|
|
outputFormat = "plaintext"
|
|
)
|
|
|
|
config, err := client.LoadConfig()
|
|
if err != nil {
|
|
fmt.Fprintf(os.Stderr, "WARNING: Error reading config file: %v\n", err)
|
|
}
|
|
caCertFile := config.CACertFile()
|
|
|
|
c := &cobra.Command{
|
|
Use: use + " [NAME1] [NAME2] [NAME...]",
|
|
Short: "Describe restores",
|
|
Run: func(c *cobra.Command, args []string) {
|
|
kbClient, err := f.KubebuilderClient()
|
|
cmd.CheckError(err)
|
|
|
|
if outputFormat != "plaintext" && outputFormat != "json" {
|
|
cmd.CheckError(fmt.Errorf("invalid output format '%s'. valid values are 'plaintext' and 'json'", outputFormat))
|
|
}
|
|
|
|
restoreList := new(velerov1api.RestoreList)
|
|
if len(args) > 0 {
|
|
for _, name := range args {
|
|
restore := new(velerov1api.Restore)
|
|
err := kbClient.Get(context.TODO(), controllerclient.ObjectKey{Namespace: f.Namespace(), Name: name}, restore)
|
|
cmd.CheckError(err)
|
|
restoreList.Items = append(restoreList.Items, *restore)
|
|
}
|
|
} else {
|
|
parsedSelector, err := labels.Parse(listOptions.LabelSelector)
|
|
cmd.CheckError(err)
|
|
|
|
err = kbClient.List(context.TODO(), restoreList, &controllerclient.ListOptions{LabelSelector: parsedSelector, Namespace: f.Namespace()})
|
|
cmd.CheckError(err)
|
|
}
|
|
|
|
first := true
|
|
for i, restore := range restoreList.Items {
|
|
podVolumeRestoreList := new(velerov1api.PodVolumeRestoreList)
|
|
err = kbClient.List(context.TODO(), podVolumeRestoreList, &controllerclient.ListOptions{
|
|
Namespace: f.Namespace(),
|
|
LabelSelector: labels.SelectorFromSet(map[string]string{velerov1api.RestoreNameLabel: label.GetValidName(restore.Name)}),
|
|
})
|
|
if err != nil {
|
|
fmt.Fprintf(os.Stderr, "error getting PodVolumeRestores for restore %s: %v\n", restore.Name, err)
|
|
}
|
|
|
|
// structured output only applies to a single restore in case of OOM
|
|
// To describe a list of restores in structured format, iterate and describe one at a time.
|
|
if len(restoreList.Items) == 1 && outputFormat != "plaintext" {
|
|
s := output.DescribeRestoreInSF(context.Background(), kbClient, &restoreList.Items[i], podVolumeRestoreList.Items, details, insecureSkipTLSVerify, caCertFile, outputFormat)
|
|
fmt.Print(s)
|
|
} else {
|
|
s := output.DescribeRestore(context.Background(), kbClient, &restoreList.Items[i], podVolumeRestoreList.Items, details, insecureSkipTLSVerify, caCertFile)
|
|
if first {
|
|
first = false
|
|
fmt.Print(s)
|
|
} else {
|
|
fmt.Printf("\n\n%s", s)
|
|
}
|
|
}
|
|
}
|
|
cmd.CheckError(err)
|
|
},
|
|
}
|
|
|
|
c.ValidArgsFunction = cli.CompleteRestoreNames(f)
|
|
c.Flags().StringVarP(&listOptions.LabelSelector, "selector", "l", listOptions.LabelSelector, "Only show items matching this label selector.")
|
|
c.Flags().BoolVar(&details, "details", details, "Display additional detail in the command output.")
|
|
c.Flags().BoolVar(&insecureSkipTLSVerify, "insecure-skip-tls-verify", insecureSkipTLSVerify, "If true, the object store's TLS certificate will not be checked for validity. This is insecure and susceptible to man-in-the-middle attacks. Not recommended for production.")
|
|
c.Flags().StringVar(&caCertFile, "cacert", caCertFile, "Path to a certificate bundle to use when verifying TLS connections.")
|
|
c.Flags().StringVarP(&outputFormat, "output", "o", outputFormat, "Output display format. Valid formats are 'plaintext' and 'json'. 'json' only applies to a single restore")
|
|
|
|
return c
|
|
}
|