Prasad JoshiandGitHub b60fb22929 fix: defer VGS cleanup until backup finalization (#10612) ...

* fix: defer VGS cleanup until backup finalization

The CSI PVC backup action deleted the VolumeGroupSnapshot and bound
VolumeGroupSnapshotContent after creating and waiting for all group
member VolumeSnapshots. At that point, Velero had not necessarily
completed processing the member VolumeSnapshots, CSI async operations,
or archive finalization.

Deleting the VGS triggered external-snapshotter member cleanup and could
remove VolumeSnapshot API objects still referenced by the Backup
workflow.

Remove immediate VGS/VGSC deletion from getVolumeSnapshotReference and
retain the group until the Backup reaches a terminal phase. Continue
processing VGS member VolumeSnapshots through the existing normal CSI
finalization path.

Add the velero.io/volume-group-snapshot-cleanup Backup finalizer before
VGS creation. Label VGSC resources with the Backup name and UID, enforce
DeletionPolicy=Retain before cleanup, and delete VGS/VGSC resources from
terminal Backup reconciliation only.

Make cleanup idempotent and retryable, including recovery of labeled
orphan VGSC resources. Remove the Backup finalizer only after VGS/VGSC
cleanup verification succeeds. Block Backup deletion while cleanup is
pending.

Add unit and controller integration tests covering finalizer
registration, VGS creation, terminal cleanup, failed-Backup cleanup,
orphan VGSC cleanup, and finalizer removal.

Signed-off-by: Prasad Joshi <prajoshi@redhat.com>

* add changelog

Signed-off-by: Prasad Joshi <prajoshi@redhat.com>

* Adress review feedback

Signed-off-by: Prasad Joshi <prajoshi@redhat.com>

* remove stale VGS finalizer during snapshot restore

Signed-off-by: Prasad Joshi <prajoshi@redhat.com>

* Improve codecoverage

Signed-off-by: Prasad Joshi <prajoshi@redhat.com>

* explain VGS member snapshot cleanup timing

Signed-off-by: Prasad Joshi <prajoshi@redhat.com>

* Second pass at review comment

Signed-off-by: Prasad Joshi <prajoshi@redhat.com>

* Third pass at review comment

Signed-off-by: Prasad Joshi <prajoshi@redhat.com>

* Dont swallow get errors

Signed-off-by: Prasad Joshi <prajoshi@redhat.com>

* Patch backup CR only when annotation is missing

Signed-off-by: Prasad Joshi <prajoshi@redhat.com>

---------

Signed-off-by: Prasad Joshi <prajoshi@redhat.com>

2026-10-01 12:57:32 -04:00

..

backup_controller_test.go

Dedup the entries in backuprequest.spec.excludeNamespaces (#10562)

2026-09-24 15:02:47 +08:00

backup_controller.go

Dedup the entries in backuprequest.spec.excludeNamespaces (#10562)

2026-09-24 15:02:47 +08:00

backup_deletion_controller_test.go

Add operation context to user-facing error messages

2026-09-02 15:38:36 +08:00

backup_deletion_controller.go

fix: defer VGS cleanup until backup finalization (#10612)

2026-10-01 12:57:32 -04:00

backup_finalizer_controller_test.go

fix: defer VGS cleanup until backup finalization (#10612)

2026-10-01 12:57:32 -04:00

backup_finalizer_controller.go

fix: defer VGS cleanup until backup finalization (#10612)

2026-10-01 12:57:32 -04:00

backup_operations_controller_test.go

bump up kopia to v0.21.1

2025-07-22 15:56:04 +08:00

backup_operations_controller.go

Replace github.com/pkg/errors by github.com/cockroachdb/errors

2026-06-10 15:55:57 +08:00

backup_queue_controller_test.go

Fix backup queue permanently stuck when a dequeued backup completes during the patch (#10521)

2026-09-16 20:34:20 +08:00

backup_queue_controller.go

Fix backup queue permanently stuck when a dequeued backup completes during the patch (#10521)

2026-09-16 20:34:20 +08:00

backup_repository_controller_test.go

fix(controller): propagate context in backup repository BSL invalidation (#10605)

2026-09-29 18:00:41 -04:00

backup_repository_controller.go

fix(controller): propagate context in backup repository BSL invalidation (#10605)

2026-09-29 18:00:41 -04:00

backup_storage_location_controller_test.go

Replace github.com/pkg/errors by github.com/cockroachdb/errors

2026-06-10 15:55:57 +08:00

backup_storage_location_controller.go

Replace github.com/pkg/errors by github.com/cockroachdb/errors

2026-06-10 15:55:57 +08:00

backup_sync_controller_test.go

test: resolve remaining Ginkgo V2 and Gomega anti-patterns (#10440)

2026-09-01 06:43:04 +05:30

backup_sync_controller.go

Only sync finished backups from object storage

2026-08-20 10:37:41 +08:00

backup_tracker_test.go

update license headers to Velero contributors (#1302)

2019-03-20 12:32:48 -07:00

backup_tracker.go

Track running backup count via BackupTracker

2025-12-02 17:23:47 -05:00

data_download_controller_test.go

Move the progress messages to activities (#10552)

2026-09-22 14:24:05 +08:00

data_download_controller.go

Move the progress messages to activities (#10552)

2026-09-22 14:24:05 +08:00

data_upload_controller_test.go

Move the progress messages to activities (#10552)

2026-09-22 14:24:05 +08:00

data_upload_controller.go

Move the progress messages to activities (#10552)

2026-09-22 14:24:05 +08:00

download_request_controller_test.go

Bump Ginkgo to v2.

2024-07-17 15:31:23 +08:00

download_request_controller.go

Skip signing a download URL when no artifacts can exist yet (#10252)

2026-08-21 17:26:21 +08:00

download_request_phase_test.go

Embed CRD manifests via go:embed instead of codegen (#10329)

2026-08-24 14:17:25 -04:00

gc_controller_test.go

Fix missing gcFailureBSLUnavailable label during garbage collection (#10154)

2026-08-04 13:06:45 -04:00

gc_controller.go

Fix missing gcFailureBSLUnavailable label during garbage collection (#10154)

2026-08-04 13:06:45 -04:00

interface.go

update license headers to Velero contributors (#1302)

2019-03-20 12:32:48 -07:00

pod_volume_backup_controller_test.go

Move the progress messages to activities (#10552)

2026-09-22 14:24:05 +08:00

pod_volume_backup_controller.go

Move the progress messages to activities (#10552)

2026-09-22 14:24:05 +08:00

pod_volume_restore_controller_test.go

Move the progress messages to activities (#10552)

2026-09-22 14:24:05 +08:00

pod_volume_restore_controller.go

Move the progress messages to activities (#10552)

2026-09-22 14:24:05 +08:00

restore_controller_test.go

Update code to support namespace mapping when perform the in-place restore with block data mover (#10461)

2026-09-16 15:16:29 +08:00

restore_controller.go

Update code to support namespace mapping when perform the in-place restore with block data mover (#10461)

2026-09-16 15:16:29 +08:00

restore_finalizer_controller_test.go

Detect VolumeGroupSnapshot API version at runtime (v1/v1beta2/v1beta1) (#10601)

2026-09-29 11:51:42 -04:00

restore_finalizer_controller.go

Detect VolumeGroupSnapshot API version at runtime (v1/v1beta2/v1beta1) (#10601)

2026-09-29 11:51:42 -04:00

restore_operations_controller_test.go

bump up kopia to v0.21.1

2025-07-22 15:56:04 +08:00

restore_operations_controller.go

Replace github.com/pkg/errors by github.com/cockroachdb/errors

2026-06-10 15:55:57 +08:00

schedule_controller_test.go

Fix schedule reconciler aliasing server-wide skipImmediately default (#10242)

2026-08-14 16:18:00 +08:00

schedule_controller.go

Fix schedule reconciler to compare SkipImmediately and LastSkipped by value (#10490)

2026-09-16 17:00:29 -04:00

schedule_patch_threshold_test.go

Fix schedule reconciler to compare SkipImmediately and LastSkipped by value (#10490)

2026-09-16 17:00:29 -04:00

server_status_request_controller_test.go

test: resolve remaining Ginkgo V2 and Gomega anti-patterns (#10440)

2026-09-01 06:43:04 +05:30

server_status_request_controller.go

Replace github.com/pkg/errors by github.com/cockroachdb/errors

2026-06-10 15:55:57 +08:00

suite_test.go

Bump Ginkgo to v2.

2024-07-17 15:31:23 +08:00