4 people f40112aedf Fix schedule reconciler to compare SkipImmediately and LastSkipped by value (#10490) ...

* Fix schedule reconciler to compare SkipImmediately and LastSkipped by value

The reconciler compared spec.skipImmediately (*bool) and
status.lastSkipped (*metav1.Time) between the live object and its
DeepCopy by pointer, so both checks always reported a change once the
fields were set, and every reconcile issued a redundant Patch. Compare
by value instead (ptr.Equal / equality.Semantic.DeepEqual) and add a
regression test pinning that the skip-once flip persists with exactly
one patch, later reconciles of persisted state patch zero times, and
an explicit false is a no-op.

Signed-off-by: HeonJe LEE <lhjnano@gmail.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: lyndon-li <98304688+Lyndon-Li@users.noreply.github.com>

---------

Signed-off-by: HeonJe LEE <lhjnano@gmail.com>
Signed-off-by: lyndon-li <98304688+Lyndon-Li@users.noreply.github.com>
Co-authored-by: lyndon-li <98304688+Lyndon-Li@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

2026-09-16 17:00:29 -04:00

..

backup_controller_test.go

Add operation context to user-facing error messages

2026-09-02 15:38:36 +08:00

backup_controller.go

Add MustIncludeAdditionalItemPVCs to help track BIA added PVC's PVB creation. (#10501)

2026-09-09 14:04:57 +08:00

backup_deletion_controller_test.go

Add operation context to user-facing error messages

2026-09-02 15:38:36 +08:00

backup_deletion_controller.go

Add operation context to user-facing error messages

2026-09-02 15:38:36 +08:00

backup_finalizer_controller_test.go

bump up kopia to v0.21.1

2025-07-22 15:56:04 +08:00

backup_finalizer_controller.go

Add MustIncludeAdditionalItemPVCs to help track BIA added PVC's PVB creation. (#10501)

2026-09-09 14:04:57 +08:00

backup_operations_controller_test.go

bump up kopia to v0.21.1

2025-07-22 15:56:04 +08:00

backup_operations_controller.go

Replace github.com/pkg/errors by github.com/cockroachdb/errors

2026-06-10 15:55:57 +08:00

backup_queue_controller_test.go

Fix backup queue permanently stuck when a dequeued backup completes during the patch (#10521)

2026-09-16 20:34:20 +08:00

backup_queue_controller.go

Fix backup queue permanently stuck when a dequeued backup completes during the patch (#10521)

2026-09-16 20:34:20 +08:00

backup_repository_controller_test.go

issue 9428: incremental repo maintenance history queue length

2026-04-09 14:41:07 +08:00

backup_repository_controller.go

Replace github.com/pkg/errors by github.com/cockroachdb/errors

2026-06-10 15:55:57 +08:00

backup_storage_location_controller_test.go

Replace github.com/pkg/errors by github.com/cockroachdb/errors

2026-06-10 15:55:57 +08:00

backup_storage_location_controller.go

Replace github.com/pkg/errors by github.com/cockroachdb/errors

2026-06-10 15:55:57 +08:00

backup_sync_controller_test.go

test: resolve remaining Ginkgo V2 and Gomega anti-patterns (#10440)

2026-09-01 06:43:04 +05:30

backup_sync_controller.go

Only sync finished backups from object storage

2026-08-20 10:37:41 +08:00

backup_tracker_test.go

update license headers to Velero contributors (#1302)

2019-03-20 12:32:48 -07:00

backup_tracker.go

Track running backup count via BackupTracker

2025-12-02 17:23:47 -05:00

data_download_controller_test.go

Add configurable tolerations for PodVolumeBackup and data mover pods (#9575)

2026-09-14 18:05:01 -04:00

data_download_controller.go

Add configurable tolerations for PodVolumeBackup and data mover pods (#9575)

2026-09-14 18:05:01 -04:00

data_upload_controller_test.go

Add configurable tolerations for PodVolumeBackup and data mover pods (#9575)

2026-09-14 18:05:01 -04:00

data_upload_controller.go

Add configurable tolerations for PodVolumeBackup and data mover pods (#9575)

2026-09-14 18:05:01 -04:00

download_request_controller_test.go

Bump Ginkgo to v2.

2024-07-17 15:31:23 +08:00

download_request_controller.go

Skip signing a download URL when no artifacts can exist yet (#10252)

2026-08-21 17:26:21 +08:00

download_request_phase_test.go

Embed CRD manifests via go:embed instead of codegen (#10329)

2026-08-24 14:17:25 -04:00

gc_controller_test.go

Fix missing gcFailureBSLUnavailable label during garbage collection (#10154)

2026-08-04 13:06:45 -04:00

gc_controller.go

Fix missing gcFailureBSLUnavailable label during garbage collection (#10154)

2026-08-04 13:06:45 -04:00

interface.go

update license headers to Velero contributors (#1302)

2019-03-20 12:32:48 -07:00

pod_volume_backup_controller_test.go

Add configurable tolerations for PodVolumeBackup and data mover pods (#9575)

2026-09-14 18:05:01 -04:00

pod_volume_backup_controller.go

Add configurable tolerations for PodVolumeBackup and data mover pods (#9575)

2026-09-14 18:05:01 -04:00

pod_volume_restore_controller_test.go

Add configurable tolerations for PodVolumeBackup and data mover pods (#9575)

2026-09-14 18:05:01 -04:00

pod_volume_restore_controller.go

Add configurable tolerations for PodVolumeBackup and data mover pods (#9575)

2026-09-14 18:05:01 -04:00

restore_controller_test.go

Update code to support namespace mapping when perform the in-place restore with block data mover (#10461)

2026-09-16 15:16:29 +08:00

restore_controller.go

Update code to support namespace mapping when perform the in-place restore with block data mover (#10461)

2026-09-16 15:16:29 +08:00

restore_finalizer_controller_test.go

update fallbackFull in restore finalizer

2026-09-11 16:59:51 +08:00

restore_finalizer_controller.go

update fallbackFull in restore finalizer

2026-09-11 16:59:51 +08:00

restore_operations_controller_test.go

bump up kopia to v0.21.1

2025-07-22 15:56:04 +08:00

restore_operations_controller.go

Replace github.com/pkg/errors by github.com/cockroachdb/errors

2026-06-10 15:55:57 +08:00

schedule_controller_test.go

Fix schedule reconciler aliasing server-wide skipImmediately default (#10242)

2026-08-14 16:18:00 +08:00

schedule_controller.go

Fix schedule reconciler to compare SkipImmediately and LastSkipped by value (#10490)

2026-09-16 17:00:29 -04:00

schedule_patch_threshold_test.go

Fix schedule reconciler to compare SkipImmediately and LastSkipped by value (#10490)

2026-09-16 17:00:29 -04:00

server_status_request_controller_test.go

test: resolve remaining Ginkgo V2 and Gomega anti-patterns (#10440)

2026-09-01 06:43:04 +05:30

server_status_request_controller.go

Replace github.com/pkg/errors by github.com/cockroachdb/errors

2026-06-10 15:55:57 +08:00

suite_test.go

Bump Ginkgo to v2.

2024-07-17 15:31:23 +08:00